Re: [PATCH 0/9] GPU-DRM-nouveau: Adjustments for seven function implementations

2023-04-17 Thread Karol Herbst 
On Sun, Apr 16, 2023 at 11:30 AM Markus Elfring  wrote:
>
> Date: Sun, 16 Apr 2023 11:22:23 +0200
>
> Several update suggestions were taken into account
> from static source code analysis.
>

Reviewed-by: Karol Herbst 

> Markus Elfring (9):
>   debugfs: Move an expression into a function call parameter
> in nouveau_debugfs_pstate_set()
>   debugfs: Move a variable assignment behind a null pointer check
> in nouveau_debugfs_pstate_get()
>   debugfs: Use seq_putc()
> in nouveau_debugfs_pstate_get()
>   debugfs: Replace five seq_printf() calls by seq_puts()
> in nouveau_debugfs_pstate_get()
>   power_budget: Move an expression into a macro call parameter
> in nvbios_power_budget_header()
>   clk: Move a variable assignment behind a null pointer check
> in nvkm_pstate_new()
>   pci: Move a variable assignment behind condition checks
> in nvkm_pcie_set_link()
>   pci: Move an expression into a function call parameter
> in nvkm_pcie_set_link()
>   therm: Move an assignment statement behind a null pointer check
> in two functions
>
>  drivers/gpu/drm/nouveau/nouveau_debugfs.c | 19 ++-
>  .../nouveau/nvkm/subdev/bios/power_budget.c   |  3 +--
>  .../gpu/drm/nouveau/nvkm/subdev/clk/base.c|  2 +-
>  .../gpu/drm/nouveau/nvkm/subdev/pci/pcie.c|  7 +++
>  .../drm/nouveau/nvkm/subdev/therm/fanpwm.c|  2 +-
>  .../drm/nouveau/nvkm/subdev/therm/fantog.c|  2 +-
>  6 files changed, 17 insertions(+), 18 deletions(-)
>
> --
> 2.40.0
>

[PATCH 0/9] GPU-DRM-nouveau: Adjustments for seven function implementations

2023-04-16 Thread Markus Elfring 
Date: Sun, 16 Apr 2023 11:22:23 +0200

Several update suggestions were taken into account
from static source code analysis.

Markus Elfring (9):
  debugfs: Move an expression into a function call parameter
in nouveau_debugfs_pstate_set()
  debugfs: Move a variable assignment behind a null pointer check
in nouveau_debugfs_pstate_get()
  debugfs: Use seq_putc()
in nouveau_debugfs_pstate_get()
  debugfs: Replace five seq_printf() calls by seq_puts()
in nouveau_debugfs_pstate_get()
  power_budget: Move an expression into a macro call parameter
in nvbios_power_budget_header()
  clk: Move a variable assignment behind a null pointer check
in nvkm_pstate_new()
  pci: Move a variable assignment behind condition checks
in nvkm_pcie_set_link()
  pci: Move an expression into a function call parameter
in nvkm_pcie_set_link()
  therm: Move an assignment statement behind a null pointer check
in two functions

 drivers/gpu/drm/nouveau/nouveau_debugfs.c | 19 ++-
 .../nouveau/nvkm/subdev/bios/power_budget.c   |  3 +--
 .../gpu/drm/nouveau/nvkm/subdev/clk/base.c|  2 +-
 .../gpu/drm/nouveau/nvkm/subdev/pci/pcie.c|  7 +++
 .../drm/nouveau/nvkm/subdev/therm/fanpwm.c|  2 +-
 .../drm/nouveau/nvkm/subdev/therm/fantog.c|  2 +-
 6 files changed, 17 insertions(+), 18 deletions(-)

--
2.40.0