[PATCH 00/10] drm/exynos: add pm_runtime support

2015-10-19 Thread Inki Dae 
Hi Gustavo,

Please ping~ and re-base on top of exynos-drm-next.

Thanks,
Inki Dae

2015년 09월 05일 05:15에 Gustavo Padovan 이(가) 쓴 글:
> From: Gustavo Padovan 
>
> Hi,
>
> This series adds proper runtime PM suport to CRTCs and Encoders, so
> now instead of relying on 'suspended' or 'enabled' flags to track when
> the CRTC or Encoder is enabled we let the pm_runtime subsystem do it for us
> and remove all the flags. This is a important step to the atomic 
> suspend/resume
> support that will land in drm anytime soon.
>
> Please review!
>
>   Gustavo
>
> Gustavo Padovan (10):
>drm/exynos: do not start enabling DP at bind() phase
>drm/exynos: add pm_runtime to DP
>drm/exynos: add pm_runtime to HDMI
>drm/exynos: add pm_runtime to Mixer
>drm/exynos: remove exynos_crtc commit() callback
>drm/exynos: Remove exynos_crtc commit() callback
>drm/exynos: add pm_runtime to FIMD
>drm/exynos: Enable DP clock directly from FIMD
>drm/exynos: add pm_runtime to DECON 5433
>drm/exynos: add pm_runtime to DECON 7
>
>   drivers/gpu/drm/exynos/exynos5433_drm_decon.c |  90 --
>   drivers/gpu/drm/exynos/exynos7_drm_decon.c| 126 
> +++--
>   drivers/gpu/drm/exynos/exynos_dp_core.c   |  57 ++--
>   drivers/gpu/drm/exynos/exynos_drm_crtc.c  |  10 --
>   drivers/gpu/drm/exynos/exynos_drm_drv.h   |   7 --
>   drivers/gpu/drm/exynos/exynos_drm_fimd.c  | 129 
> --
>   drivers/gpu/drm/exynos/exynos_hdmi.c  |  56 +++
>   drivers/gpu/drm/exynos/exynos_mixer.c | 125 
> -
>   8 files changed, 275 insertions(+), 325 deletions(-)
>

[PATCH 00/10] drm/exynos: add pm_runtime support

2015-10-04 Thread Tobias Jakobi 
Hello Gustavo,

just wanted to ask if the series is still meant to go upstream. I tried
applying the series to torvalds/master and I get a conflict because of
Inki's commit 148ba09c465cc54d8e68f041bf9a30332b315c39 ('drm/exynos: dp:
remove suspend/resume functions').

With best wishes,
Tobias


Gustavo Padovan wrote:
> From: Gustavo Padovan 
> 
> Hi,
> 
> This series adds proper runtime PM suport to CRTCs and Encoders, so
> now instead of relying on 'suspended' or 'enabled' flags to track when
> the CRTC or Encoder is enabled we let the pm_runtime subsystem do it for us
> and remove all the flags. This is a important step to the atomic 
> suspend/resume
> support that will land in drm anytime soon.
> 
> Please review!
> 
>   Gustavo
> 
> Gustavo Padovan (10):
>   drm/exynos: do not start enabling DP at bind() phase
>   drm/exynos: add pm_runtime to DP
>   drm/exynos: add pm_runtime to HDMI
>   drm/exynos: add pm_runtime to Mixer
>   drm/exynos: remove exynos_crtc commit() callback
>   drm/exynos: Remove exynos_crtc commit() callback
>   drm/exynos: add pm_runtime to FIMD
>   drm/exynos: Enable DP clock directly from FIMD
>   drm/exynos: add pm_runtime to DECON 5433
>   drm/exynos: add pm_runtime to DECON 7
> 
>  drivers/gpu/drm/exynos/exynos5433_drm_decon.c |  90 --
>  drivers/gpu/drm/exynos/exynos7_drm_decon.c| 126 +++--
>  drivers/gpu/drm/exynos/exynos_dp_core.c   |  57 ++--
>  drivers/gpu/drm/exynos/exynos_drm_crtc.c  |  10 --
>  drivers/gpu/drm/exynos/exynos_drm_drv.h   |   7 --
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c  | 129 
> --
>  drivers/gpu/drm/exynos/exynos_hdmi.c  |  56 +++
>  drivers/gpu/drm/exynos/exynos_mixer.c | 125 -
>  8 files changed, 275 insertions(+), 325 deletions(-)
>

[PATCH 00/10] drm/exynos: add pm_runtime support

2015-09-21 Thread Andrzej Hajda 
On 09/04/2015 10:15 PM, Gustavo Padovan wrote:
> From: Gustavo Padovan 
> 
> Hi,
> 
> This series adds proper runtime PM suport to CRTCs and Encoders, so
> now instead of relying on 'suspended' or 'enabled' flags to track when
> the CRTC or Encoder is enabled we let the pm_runtime subsystem do it for us
> and remove all the flags. This is a important step to the atomic 
> suspend/resume
> support that will land in drm anytime soon.
> 
> Please review!
> 
>   Gustavo

The title is quite misleading, exynos_drm has already pm_runtime support :)
Could you explain more why do you want to change it, what are requirements of
atomic pm? What is wrong with the current one?

If I remember correctly one of arguments for replacing pm callbacks in
components by one centralized callback in exynos_drm_drv was to avoid issues
with non-deterministic order of calling components suspend callback.
Are there any recent changes in PM, DRM which invalidates the reason above?

On the other side your patchset adds implicit dependency on PM_SLEEP config
option, it should be avoided or at least it should be explicit.

Regards
Andrzej

[PATCH 00/10] drm/exynos: add pm_runtime support

2015-09-11 Thread Gustavo Padovan 
Hi Inki,

Any comment on this series?

Gustavo

2015-09-04 Gustavo Padovan :

> From: Gustavo Padovan 
> 
> Hi,
> 
> This series adds proper runtime PM suport to CRTCs and Encoders, so
> now instead of relying on 'suspended' or 'enabled' flags to track when
> the CRTC or Encoder is enabled we let the pm_runtime subsystem do it for us
> and remove all the flags. This is a important step to the atomic 
> suspend/resume
> support that will land in drm anytime soon.
> 
> Please review!
> 
>   Gustavo
> 
> Gustavo Padovan (10):
>   drm/exynos: do not start enabling DP at bind() phase
>   drm/exynos: add pm_runtime to DP
>   drm/exynos: add pm_runtime to HDMI
>   drm/exynos: add pm_runtime to Mixer
>   drm/exynos: remove exynos_crtc commit() callback
>   drm/exynos: Remove exynos_crtc commit() callback
>   drm/exynos: add pm_runtime to FIMD
>   drm/exynos: Enable DP clock directly from FIMD
>   drm/exynos: add pm_runtime to DECON 5433
>   drm/exynos: add pm_runtime to DECON 7
> 
>  drivers/gpu/drm/exynos/exynos5433_drm_decon.c |  90 --
>  drivers/gpu/drm/exynos/exynos7_drm_decon.c| 126 +++--
>  drivers/gpu/drm/exynos/exynos_dp_core.c   |  57 ++--
>  drivers/gpu/drm/exynos/exynos_drm_crtc.c  |  10 --
>  drivers/gpu/drm/exynos/exynos_drm_drv.h   |   7 --
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c  | 129 
> --
>  drivers/gpu/drm/exynos/exynos_hdmi.c  |  56 +++
>  drivers/gpu/drm/exynos/exynos_mixer.c | 125 -
>  8 files changed, 275 insertions(+), 325 deletions(-)
> 
> -- 
> 2.1.0
>

[PATCH 00/10] drm/exynos: add pm_runtime support

2015-09-04 Thread Gustavo Padovan 
From: Gustavo Padovan 

Hi,

This series adds proper runtime PM suport to CRTCs and Encoders, so
now instead of relying on 'suspended' or 'enabled' flags to track when
the CRTC or Encoder is enabled we let the pm_runtime subsystem do it for us
and remove all the flags. This is a important step to the atomic suspend/resume
support that will land in drm anytime soon.

Please review!

Gustavo

Gustavo Padovan (10):
  drm/exynos: do not start enabling DP at bind() phase
  drm/exynos: add pm_runtime to DP
  drm/exynos: add pm_runtime to HDMI
  drm/exynos: add pm_runtime to Mixer
  drm/exynos: remove exynos_crtc commit() callback
  drm/exynos: Remove exynos_crtc commit() callback
  drm/exynos: add pm_runtime to FIMD
  drm/exynos: Enable DP clock directly from FIMD
  drm/exynos: add pm_runtime to DECON 5433
  drm/exynos: add pm_runtime to DECON 7

 drivers/gpu/drm/exynos/exynos5433_drm_decon.c |  90 --
 drivers/gpu/drm/exynos/exynos7_drm_decon.c| 126 +++--
 drivers/gpu/drm/exynos/exynos_dp_core.c   |  57 ++--
 drivers/gpu/drm/exynos/exynos_drm_crtc.c  |  10 --
 drivers/gpu/drm/exynos/exynos_drm_drv.h   |   7 --
 drivers/gpu/drm/exynos/exynos_drm_fimd.c  | 129 --
 drivers/gpu/drm/exynos/exynos_hdmi.c  |  56 +++
 drivers/gpu/drm/exynos/exynos_mixer.c | 125 -
 8 files changed, 275 insertions(+), 325 deletions(-)

-- 
2.1.0