[PATCH 00/14] drm/exynos: rewrite fimg2d error handling
On 2015ë 08ì 28ì¼ 05:46, Tobias Jakobi wrote: > Hey Emil, > > > Emil Velikov wrote: >> Hi Tobias, >> >> On 24 August 2015 at 15:13, Tobias Jakobi >> wrote: >>> Hello, >>> >>> during the discussion about the last patchset touching the >>> fimg2d code, it became apparent that the error handling for >>> the command submission is currently unsatisfactory. >>> >>> This series rewrites the handling. All functions that submit >>> command buffers now first check if enough space is available >>> and only then proceed to build the command buffers. >>> >>> In particular the command buffer is no longer left in a >>> half-finished state, since parameters passed to the functions >>> are now validated before command submission. For this some >>> validation functions are introduced. >>> >>> This should also increase performance if the bottleneck is >>> the submission part, since adding commands to the buffer >>> is now more lightweight. >>> >>> Last but not least some prefix was added to messages printed >>> by fprintf and printf, and the G2D context struct was moved >>> out of the public header. >>> >>> >> Thanks for going with my earlier suggestion and untangling all this. >> >> I've went through the lot and it looks great afaict. Fwiw for the series >> Reviewed-by: Emil Velikov > thanks for the review and the help on IRC! > > >> As pretty much none of this is hardware specific and/or requires >> additional knowledge of the kernel module I'm inclined to pull this in >> even if we don't get too many reviewers. We better keep it around for >> a couple of weeks in case others are swamped with unrelated work atm, >> yet willing to take a look. > Sure, I'm going to wait and do some pings from time to time :) > I had a review and looks good to me. There are just cleanup issues but no problem to upstream them as-is. However, in my opinion, I think the patch 7 could be more cleaned up. Signed-off-by: Inki Dae Thanks, Inki Dae > > With best wishes, > Tobias > >> >> Cheers, >> Emil >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
[PATCH 00/14] drm/exynos: rewrite fimg2d error handling
Hey Emil, Emil Velikov wrote: > Hi Tobias, > > On 24 August 2015 at 15:13, Tobias Jakobi > wrote: >> Hello, >> >> during the discussion about the last patchset touching the >> fimg2d code, it became apparent that the error handling for >> the command submission is currently unsatisfactory. >> >> This series rewrites the handling. All functions that submit >> command buffers now first check if enough space is available >> and only then proceed to build the command buffers. >> >> In particular the command buffer is no longer left in a >> half-finished state, since parameters passed to the functions >> are now validated before command submission. For this some >> validation functions are introduced. >> >> This should also increase performance if the bottleneck is >> the submission part, since adding commands to the buffer >> is now more lightweight. >> >> Last but not least some prefix was added to messages printed >> by fprintf and printf, and the G2D context struct was moved >> out of the public header. >> >> > Thanks for going with my earlier suggestion and untangling all this. > > I've went through the lot and it looks great afaict. Fwiw for the series > Reviewed-by: Emil Velikov thanks for the review and the help on IRC! > As pretty much none of this is hardware specific and/or requires > additional knowledge of the kernel module I'm inclined to pull this in > even if we don't get too many reviewers. We better keep it around for > a couple of weeks in case others are swamped with unrelated work atm, > yet willing to take a look. Sure, I'm going to wait and do some pings from time to time :) With best wishes, Tobias > > Cheers, > Emil >
[PATCH 00/14] drm/exynos: rewrite fimg2d error handling
Hi Tobias, On 24 August 2015 at 15:13, Tobias Jakobi wrote: > Hello, > > during the discussion about the last patchset touching the > fimg2d code, it became apparent that the error handling for > the command submission is currently unsatisfactory. > > This series rewrites the handling. All functions that submit > command buffers now first check if enough space is available > and only then proceed to build the command buffers. > > In particular the command buffer is no longer left in a > half-finished state, since parameters passed to the functions > are now validated before command submission. For this some > validation functions are introduced. > > This should also increase performance if the bottleneck is > the submission part, since adding commands to the buffer > is now more lightweight. > > Last but not least some prefix was added to messages printed > by fprintf and printf, and the G2D context struct was moved > out of the public header. > > Thanks for going with my earlier suggestion and untangling all this. I've went through the lot and it looks great afaict. Fwiw for the series Reviewed-by: Emil Velikov As pretty much none of this is hardware specific and/or requires additional knowledge of the kernel module I'm inclined to pull this in even if we don't get too many reviewers. We better keep it around for a couple of weeks in case others are swamped with unrelated work atm, yet willing to take a look. Cheers, Emil
[PATCH 00/14] drm/exynos: rewrite fimg2d error handling
Hello, during the discussion about the last patchset touching the fimg2d code, it became apparent that the error handling for the command submission is currently unsatisfactory. This series rewrites the handling. All functions that submit command buffers now first check if enough space is available and only then proceed to build the command buffers. In particular the command buffer is no longer left in a half-finished state, since parameters passed to the functions are now validated before command submission. For this some validation functions are introduced. This should also increase performance if the bottleneck is the submission part, since adding commands to the buffer is now more lightweight. Last but not least some prefix was added to messages printed by fprintf and printf, and the G2D context struct was moved out of the public header. Please review and let me know if I can improve anything! With best wishes, Tobias Tobias Jakobi (14): exynos/fimg2d: fix empty buffer handling in g2d_flush() exynos/fimg2d: simplify base address submission in g2d_scale_and_blend() exynos/fimg2d: add g2d_check_space() exynos/fimg2d: check buffer space in g2d_solid_fill() exynos/fimg2d: check buffer space in g2d_copy() exynos/fimg2d: check buffer space in g2d_copy_with_scale() exynos/fimg2d: add g2d_validate_xyz() functions exynos/fimg2d: check buffer space in g2d_blend() exynos/fimg2d: check buffer space in g2d_scale_and_blend() exynos/fimg2d: remove default case from g2d_get_blend_op() exynos/fimg2d: remove superfluous initialization of g2d_point_val exynos/fimg2d: make g2d_add_cmd() less heavy exynos/fimg2d: add message prefix exynos/fimg2d: remove g2d_context from public header exynos/exynos_fimg2d.c | 367 + exynos/exynos_fimg2d.h | 14 +- 2 files changed, 222 insertions(+), 159 deletions(-) -- 2.0.5
