Re: [PATCH 02/10] accel/ivpu: Call diagnose failure in ivpu_mmu_cmdq_sync()

[Jeffrey Hugo]

On 1/5/2024 4:22 AM, Jacek Lawrynowicz wrote:

From: "Wachowski, Karol" 

Check for possible failure reasons in the buttress.
Some errors (like external abort) should have corresponding buttress errors
registers set indicating the real reason of failure.

Signed-off-by: Wachowski, Karol 
Signed-off-by: Jacek Lawrynowicz 


Reviewed-by: Jeffrey Hugo 

[PATCH 02/10] accel/ivpu: Call diagnose failure in ivpu_mmu_cmdq_sync()

[Jacek Lawrynowicz]

From: "Wachowski, Karol" 

Check for possible failure reasons in the buttress.
Some errors (like external abort) should have corresponding buttress errors
registers set indicating the real reason of failure.

Signed-off-by: Wachowski, Karol 
Signed-off-by: Jacek Lawrynowicz 
---
 drivers/accel/ivpu/ivpu_mmu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/accel/ivpu/ivpu_mmu.c b/drivers/accel/ivpu/ivpu_mmu.c
index 92ef651098d8..1f813625aab3 100644
--- a/drivers/accel/ivpu/ivpu_mmu.c
+++ b/drivers/accel/ivpu/ivpu_mmu.c
@@ -7,6 +7,7 @@
 #include 
 
 #include "ivpu_drv.h"
+#include "ivpu_hw.h"
 #include "ivpu_hw_reg_io.h"
 #include "ivpu_mmu.h"
 #include "ivpu_mmu_context.h"
@@ -518,6 +519,7 @@ static int ivpu_mmu_cmdq_sync(struct ivpu_device *vdev)
 
ivpu_err(vdev, "Timed out waiting for MMU consumer: %d, error: 
%s\n", ret,
 ivpu_mmu_cmdq_err_to_str(err));
+   ivpu_hw_diagnose_failure(vdev);
}
 
return ret;
-- 
2.43.0