Re: [PATCH 03/10] dt-bindings: display: panel: Add Synaptics TD4328
On 2024/4/26 0:11, Rob Herring wrote: On Wed, Apr 24, 2024 at 11:29:08PM +0800, Xilin Wu wrote: Synaptics TD4328 is a display driver IC used to drive LCD DSI panels. Signed-off-by: Xilin Wu --- .../bindings/display/panel/synaptics,td4328.yaml | 69 ++ 1 file changed, 69 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/synaptics,td4328.yaml b/Documentation/devicetree/bindings/display/panel/synaptics,td4328.yaml new file mode 100644 index ..216f2fb22b88 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/synaptics,td4328.yaml @@ -0,0 +1,69 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/synaptics,td4328.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Synaptics TD4328-based DSI display panels + +maintainers: + - Xilin Wu + +description: + The Synaptics TD4328 is a generic DSI Panel IC used to control + LCD panels. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: +contains: + const: syna,td4328 You need a compatible specific to a panel. This can be a fallback though. Unfortunately I have no idea what is the model name of the display assembly. I wonder how the compatible should be named in such case. -- Thanks, Xilin Wu
Re: [PATCH 03/10] dt-bindings: display: panel: Add Synaptics TD4328
On Wed, Apr 24, 2024 at 11:29:08PM +0800, Xilin Wu wrote: > Synaptics TD4328 is a display driver IC used to drive LCD DSI panels. > > Signed-off-by: Xilin Wu > --- > .../bindings/display/panel/synaptics,td4328.yaml | 69 > ++ > 1 file changed, 69 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/panel/synaptics,td4328.yaml > b/Documentation/devicetree/bindings/display/panel/synaptics,td4328.yaml > new file mode 100644 > index ..216f2fb22b88 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/synaptics,td4328.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/synaptics,td4328.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Synaptics TD4328-based DSI display panels > + > +maintainers: > + - Xilin Wu > + > +description: > + The Synaptics TD4328 is a generic DSI Panel IC used to control > + LCD panels. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > +contains: > + const: syna,td4328 You need a compatible specific to a panel. This can be a fallback though. > + > + vdd-supply: > +description: Digital voltage rail > + > + vddio-supply: > +description: Digital I/O voltage rail > + > + reg: true > + port: true > + > +required: > + - compatible > + - reg > + - reset-gpios > + - vdd-supply > + - vddio-supply > + - port > + > +unevaluatedProperties: false > + > +examples: > + - | > +#include > + > +dsi { > +#address-cells = <1>; > +#size-cells = <0>; > + > +panel@0 { > +compatible = "syna,td4328"; > +reg = <0>; > + > +backlight = <&backlight>; > +reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; > + > +vdd-supply = <&vdd_lcm_2p8>; > +vddio-supply = <&vreg_l12b_1p8>; > + > +port { > +panel_in_0: endpoint { > +remote-endpoint = <&dsi0_out>; > +}; > +}; > +}; > +}; > + > +... > > -- > 2.44.0 >
[PATCH 03/10] dt-bindings: display: panel: Add Synaptics TD4328
From: Xilin Wu Synaptics TD4328 is a display driver IC used to drive LCD DSI panels. Signed-off-by: Xilin Wu --- .../bindings/display/panel/synaptics,td4328.yaml | 69 ++ 1 file changed, 69 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/synaptics,td4328.yaml b/Documentation/devicetree/bindings/display/panel/synaptics,td4328.yaml new file mode 100644 index ..216f2fb22b88 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/synaptics,td4328.yaml @@ -0,0 +1,69 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/synaptics,td4328.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Synaptics TD4328-based DSI display panels + +maintainers: + - Xilin Wu + +description: + The Synaptics TD4328 is a generic DSI Panel IC used to control + LCD panels. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: +contains: + const: syna,td4328 + + vdd-supply: +description: Digital voltage rail + + vddio-supply: +description: Digital I/O voltage rail + + reg: true + port: true + +required: + - compatible + - reg + - reset-gpios + - vdd-supply + - vddio-supply + - port + +unevaluatedProperties: false + +examples: + - | +#include + +dsi { +#address-cells = <1>; +#size-cells = <0>; + +panel@0 { +compatible = "syna,td4328"; +reg = <0>; + +backlight = <&backlight>; +reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; + +vdd-supply = <&vdd_lcm_2p8>; +vddio-supply = <&vreg_l12b_1p8>; + +port { +panel_in_0: endpoint { +remote-endpoint = <&dsi0_out>; +}; +}; +}; +}; + +... -- 2.44.0