Re: [PATCH 03/18] video/hdmi: Constify infoframe passed to the log functions

[Hans Verkuil]

On 09/20/18 20:51, Ville Syrjala wrote:
> From: Ville Syrjälä 
> 
> The log functions don't modify the passed in infoframe so make it const.
> 
> Cc: Thierry Reding 
> Cc: Hans Verkuil 

Acked-by: Hans Verkuil 

Thanks,

Hans


> Cc: linux-me...@vger.kernel.org
> Signed-off-by: Ville Syrjälä 
> ---
>  drivers/video/hdmi.c | 22 +++---
>  include/linux/hdmi.h |  2 +-
>  2 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
> index b5d491014b0b..53e7ee2c83fc 100644
> --- a/drivers/video/hdmi.c
> +++ b/drivers/video/hdmi.c
> @@ -471,7 +471,7 @@ static const char *hdmi_infoframe_type_get_name(enum 
> hdmi_infoframe_type type)
>  
>  static void hdmi_infoframe_log_header(const char *level,
> struct device *dev,
> -   struct hdmi_any_infoframe *frame)
> +   const struct hdmi_any_infoframe *frame)
>  {
>   hdmi_log("HDMI infoframe: %s, version %u, length %u\n",
>   hdmi_infoframe_type_get_name(frame->type),
> @@ -673,10 +673,10 @@ hdmi_content_type_get_name(enum hdmi_content_type 
> content_type)
>   */
>  static void hdmi_avi_infoframe_log(const char *level,
>  struct device *dev,
> -struct hdmi_avi_infoframe *frame)
> +const struct hdmi_avi_infoframe *frame)
>  {
>   hdmi_infoframe_log_header(level, dev,
> -   (struct hdmi_any_infoframe *)frame);
> +   (const struct hdmi_any_infoframe *)frame);
>  
>   hdmi_log("colorspace: %s\n",
>   hdmi_colorspace_get_name(frame->colorspace));
> @@ -750,12 +750,12 @@ static const char *hdmi_spd_sdi_get_name(enum 
> hdmi_spd_sdi sdi)
>   */
>  static void hdmi_spd_infoframe_log(const char *level,
>  struct device *dev,
> -struct hdmi_spd_infoframe *frame)
> +const struct hdmi_spd_infoframe *frame)
>  {
>   u8 buf[17];
>  
>   hdmi_infoframe_log_header(level, dev,
> -   (struct hdmi_any_infoframe *)frame);
> +   (const struct hdmi_any_infoframe *)frame);
>  
>   memset(buf, 0, sizeof(buf));
>  
> @@ -886,10 +886,10 @@ hdmi_audio_coding_type_ext_get_name(enum 
> hdmi_audio_coding_type_ext ctx)
>   */
>  static void hdmi_audio_infoframe_log(const char *level,
>struct device *dev,
> -  struct hdmi_audio_infoframe *frame)
> +  const struct hdmi_audio_infoframe *frame)
>  {
>   hdmi_infoframe_log_header(level, dev,
> -   (struct hdmi_any_infoframe *)frame);
> +   (const struct hdmi_any_infoframe *)frame);
>  
>   if (frame->channels)
>   hdmi_log("channels: %u\n", frame->channels - 1);
> @@ -949,12 +949,12 @@ hdmi_3d_structure_get_name(enum hdmi_3d_structure 
> s3d_struct)
>  static void
>  hdmi_vendor_any_infoframe_log(const char *level,
> struct device *dev,
> -   union hdmi_vendor_any_infoframe *frame)
> +   const union hdmi_vendor_any_infoframe *frame)
>  {
> - struct hdmi_vendor_infoframe *hvf = >hdmi;
> + const struct hdmi_vendor_infoframe *hvf = >hdmi;
>  
>   hdmi_infoframe_log_header(level, dev,
> -   (struct hdmi_any_infoframe *)frame);
> +   (const struct hdmi_any_infoframe *)frame);
>  
>   if (frame->any.oui != HDMI_IEEE_OUI) {
>   hdmi_log("not a HDMI vendor infoframe\n");
> @@ -984,7 +984,7 @@ hdmi_vendor_any_infoframe_log(const char *level,
>   */
>  void hdmi_infoframe_log(const char *level,
>   struct device *dev,
> - union hdmi_infoframe *frame)
> + const union hdmi_infoframe *frame)
>  {
>   switch (frame->any.type) {
>   case HDMI_INFOFRAME_TYPE_AVI:
> diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
> index a577d4ae2570..bce1abb1fe57 100644
> --- a/include/linux/hdmi.h
> +++ b/include/linux/hdmi.h
> @@ -335,6 +335,6 @@ hdmi_infoframe_pack(union hdmi_infoframe *frame, void 
> *buffer, size_t size);
>  int hdmi_infoframe_unpack(union hdmi_infoframe *frame,
> const void *buffer, size_t size);
>  void hdmi_infoframe_log(const char *level, struct device *dev,
> - union hdmi_infoframe *frame);
> + const union hdmi_infoframe *frame);
>  
>  #endif /* _DRM_HDMI_H */
> 

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 03/18] video/hdmi: Constify infoframe passed to the log functions

[Ville Syrjala]

From: Ville Syrjälä 

The log functions don't modify the passed in infoframe so make it const.

Cc: Thierry Reding 
Cc: Hans Verkuil 
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ville Syrjälä 
---
 drivers/video/hdmi.c | 22 +++---
 include/linux/hdmi.h |  2 +-
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
index b5d491014b0b..53e7ee2c83fc 100644
--- a/drivers/video/hdmi.c
+++ b/drivers/video/hdmi.c
@@ -471,7 +471,7 @@ static const char *hdmi_infoframe_type_get_name(enum 
hdmi_infoframe_type type)
 
 static void hdmi_infoframe_log_header(const char *level,
  struct device *dev,
- struct hdmi_any_infoframe *frame)
+ const struct hdmi_any_infoframe *frame)
 {
hdmi_log("HDMI infoframe: %s, version %u, length %u\n",
hdmi_infoframe_type_get_name(frame->type),
@@ -673,10 +673,10 @@ hdmi_content_type_get_name(enum hdmi_content_type 
content_type)
  */
 static void hdmi_avi_infoframe_log(const char *level,
   struct device *dev,
-  struct hdmi_avi_infoframe *frame)
+  const struct hdmi_avi_infoframe *frame)
 {
hdmi_infoframe_log_header(level, dev,
- (struct hdmi_any_infoframe *)frame);
+ (const struct hdmi_any_infoframe *)frame);
 
hdmi_log("colorspace: %s\n",
hdmi_colorspace_get_name(frame->colorspace));
@@ -750,12 +750,12 @@ static const char *hdmi_spd_sdi_get_name(enum 
hdmi_spd_sdi sdi)
  */
 static void hdmi_spd_infoframe_log(const char *level,
   struct device *dev,
-  struct hdmi_spd_infoframe *frame)
+  const struct hdmi_spd_infoframe *frame)
 {
u8 buf[17];
 
hdmi_infoframe_log_header(level, dev,
- (struct hdmi_any_infoframe *)frame);
+ (const struct hdmi_any_infoframe *)frame);
 
memset(buf, 0, sizeof(buf));
 
@@ -886,10 +886,10 @@ hdmi_audio_coding_type_ext_get_name(enum 
hdmi_audio_coding_type_ext ctx)
  */
 static void hdmi_audio_infoframe_log(const char *level,
 struct device *dev,
-struct hdmi_audio_infoframe *frame)
+const struct hdmi_audio_infoframe *frame)
 {
hdmi_infoframe_log_header(level, dev,
- (struct hdmi_any_infoframe *)frame);
+ (const struct hdmi_any_infoframe *)frame);
 
if (frame->channels)
hdmi_log("channels: %u\n", frame->channels - 1);
@@ -949,12 +949,12 @@ hdmi_3d_structure_get_name(enum hdmi_3d_structure 
s3d_struct)
 static void
 hdmi_vendor_any_infoframe_log(const char *level,
  struct device *dev,
- union hdmi_vendor_any_infoframe *frame)
+ const union hdmi_vendor_any_infoframe *frame)
 {
-   struct hdmi_vendor_infoframe *hvf = >hdmi;
+   const struct hdmi_vendor_infoframe *hvf = >hdmi;
 
hdmi_infoframe_log_header(level, dev,
- (struct hdmi_any_infoframe *)frame);
+ (const struct hdmi_any_infoframe *)frame);
 
if (frame->any.oui != HDMI_IEEE_OUI) {
hdmi_log("not a HDMI vendor infoframe\n");
@@ -984,7 +984,7 @@ hdmi_vendor_any_infoframe_log(const char *level,
  */
 void hdmi_infoframe_log(const char *level,
struct device *dev,
-   union hdmi_infoframe *frame)
+   const union hdmi_infoframe *frame)
 {
switch (frame->any.type) {
case HDMI_INFOFRAME_TYPE_AVI:
diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
index a577d4ae2570..bce1abb1fe57 100644
--- a/include/linux/hdmi.h
+++ b/include/linux/hdmi.h
@@ -335,6 +335,6 @@ hdmi_infoframe_pack(union hdmi_infoframe *frame, void 
*buffer, size_t size);
 int hdmi_infoframe_unpack(union hdmi_infoframe *frame,
  const void *buffer, size_t size);
 void hdmi_infoframe_log(const char *level, struct device *dev,
-   union hdmi_infoframe *frame);
+   const union hdmi_infoframe *frame);
 
 #endif /* _DRM_HDMI_H */
-- 
2.16.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel