Re: [PATCH 09/20] drm: add helper functions for YCBCR420 handling

2017-07-12 Thread Sharma, Shashank 

Regards

Shashank


On 7/12/2017 10:47 PM, Ville Syrjälä wrote:

On Mon, Jul 10, 2017 at 04:48:37PM +0530, Shashank Sharma wrote:

This patch adds helper functions for YCBCR 420 handling.
These functions do:
- check if a given video mode is YCBCR 420 only mode.
- check if a given video mode is YCBCR 420 also mode.

V2: Added YCBCR functions as helpers in DRM layer, instead of
 keeping it in I915 layer.
V3: Added handling for YCBCR-420 only modes too.
V4: EXPORT_SYMBOL(drm_find_hdmi_output_type)
V5: Addressed review comments from Danvet:
 - %s/drm_find_hdmi_output_type/drm_display_info_hdmi_output_type
 - %s/drm_can_support_ycbcr_output/drm_display_supports_ycbcr_output
 - %s/drm_can_support_this_ycbcr_output/
drm_display_supports_this_ycbcr_output
 - pass drm_display_info instead of drm_connector for consistency
 - For drm_get_highest_quality_ycbcr_supported doc, move the variable
   description above, and then the function description.
V6: Add only YCBCR420 helpers (Ville)

Signed-off-by: Shashank Sharma 
---
  drivers/gpu/drm/drm_modes.c | 74 +
  include/drm/drm_modes.h |  6 
  2 files changed, 80 insertions(+)

diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 3b53c8e3..61c82a38 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -1604,3 +1604,77 @@ int drm_mode_convert_umode(struct drm_display_mode *out,
  out:
return ret;
  }
+
+/**
+ * drm_mode_is_420_only - if a given videomode can be only supported in 
YCBCR420
+ * output format
+ *
+ * @connector: drm connector under action.
+ * @mode: video mode to be tested.
+ *
+ * Returns:
+ * true if the mode can be supported in YCBCR420 format
+ * false if not.
+ */
+bool drm_mode_is_420_only(struct drm_display_info *display,
+   struct drm_display_mode *mode)

Both should be const. Indentation looks busted.

Agree.

+{
+   u8 vic = drm_match_cea_mode(mode);
+
+   /*
+* Requirements of a 420_only mode:
+* must be a valid cea mode
+* entry in 420_only bitmap
+*/
+   if (!drm_valid_cea_vic(vic))
+   return false;

More unnecessary checks.

Ok.
Shashank

+
+   return test_bit(vic, display->hdmi.y420_vdb_modes);
+}
+EXPORT_SYMBOL(drm_mode_is_420_only);
+
+/**
+ * drm_mode_is_420_also - if a given videomode can be supported in YCBCR420
+ * output format also (along with RGB/YCBCR444/422)
+ *
+ * @display: display under action.
+ * @mode: video mode to be tested.
+ *
+ * Returns:
+ * true if the mode can be support YCBCR420 format
+ * false if not.
+ */
+bool drm_mode_is_420_also(struct drm_display_info *display,
+   struct drm_display_mode *mode)
+{
+   u8 vic = drm_match_cea_mode(mode);
+
+   /*
+* Requirements of a 420_also mode:
+* must be a valid cea mode
+* entry in 420_also bitmap
+*/
+   if (!drm_valid_cea_vic(vic))
+   return false;
+
+   return test_bit(vic, display->hdmi.y420_cmdb_modes);
+}
+EXPORT_SYMBOL(drm_mode_is_420_also);
+/**
+ * drm_mode_is_420 - if a given videomode can be supported in YCBCR420
+ * output format
+ *
+ * @display: display under action.
+ * @mode: video mode to be tested.
+ *
+ * Returns:
+ * true if the mode can be supported in YCBCR420 format
+ * false if not.
+ */
+bool drm_mode_is_420(struct drm_display_info *display,
+   struct drm_display_mode *mode)
+{
+   return drm_mode_is_420_only(display, mode) ||
+   drm_mode_is_420_also(display, mode);
+}
+EXPORT_SYMBOL(drm_mode_is_420);
diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
index f8a1268..980db27 100644
--- a/include/drm/drm_modes.h
+++ b/include/drm/drm_modes.h
@@ -452,6 +452,12 @@ int drm_mode_convert_umode(struct drm_display_mode *out,
   const struct drm_mode_modeinfo *in);
  void drm_mode_probed_add(struct drm_connector *connector, struct 
drm_display_mode *mode);
  void drm_mode_debug_printmodeline(const struct drm_display_mode *mode);
+bool drm_mode_is_420_only(struct drm_display_info *display,
+   struct drm_display_mode *mode);
+bool drm_mode_is_420_also(struct drm_display_info *display,
+   struct drm_display_mode *mode);
+bool drm_mode_is_420(struct drm_display_info *display,
+   struct drm_display_mode *mode);
  
  struct drm_display_mode *drm_cvt_mode(struct drm_device *dev,

  int hdisplay, int vdisplay, int vrefresh,
--
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 09/20] drm: add helper functions for YCBCR420 handling

2017-07-12 Thread Ville Syrjälä 
On Mon, Jul 10, 2017 at 04:48:37PM +0530, Shashank Sharma wrote:
> This patch adds helper functions for YCBCR 420 handling.
> These functions do:
> - check if a given video mode is YCBCR 420 only mode.
> - check if a given video mode is YCBCR 420 also mode.
> 
> V2: Added YCBCR functions as helpers in DRM layer, instead of
> keeping it in I915 layer.
> V3: Added handling for YCBCR-420 only modes too.
> V4: EXPORT_SYMBOL(drm_find_hdmi_output_type)
> V5: Addressed review comments from Danvet:
> - %s/drm_find_hdmi_output_type/drm_display_info_hdmi_output_type
> - %s/drm_can_support_ycbcr_output/drm_display_supports_ycbcr_output
> - %s/drm_can_support_this_ycbcr_output/
>   drm_display_supports_this_ycbcr_output
> - pass drm_display_info instead of drm_connector for consistency
> - For drm_get_highest_quality_ycbcr_supported doc, move the variable
>   description above, and then the function description.
> V6: Add only YCBCR420 helpers (Ville)
> 
> Signed-off-by: Shashank Sharma 
> ---
>  drivers/gpu/drm/drm_modes.c | 74 
> +
>  include/drm/drm_modes.h |  6 
>  2 files changed, 80 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index 3b53c8e3..61c82a38 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -1604,3 +1604,77 @@ int drm_mode_convert_umode(struct drm_display_mode 
> *out,
>  out:
>   return ret;
>  }
> +
> +/**
> + * drm_mode_is_420_only - if a given videomode can be only supported in 
> YCBCR420
> + * output format
> + *
> + * @connector: drm connector under action.
> + * @mode: video mode to be tested.
> + *
> + * Returns:
> + * true if the mode can be supported in YCBCR420 format
> + * false if not.
> + */
> +bool drm_mode_is_420_only(struct drm_display_info *display,
> + struct drm_display_mode *mode)

Both should be const. Indentation looks busted.

> +{
> + u8 vic = drm_match_cea_mode(mode);
> +
> + /*
> +  * Requirements of a 420_only mode:
> +  * must be a valid cea mode
> +  * entry in 420_only bitmap
> +  */
> + if (!drm_valid_cea_vic(vic))
> + return false;

More unnecessary checks.

> +
> + return test_bit(vic, display->hdmi.y420_vdb_modes);
> +}
> +EXPORT_SYMBOL(drm_mode_is_420_only);
> +
> +/**
> + * drm_mode_is_420_also - if a given videomode can be supported in YCBCR420
> + * output format also (along with RGB/YCBCR444/422)
> + *
> + * @display: display under action.
> + * @mode: video mode to be tested.
> + *
> + * Returns:
> + * true if the mode can be support YCBCR420 format
> + * false if not.
> + */
> +bool drm_mode_is_420_also(struct drm_display_info *display,
> + struct drm_display_mode *mode)
> +{
> + u8 vic = drm_match_cea_mode(mode);
> +
> + /*
> +  * Requirements of a 420_also mode:
> +  * must be a valid cea mode
> +  * entry in 420_also bitmap
> +  */
> + if (!drm_valid_cea_vic(vic))
> + return false;
> +
> + return test_bit(vic, display->hdmi.y420_cmdb_modes);
> +}
> +EXPORT_SYMBOL(drm_mode_is_420_also);
> +/**
> + * drm_mode_is_420 - if a given videomode can be supported in YCBCR420
> + * output format
> + *
> + * @display: display under action.
> + * @mode: video mode to be tested.
> + *
> + * Returns:
> + * true if the mode can be supported in YCBCR420 format
> + * false if not.
> + */
> +bool drm_mode_is_420(struct drm_display_info *display,
> + struct drm_display_mode *mode)
> +{
> + return drm_mode_is_420_only(display, mode) ||
> + drm_mode_is_420_also(display, mode);
> +}
> +EXPORT_SYMBOL(drm_mode_is_420);
> diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
> index f8a1268..980db27 100644
> --- a/include/drm/drm_modes.h
> +++ b/include/drm/drm_modes.h
> @@ -452,6 +452,12 @@ int drm_mode_convert_umode(struct drm_display_mode *out,
>  const struct drm_mode_modeinfo *in);
>  void drm_mode_probed_add(struct drm_connector *connector, struct 
> drm_display_mode *mode);
>  void drm_mode_debug_printmodeline(const struct drm_display_mode *mode);
> +bool drm_mode_is_420_only(struct drm_display_info *display,
> + struct drm_display_mode *mode);
> +bool drm_mode_is_420_also(struct drm_display_info *display,
> + struct drm_display_mode *mode);
> +bool drm_mode_is_420(struct drm_display_info *display,
> + struct drm_display_mode *mode);
>  
>  struct drm_display_mode *drm_cvt_mode(struct drm_device *dev,
> int hdisplay, int vdisplay, int vrefresh,
> -- 
> 2.7.4
> 
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC

[PATCH 09/20] drm: add helper functions for YCBCR420 handling

2017-07-10 Thread Shashank Sharma 
This patch adds helper functions for YCBCR 420 handling.
These functions do:
- check if a given video mode is YCBCR 420 only mode.
- check if a given video mode is YCBCR 420 also mode.

V2: Added YCBCR functions as helpers in DRM layer, instead of
keeping it in I915 layer.
V3: Added handling for YCBCR-420 only modes too.
V4: EXPORT_SYMBOL(drm_find_hdmi_output_type)
V5: Addressed review comments from Danvet:
- %s/drm_find_hdmi_output_type/drm_display_info_hdmi_output_type
- %s/drm_can_support_ycbcr_output/drm_display_supports_ycbcr_output
- %s/drm_can_support_this_ycbcr_output/
drm_display_supports_this_ycbcr_output
- pass drm_display_info instead of drm_connector for consistency
- For drm_get_highest_quality_ycbcr_supported doc, move the variable
  description above, and then the function description.
V6: Add only YCBCR420 helpers (Ville)

Signed-off-by: Shashank Sharma 
---
 drivers/gpu/drm/drm_modes.c | 74 +
 include/drm/drm_modes.h |  6 
 2 files changed, 80 insertions(+)

diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 3b53c8e3..61c82a38 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -1604,3 +1604,77 @@ int drm_mode_convert_umode(struct drm_display_mode *out,
 out:
return ret;
 }
+
+/**
+ * drm_mode_is_420_only - if a given videomode can be only supported in 
YCBCR420
+ * output format
+ *
+ * @connector: drm connector under action.
+ * @mode: video mode to be tested.
+ *
+ * Returns:
+ * true if the mode can be supported in YCBCR420 format
+ * false if not.
+ */
+bool drm_mode_is_420_only(struct drm_display_info *display,
+   struct drm_display_mode *mode)
+{
+   u8 vic = drm_match_cea_mode(mode);
+
+   /*
+* Requirements of a 420_only mode:
+* must be a valid cea mode
+* entry in 420_only bitmap
+*/
+   if (!drm_valid_cea_vic(vic))
+   return false;
+
+   return test_bit(vic, display->hdmi.y420_vdb_modes);
+}
+EXPORT_SYMBOL(drm_mode_is_420_only);
+
+/**
+ * drm_mode_is_420_also - if a given videomode can be supported in YCBCR420
+ * output format also (along with RGB/YCBCR444/422)
+ *
+ * @display: display under action.
+ * @mode: video mode to be tested.
+ *
+ * Returns:
+ * true if the mode can be support YCBCR420 format
+ * false if not.
+ */
+bool drm_mode_is_420_also(struct drm_display_info *display,
+   struct drm_display_mode *mode)
+{
+   u8 vic = drm_match_cea_mode(mode);
+
+   /*
+* Requirements of a 420_also mode:
+* must be a valid cea mode
+* entry in 420_also bitmap
+*/
+   if (!drm_valid_cea_vic(vic))
+   return false;
+
+   return test_bit(vic, display->hdmi.y420_cmdb_modes);
+}
+EXPORT_SYMBOL(drm_mode_is_420_also);
+/**
+ * drm_mode_is_420 - if a given videomode can be supported in YCBCR420
+ * output format
+ *
+ * @display: display under action.
+ * @mode: video mode to be tested.
+ *
+ * Returns:
+ * true if the mode can be supported in YCBCR420 format
+ * false if not.
+ */
+bool drm_mode_is_420(struct drm_display_info *display,
+   struct drm_display_mode *mode)
+{
+   return drm_mode_is_420_only(display, mode) ||
+   drm_mode_is_420_also(display, mode);
+}
+EXPORT_SYMBOL(drm_mode_is_420);
diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
index f8a1268..980db27 100644
--- a/include/drm/drm_modes.h
+++ b/include/drm/drm_modes.h
@@ -452,6 +452,12 @@ int drm_mode_convert_umode(struct drm_display_mode *out,
   const struct drm_mode_modeinfo *in);
 void drm_mode_probed_add(struct drm_connector *connector, struct 
drm_display_mode *mode);
 void drm_mode_debug_printmodeline(const struct drm_display_mode *mode);
+bool drm_mode_is_420_only(struct drm_display_info *display,
+   struct drm_display_mode *mode);
+bool drm_mode_is_420_also(struct drm_display_info *display,
+   struct drm_display_mode *mode);
+bool drm_mode_is_420(struct drm_display_info *display,
+   struct drm_display_mode *mode);
 
 struct drm_display_mode *drm_cvt_mode(struct drm_device *dev,
  int hdisplay, int vdisplay, int vrefresh,
-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel