Re: [PATCH 1/1] drm/i915: remove unused IO_TLB_SEGPAGES which should be defined by swiotlb
Quoting Dongli Zhang (2019-05-21 05:40:39) > This patch removes IO_TLB_SEGPAGES which is no longer used since > commit 5584f1b1d73e ("drm/i915: fix i915 running as dom0 under Xen"). > > As the define of both IO_TLB_SEGSIZE and IO_TLB_SHIFT are from swiotlb, > IO_TLB_SEGPAGES should be defined on swiotlb side if it is required in the > future. > > Signed-off-by: Dongli Zhang Pushed, thanks for the patch. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/1] drm/i915: remove unused IO_TLB_SEGPAGES which should be defined by swiotlb
Quoting Dongli Zhang (2019-05-21 05:40:39) > This patch removes IO_TLB_SEGPAGES which is no longer used since > commit 5584f1b1d73e ("drm/i915: fix i915 running as dom0 under Xen"). > > As the define of both IO_TLB_SEGSIZE and IO_TLB_SHIFT are from swiotlb, > IO_TLB_SEGPAGES should be defined on swiotlb side if it is required in the > future. It would be wise to refer to commit 5584f1b1d73e9cc95092734c316e467c6c4468f9 Author: Juergen Gross Date: Thu Feb 2 10:47:11 2017 +0100 drm/i915: fix i915 running as dom0 under Xen so the reader can have the history to trawl through. References: 5584f1b1d73e ("drm/i915: fix i915 running as dom0 under Xen") > Signed-off-by: Dongli Zhang Reviewed-by: Chris Wilson -Chris
[PATCH 1/1] drm/i915: remove unused IO_TLB_SEGPAGES which should be defined by swiotlb
This patch removes IO_TLB_SEGPAGES which is no longer used since commit 5584f1b1d73e ("drm/i915: fix i915 running as dom0 under Xen"). As the define of both IO_TLB_SEGSIZE and IO_TLB_SHIFT are from swiotlb, IO_TLB_SEGPAGES should be defined on swiotlb side if it is required in the future. Signed-off-by: Dongli Zhang --- drivers/gpu/drm/i915/i915_gem_internal.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_internal.c b/drivers/gpu/drm/i915/i915_gem_internal.c index ab627ed..2166217 100644 --- a/drivers/gpu/drm/i915/i915_gem_internal.c +++ b/drivers/gpu/drm/i915/i915_gem_internal.c @@ -28,9 +28,6 @@ #define QUIET (__GFP_NORETRY | __GFP_NOWARN) #define MAYFAIL (__GFP_RETRY_MAYFAIL | __GFP_NOWARN) -/* convert swiotlb segment size into sensible units (pages)! */ -#define IO_TLB_SEGPAGES (IO_TLB_SEGSIZE << IO_TLB_SHIFT >> PAGE_SHIFT) - static void internal_free_pages(struct sg_table *st) { struct scatterlist *sg; -- 2.7.4