Re: [PATCH 1/2] drm/bridge/tc358775: Return before displaying inappropriate error message

[Vinay Simha B N]

Reviewed-by: Vinay Simha BN 

On Thu, Jun 16, 2022 at 3:55 AM Jiri Vanek  wrote:

> Function for reading from i2c device register displays error message even
> if reading ends correctly. Add return to avoid falling through into
> the fail label.
>
> Signed-off-by: Jiri Vanek 
> ---
>  drivers/gpu/drm/bridge/tc358775.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/tc358775.c
> b/drivers/gpu/drm/bridge/tc358775.c
> index 62a7ef352daa..cd2721ab02a9 100644
> --- a/drivers/gpu/drm/bridge/tc358775.c
> +++ b/drivers/gpu/drm/bridge/tc358775.c
> @@ -339,6 +339,7 @@ static void d2l_read(struct i2c_client *i2c, u16 addr,
> u32 *val)
> goto fail;
>
> pr_debug("d2l: I2C : addr:%04x value:%08x\n", addr, *val);
> +   return;
>
>  fail:
> dev_err(>dev, "Error %d reading from subaddress 0x%x\n",
> --
> 2.30.2
>
>

-- 
regards,
vinaysimha

[PATCH 1/2] drm/bridge/tc358775: Return before displaying inappropriate error message

[Jiri Vanek]

Function for reading from i2c device register displays error message even
if reading ends correctly. Add return to avoid falling through into
the fail label.

Signed-off-by: Jiri Vanek 
---
 drivers/gpu/drm/bridge/tc358775.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/tc358775.c 
b/drivers/gpu/drm/bridge/tc358775.c
index 62a7ef352daa..cd2721ab02a9 100644
--- a/drivers/gpu/drm/bridge/tc358775.c
+++ b/drivers/gpu/drm/bridge/tc358775.c
@@ -339,6 +339,7 @@ static void d2l_read(struct i2c_client *i2c, u16 addr, u32 
*val)
goto fail;
 
pr_debug("d2l: I2C : addr:%04x value:%08x\n", addr, *val);
+   return;
 
 fail:
dev_err(>dev, "Error %d reading from subaddress 0x%x\n",
-- 
2.30.2