Re: (subset) [PATCH 1/2] drm/imagination: Fix error codes in pvr_device_clk_init()

[Maxime Ripard]

On Thu, 30 Nov 2023 10:26:29 +0300, Dan Carpenter wrote:
> There is a cut and paste error so this code returns the wrong variable.
> 
> 

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime

Re: [PATCH 1/2] drm/imagination: Fix error codes in pvr_device_clk_init()

[Frank Binns]

Hi,

Thank you for the patches.

On Thu, 2023-11-30 at 10:26 +0300, Dan Carpenter wrote:
> There is a cut and paste error so this code returns the wrong variable.
> 
> Fixes: 1f88f017e649 ("drm/imagination: Get GPU resources")
> Signed-off-by: Dan Carpenter 

Reviewed-by: Frank Binns 

> ---
>  drivers/gpu/drm/imagination/pvr_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_device.c 
> b/drivers/gpu/drm/imagination/pvr_device.c
> index 8499becf4fbb..e1dcc4e42087 100644
> --- a/drivers/gpu/drm/imagination/pvr_device.c
> +++ b/drivers/gpu/drm/imagination/pvr_device.c
> @@ -105,12 +105,12 @@ static int pvr_device_clk_init(struct pvr_device 
> *pvr_dev)
>  
>   sys_clk = devm_clk_get_optional(drm_dev->dev, "sys");
>   if (IS_ERR(sys_clk))
> - return dev_err_probe(drm_dev->dev, PTR_ERR(core_clk),
> + return dev_err_probe(drm_dev->dev, PTR_ERR(sys_clk),
>"failed to get sys clock\n");
>  
>   mem_clk = devm_clk_get_optional(drm_dev->dev, "mem");
>   if (IS_ERR(mem_clk))
> - return dev_err_probe(drm_dev->dev, PTR_ERR(core_clk),
> + return dev_err_probe(drm_dev->dev, PTR_ERR(mem_clk),
>"failed to get mem clock\n");
>  
>   pvr_dev->core_clk = core_clk;

[PATCH 1/2] drm/imagination: Fix error codes in pvr_device_clk_init()

[Dan Carpenter]

There is a cut and paste error so this code returns the wrong variable.

Fixes: 1f88f017e649 ("drm/imagination: Get GPU resources")
Signed-off-by: Dan Carpenter 
---
 drivers/gpu/drm/imagination/pvr_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/imagination/pvr_device.c 
b/drivers/gpu/drm/imagination/pvr_device.c
index 8499becf4fbb..e1dcc4e42087 100644
--- a/drivers/gpu/drm/imagination/pvr_device.c
+++ b/drivers/gpu/drm/imagination/pvr_device.c
@@ -105,12 +105,12 @@ static int pvr_device_clk_init(struct pvr_device *pvr_dev)
 
sys_clk = devm_clk_get_optional(drm_dev->dev, "sys");
if (IS_ERR(sys_clk))
-   return dev_err_probe(drm_dev->dev, PTR_ERR(core_clk),
+   return dev_err_probe(drm_dev->dev, PTR_ERR(sys_clk),
 "failed to get sys clock\n");
 
mem_clk = devm_clk_get_optional(drm_dev->dev, "mem");
if (IS_ERR(mem_clk))
-   return dev_err_probe(drm_dev->dev, PTR_ERR(core_clk),
+   return dev_err_probe(drm_dev->dev, PTR_ERR(mem_clk),
 "failed to get mem clock\n");
 
pvr_dev->core_clk = core_clk;
-- 
2.42.0