Re: [PATCH 1/2] drm/panel: Add DT bindings for Novatek NT35510-based panels
Hi Linus
On Sat, Jan 04, 2020 at 06:27:17PM +0100, Sam Ravnborg wrote:
> Hi Linus.
>
> On Wed, Dec 25, 2019 at 12:56:09PM +0100, Linus Walleij wrote:
> > This adds device tree bindings for the Novatek NT35510-based
> > family of panels. Since several such panels are in existence
> > we define bindings common for all, and define the compatible
> > string for one certain panel (Hydis HVA40WV1).
Reading this once more make me think that the right way to do this
is to have two compatible's.
enum
- novatek,nt35510
- hydis,hva40wv1
So there shall be a match for both.
Then we have explicit documented that this is the combination of
a specific controller and a specific panel.
Sam
> >
> > As other panels are discovered and investigated, we can add
> > more compatibles to the binding.
> >
> > Cc: Stephan Gerhold
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Linus Walleij
> > ---
> > .../display/panel/novatek-nt35510.yaml| 53 +++
> > 1 file changed, 53 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
> > b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
> > new file mode 100644
> > index ..a4a6b5adf15b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
> > @@ -0,0 +1,53 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/novatek-nt35510.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Novatek NT35510-based display panels
> > +
> > +maintainers:
> > + - Linus Walleij
> > +
> > +allOf:
> > + - $ref: panel-common.yaml#
> > +
> > +properties:
> > + compatible:
> > +const: hydis,hva40wv1
> compatible fail to match filename - which is common practice.
> And hydis is not a known vendor-prefix.
>
>
> > +description: This indicates the panel manufacturer of the panel
> > + that is in turn using the NT35510 panel driver. The compatible
> > + string determines how the NT35510 panel driver shall be configured
> > + to work with the indicated panel.
> The description is just a general description of what compatible is used
> for.
> Please drop it as it does not provide anything specific for the panel.
>
> Sam
>
> > + reg: true
> > + reset-gpios: true
> > + vdd-supply:
> > + description: regulator that supplies the vdd voltage
> > + vddi-supply:
> > + description: regulator that supplies the vddi voltage
> > + backlight: true
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > +#include
> > +
> > +dsi@a0351000 {
> > +#address-cells = <1>;
> > +#size-cells = <0>;
> > +panel {
> > +compatible = "hydis,hva40wv1";
> > +reg = <0>;
> > +vdd-supply = <_ldo_aux4_reg>;
> > +vddi-supply = <_ldo_aux6_reg>;
> > +reset-gpios = < 11 GPIO_ACTIVE_LOW>;
> > +backlight = <_bl>;
> > +};
> > +};
> > +
> > +...
> > --
> > 2.21.0
> >
> > ___
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/2] drm/panel: Add DT bindings for Novatek NT35510-based panels
Hi Linus.
On Wed, Dec 25, 2019 at 12:56:09PM +0100, Linus Walleij wrote:
> This adds device tree bindings for the Novatek NT35510-based
> family of panels. Since several such panels are in existence
> we define bindings common for all, and define the compatible
> string for one certain panel (Hydis HVA40WV1).
>
> As other panels are discovered and investigated, we can add
> more compatibles to the binding.
>
> Cc: Stephan Gerhold
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Linus Walleij
> ---
> .../display/panel/novatek-nt35510.yaml| 53 +++
> 1 file changed, 53 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
> b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
> new file mode 100644
> index ..a4a6b5adf15b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/novatek-nt35510.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Novatek NT35510-based display panels
> +
> +maintainers:
> + - Linus Walleij
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> +const: hydis,hva40wv1
compatible fail to match filename - which is common practice.
And hydis is not a known vendor-prefix.
> +description: This indicates the panel manufacturer of the panel
> + that is in turn using the NT35510 panel driver. The compatible
> + string determines how the NT35510 panel driver shall be configured
> + to work with the indicated panel.
The description is just a general description of what compatible is used
for.
Please drop it as it does not provide anything specific for the panel.
Sam
> + reg: true
> + reset-gpios: true
> + vdd-supply:
> + description: regulator that supplies the vdd voltage
> + vddi-supply:
> + description: regulator that supplies the vddi voltage
> + backlight: true
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +#include
> +
> +dsi@a0351000 {
> +#address-cells = <1>;
> +#size-cells = <0>;
> +panel {
> +compatible = "hydis,hva40wv1";
> +reg = <0>;
> +vdd-supply = <_ldo_aux4_reg>;
> +vddi-supply = <_ldo_aux6_reg>;
> +reset-gpios = < 11 GPIO_ACTIVE_LOW>;
> +backlight = <_bl>;
> +};
> +};
> +
> +...
> --
> 2.21.0
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 1/2] drm/panel: Add DT bindings for Novatek NT35510-based panels
This adds device tree bindings for the Novatek NT35510-based
family of panels. Since several such panels are in existence
we define bindings common for all, and define the compatible
string for one certain panel (Hydis HVA40WV1).
As other panels are discovered and investigated, we can add
more compatibles to the binding.
Cc: Stephan Gerhold
Cc: devicet...@vger.kernel.org
Signed-off-by: Linus Walleij
---
.../display/panel/novatek-nt35510.yaml| 53 +++
1 file changed, 53 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
diff --git
a/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
new file mode 100644
index ..a4a6b5adf15b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/novatek-nt35510.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Novatek NT35510-based display panels
+
+maintainers:
+ - Linus Walleij
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+const: hydis,hva40wv1
+description: This indicates the panel manufacturer of the panel
+ that is in turn using the NT35510 panel driver. The compatible
+ string determines how the NT35510 panel driver shall be configured
+ to work with the indicated panel.
+ reg: true
+ reset-gpios: true
+ vdd-supply:
+ description: regulator that supplies the vdd voltage
+ vddi-supply:
+ description: regulator that supplies the vddi voltage
+ backlight: true
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+#include
+
+dsi@a0351000 {
+#address-cells = <1>;
+#size-cells = <0>;
+panel {
+compatible = "hydis,hva40wv1";
+reg = <0>;
+vdd-supply = <_ldo_aux4_reg>;
+vddi-supply = <_ldo_aux6_reg>;
+reset-gpios = < 11 GPIO_ACTIVE_LOW>;
+backlight = <_bl>;
+};
+};
+
+...
--
2.21.0
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
