Re: [PATCH 1/2] drm: gm12u320: Some minor cleanups
Hi, On 01-08-19 16:59, Sam Ravnborg wrote: Hi Hans. On Tue, Jul 30, 2019 at 03:38:56PM +0200, Hans de Goede wrote: 3 small cleanups: 1) Drop unused DRIVER_PATCHLEVEL 2) We do not set mode_config.preferred_depth, so instead of passing the unset mode_config.preferred_depth to drm_fbdev_generic_setup simply pass 0 3) Use __maybe_unused instead of #ifdef CONFIG_PM around the suspend / resume functions Cc: Sam Ravnborg Suggested-by: Sam Ravnborg If you add: Suggested-by: Noralf Trønnes And adjust to the new location. Then this is: Reviewed-by: Sam Ravnborg I've just pushed these to drm-misc-next, thank you for your input and reviews. Regards, Hans ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/2] drm: gm12u320: Some minor cleanups
Hi, On 8/1/19 4:59 PM, Sam Ravnborg wrote: Hi Hans. On Tue, Jul 30, 2019 at 03:38:56PM +0200, Hans de Goede wrote: 3 small cleanups: 1) Drop unused DRIVER_PATCHLEVEL 2) We do not set mode_config.preferred_depth, so instead of passing the unset mode_config.preferred_depth to drm_fbdev_generic_setup simply pass 0 3) Use __maybe_unused instead of #ifdef CONFIG_PM around the suspend / resume functions Cc: Sam Ravnborg Suggested-by: Sam Ravnborg If you add: Suggested-by: Noralf Trønnes And adjust to the new location. Then this is: Reviewed-by: Sam Ravnborg Thank you for the review. I will push this to drm-misc-next, with the suggested changes, tomorrow (when I'm back behind my workstation which has all the necessary kernel trees). Regards, Hans ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/2] drm: gm12u320: Some minor cleanups
Hi Hans. On Tue, Jul 30, 2019 at 03:38:56PM +0200, Hans de Goede wrote: > 3 small cleanups: > > 1) Drop unused DRIVER_PATCHLEVEL > 2) We do not set mode_config.preferred_depth, so instead of passing the >unset mode_config.preferred_depth to drm_fbdev_generic_setup >simply pass 0 > 3) Use __maybe_unused instead of #ifdef CONFIG_PM around the suspend / >resume functions > > Cc: Sam Ravnborg > Suggested-by: Sam Ravnborg If you add: Suggested-by: Noralf Trønnes And adjust to the new location. Then this is: Reviewed-by: Sam Ravnborg > Signed-off-by: Hans de Goede Sam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 1/2] drm: gm12u320: Some minor cleanups
3 small cleanups:
1) Drop unused DRIVER_PATCHLEVEL
2) We do not set mode_config.preferred_depth, so instead of passing the
unset mode_config.preferred_depth to drm_fbdev_generic_setup
simply pass 0
3) Use __maybe_unused instead of #ifdef CONFIG_PM around the suspend /
resume functions
Cc: Sam Ravnborg
Suggested-by: Sam Ravnborg
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gm12u320/gm12u320.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/gm12u320/gm12u320.c
b/drivers/gpu/drm/gm12u320/gm12u320.c
index 3dfe86defefc..a60854d7c14c 100644
--- a/drivers/gpu/drm/gm12u320/gm12u320.c
+++ b/drivers/gpu/drm/gm12u320/gm12u320.c
@@ -33,7 +33,6 @@ MODULE_PARM_DESC(eco_mode, "Turn on Eco mode (less bright,
more silent)");
#define DRIVER_DATE"2019"
#define DRIVER_MAJOR 1
#define DRIVER_MINOR 0
-#define DRIVER_PATCHLEVEL 1
/*
* The DLP has an actual width of 854 pixels, but that is not a multiple
@@ -747,7 +746,7 @@ static int gm12u320_usb_probe(struct usb_interface
*interface,
if (ret)
goto err_put;
- drm_fbdev_generic_setup(dev, dev->mode_config.preferred_depth);
+ drm_fbdev_generic_setup(dev, 0);
return 0;
@@ -766,9 +765,8 @@ static void gm12u320_usb_disconnect(struct usb_interface
*interface)
drm_dev_put(dev);
}
-#ifdef CONFIG_PM
-static int gm12u320_suspend(struct usb_interface *interface,
- pm_message_t message)
+static __maybe_unused int gm12u320_suspend(struct usb_interface *interface,
+ pm_message_t message)
{
struct drm_device *dev = usb_get_intfdata(interface);
struct gm12u320_device *gm12u320 = dev->dev_private;
@@ -779,7 +777,7 @@ static int gm12u320_suspend(struct usb_interface *interface,
return 0;
}
-static int gm12u320_resume(struct usb_interface *interface)
+static __maybe_unused int gm12u320_resume(struct usb_interface *interface)
{
struct drm_device *dev = usb_get_intfdata(interface);
struct gm12u320_device *gm12u320 = dev->dev_private;
@@ -790,7 +788,6 @@ static int gm12u320_resume(struct usb_interface *interface)
return 0;
}
-#endif
static const struct usb_device_id id_table[] = {
{ USB_DEVICE(0x1de1, 0xc102) },
--
2.21.0
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
