Re: [PATCH 1/2] dt-bindings: backlight: Add Texas Instruments LM3509 bindings
On Sat, Mar 02, 2024 at 10:27:56PM +0100, Patrick Gansterer wrote: > Add Device Tree bindings for Texas Instruments LM3509 - a > High Efficiency Boost for White LED's and/or OLED Displays > > Signed-off-by: Patrick Gansterer > --- > > + ti,unison-mode: > +description: | > + Enable unison mode. If disabled, then it will provide two > + independent controllable LED currents for BMAIN and BSUB. > +type: boolean How does not-unison mode interact with the backlight property in panel-common.yaml ? If this mode intended to provide two strings that can be controlled by different panels then a phandle link will no longer be sufficient to describe the connectivity. Daniel.
Re: [PATCH 1/2] dt-bindings: backlight: Add Texas Instruments LM3509 bindings
On 02/03/2024 22:27, Patrick Gansterer wrote:
> Add Device Tree bindings for Texas Instruments LM3509 - a
> High Efficiency Boost for White LED's and/or OLED Displays
>
> Signed-off-by: Patrick Gansterer
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> ---
> .../bindings/leds/backlight/ti,lm3509.yaml| 81 +++
> 1 file changed, 81 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/leds/backlight/ti,lm3509.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/ti,lm3509.yaml
> b/Documentation/devicetree/bindings/leds/backlight/ti,lm3509.yaml
> new file mode 100644
> index ..8fbb83934e30
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/ti,lm3509.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/ti,lm3509.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI LM3509 High Efficiency Boost for White LED's and/or OLED Displays
> +
> +maintainers:
> + - Patrick Gansterer
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + The LM3509 current mode boost converter offers two separate outputs.
> + https://www.ti.com/product/LM3509
> +
Missing allOf with ref to common.yaml
> +properties:
> + compatible:
> +const: ti,lm3509
> +
> + reg:
> +maxItems: 1
> +
> + reset-gpios:
> +maxItems: 1
> +
> + default-brightness:
> +minimum: 0
> +maximum: 15
> +
> + max-brightness:
> +minimum: 0
> +maximum: 15
> +
> + ti,brightness-rate-of-change-us:
> +description: Brightness Rate of Change in microseconds.
> +enum: [51, 13000, 26000, 52000]
> +
> + ti,oled-mode:
> +description: Enable OLED mode.
> +type: boolean
> +
> + ti,unison-mode:
> +description: |
Do not need '|' unless you need to preserve formatting.
> + Enable unison mode. If disabled, then it will provide two
> + independent controllable LED currents for BMAIN and BSUB.
> +type: boolean
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
unevaluatedProperties instead (open existing bindings and look how they
do it).
> +
> +examples:
> + - |
> +#include
> +i2c {
> +#address-cells = <1>;
> +#size-cells = <0>;
> +
> +backlight@36 {
> +compatible = "ti,lm3509";
> +reg = <0x36>;
> +
> +reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
> +
> +ti,unison-mode;
> +};
> +};
> + - |
> +i2c {
> +#address-cells = <1>;
> +#size-cells = <0>;
> +
> +backlight@36 {
> +compatible = "ti,lm3509";
> +reg = <0x36>;
> +
> +ti,brightness-rate-of-change-us = <52000>;
Just combine these examples.
> +};
> +};
Best regards,
Krzysztof
[PATCH 1/2] dt-bindings: backlight: Add Texas Instruments LM3509 bindings
Add Device Tree bindings for Texas Instruments LM3509 - a
High Efficiency Boost for White LED's and/or OLED Displays
Signed-off-by: Patrick Gansterer
---
.../bindings/leds/backlight/ti,lm3509.yaml| 81 +++
1 file changed, 81 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/backlight/ti,lm3509.yaml
diff --git a/Documentation/devicetree/bindings/leds/backlight/ti,lm3509.yaml
b/Documentation/devicetree/bindings/leds/backlight/ti,lm3509.yaml
new file mode 100644
index ..8fbb83934e30
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/backlight/ti,lm3509.yaml
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/ti,lm3509.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI LM3509 High Efficiency Boost for White LED's and/or OLED Displays
+
+maintainers:
+ - Patrick Gansterer
+
+description: |
+ The LM3509 current mode boost converter offers two separate outputs.
+ https://www.ti.com/product/LM3509
+
+properties:
+ compatible:
+const: ti,lm3509
+
+ reg:
+maxItems: 1
+
+ reset-gpios:
+maxItems: 1
+
+ default-brightness:
+minimum: 0
+maximum: 15
+
+ max-brightness:
+minimum: 0
+maximum: 15
+
+ ti,brightness-rate-of-change-us:
+description: Brightness Rate of Change in microseconds.
+enum: [51, 13000, 26000, 52000]
+
+ ti,oled-mode:
+description: Enable OLED mode.
+type: boolean
+
+ ti,unison-mode:
+description: |
+ Enable unison mode. If disabled, then it will provide two
+ independent controllable LED currents for BMAIN and BSUB.
+type: boolean
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+#include
+i2c {
+#address-cells = <1>;
+#size-cells = <0>;
+
+backlight@36 {
+compatible = "ti,lm3509";
+reg = <0x36>;
+
+reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
+
+ti,unison-mode;
+};
+};
+ - |
+i2c {
+#address-cells = <1>;
+#size-cells = <0>;
+
+backlight@36 {
+compatible = "ti,lm3509";
+reg = <0x36>;
+
+ti,brightness-rate-of-change-us = <52000>;
+};
+};
--
2.44.0
