[PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage()

2016-07-11 Thread Philipp Zabel
Am Samstag, den 09.07.2016, 18:57 -0300 schrieb Fabio Estevam:
> From: Fabio Estevam 
> 
> regulator_set_voltage() may fail, so we better check its return value
> and propagate it in the case of error.
> 
> Signed-off-by: Fabio Estevam 

Applied all three, thank you.

regards
Philipp



[PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage()

2016-07-09 Thread Fabio Estevam
From: Fabio Estevam 

regulator_set_voltage() may fail, so we better check its return value
and propagate it in the case of error.

Signed-off-by: Fabio Estevam 
---
 drivers/gpu/drm/imx/imx-tve.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index baf7881..c93301c 100644
--- a/drivers/gpu/drm/imx/imx-tve.c
+++ b/drivers/gpu/drm/imx/imx-tve.c
@@ -633,7 +633,9 @@ static int imx_tve_bind(struct device *dev, struct device 
*master, void *data)

tve->dac_reg = devm_regulator_get(dev, "dac");
if (!IS_ERR(tve->dac_reg)) {
-   regulator_set_voltage(tve->dac_reg, 275, 275);
+   ret = regulator_set_voltage(tve->dac_reg, 275, 275);
+   if (ret)
+   return ret;
ret = regulator_enable(tve->dac_reg);
if (ret)
return ret;
-- 
1.9.1