Re: [PATCH 1/4] drm: lcdif: Fix indentation in lcdif_regs.h
Quoting Laurent Pinchart (2022-09-28 00:38:18) > A couple of the register macro values are incorrectly indented. Fix > them. > Reviewed-by: Kieran Bingham > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/mxsfb/lcdif_regs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_regs.h > b/drivers/gpu/drm/mxsfb/lcdif_regs.h > index 8e8bef175bf2..013f2cace2a0 100644 > --- a/drivers/gpu/drm/mxsfb/lcdif_regs.h > +++ b/drivers/gpu/drm/mxsfb/lcdif_regs.h > @@ -130,7 +130,7 @@ > #define CTRL_FETCH_START_OPTION_BPVBIT(9) > #define CTRL_FETCH_START_OPTION_RESV GENMASK(9, 8) > #define CTRL_FETCH_START_OPTION_MASK GENMASK(9, 8) > -#define CTRL_NEG BIT(4) > +#define CTRL_NEG BIT(4) > #define CTRL_INV_PXCK BIT(3) > #define CTRL_INV_DEBIT(2) > #define CTRL_INV_VSBIT(1) > @@ -186,7 +186,7 @@ > #define INT_ENABLE_D1_PLANE_PANIC_EN BIT(0) > > #define CTRLDESCL0_1_HEIGHT(n) (((n) & 0x) << 16) > -#define CTRLDESCL0_1_HEIGHT_MASK GENMASK(31, 16) > +#define CTRLDESCL0_1_HEIGHT_MASK GENMASK(31, 16) > #define CTRLDESCL0_1_WIDTH(n) ((n) & 0x) > #define CTRLDESCL0_1_WIDTH_MASKGENMASK(15, 0) > > -- > Regards, > > Laurent Pinchart >
Re: [PATCH 1/4] drm: lcdif: Fix indentation in lcdif_regs.h
On 9/28/22 01:38, Laurent Pinchart wrote: A couple of the register macro values are incorrectly indented. Fix them. Signed-off-by: Laurent Pinchart Reviewed-by: Marek Vasut
[PATCH 1/4] drm: lcdif: Fix indentation in lcdif_regs.h
A couple of the register macro values are incorrectly indented. Fix them. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/mxsfb/lcdif_regs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_regs.h b/drivers/gpu/drm/mxsfb/lcdif_regs.h index 8e8bef175bf2..013f2cace2a0 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_regs.h +++ b/drivers/gpu/drm/mxsfb/lcdif_regs.h @@ -130,7 +130,7 @@ #define CTRL_FETCH_START_OPTION_BPVBIT(9) #define CTRL_FETCH_START_OPTION_RESV GENMASK(9, 8) #define CTRL_FETCH_START_OPTION_MASK GENMASK(9, 8) -#define CTRL_NEG BIT(4) +#define CTRL_NEG BIT(4) #define CTRL_INV_PXCK BIT(3) #define CTRL_INV_DEBIT(2) #define CTRL_INV_VSBIT(1) @@ -186,7 +186,7 @@ #define INT_ENABLE_D1_PLANE_PANIC_EN BIT(0) #define CTRLDESCL0_1_HEIGHT(n) (((n) & 0x) << 16) -#define CTRLDESCL0_1_HEIGHT_MASK GENMASK(31, 16) +#define CTRLDESCL0_1_HEIGHT_MASK GENMASK(31, 16) #define CTRLDESCL0_1_WIDTH(n) ((n) & 0x) #define CTRLDESCL0_1_WIDTH_MASKGENMASK(15, 0) -- Regards, Laurent Pinchart
