Re: [PATCH 1/6] dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings
On Sun, Jun 16, 2019 at 7:29 AM Brian Masney wrote:
>
> Add device tree bindings for the On Chip Memory (OCMEM) that is present
> on some Qualcomm Snapdragon SoCs.
>
> Signed-off-by: Brian Masney
> ---
> .../bindings/soc/qcom/qcom,ocmem.yaml | 66 +++
.../bindings/sram/
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
> b/Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
> new file mode 100644
> index ..5e3ae6311a16
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/qcom,ocmem.yaml#
schemas/sram/
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: On Chip Memory (OCMEM) that is present on some Qualcomm Snapdragon
> SoCs.
> +
> +maintainers:
> + - Brian Masney
> +
> +description: |
> + The On Chip Memory (OCMEM) allocator allows various clients to allocate
> memory
Is there something in the h/w that's an allocator? That's typically a
s/w thing that has nothing to do with h/w description.
> + from OCMEM based on performance, latency and power requirements. This is
> + typically used by the GPU, camera/video, and audio components on some
> + Snapdragon SoCs.
> +
> +properties:
> + compatible:
> +const: qcom,ocmem-msm8974
What Bjorn said...
> +
> + reg:
> +items:
> + - description: Control registers
> + - description: OCMEM address range
> +
> + reg-names:
> +items:
> + - const: ocmem_ctrl_physical
> + - const: ocmem_physical
'ctrl' and 'mem' would be sufficient.
> +
> + clocks:
> +items:
> + - description: Core clock
> + - description: Interface clock
> +
> + clock-names:
> +items:
> + - const: core
> + - const: iface
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - clocks
> + - clock-names
> +
> +examples:
> + - |
> + #include
> + #include
> +
> + ocmem: ocmem@fdd0 {
> +compatible = "qcom,ocmem-msm8974";
> +
> +reg = <0xfdd0 0x2000>,
> + <0xfec0 0x18>;
> +reg-names = "ocmem_ctrl_physical",
> +"ocmem_physical";
> +
> +clocks = < RPM_SMD_OCMEMGX_CLK>,
> + < OCMEMCX_OCMEMNOC_CLK>;
> +clock-names = "core",
> + "iface";
> + };
> --
> 2.20.1
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/6] dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings
On Sun 16 Jun 06:29 PDT 2019, Brian Masney wrote:
> Add device tree bindings for the On Chip Memory (OCMEM) that is present
> on some Qualcomm Snapdragon SoCs.
>
> Signed-off-by: Brian Masney
> ---
> .../bindings/soc/qcom/qcom,ocmem.yaml | 66 +++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
> b/Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
> new file mode 100644
> index ..5e3ae6311a16
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/qcom,ocmem.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: On Chip Memory (OCMEM) that is present on some Qualcomm Snapdragon
> SoCs.
> +
> +maintainers:
> + - Brian Masney
> +
> +description: |
> + The On Chip Memory (OCMEM) allocator allows various clients to allocate
> memory
> + from OCMEM based on performance, latency and power requirements. This is
> + typically used by the GPU, camera/video, and audio components on some
> + Snapdragon SoCs.
> +
> +properties:
> + compatible:
> +const: qcom,ocmem-msm8974
qcom,msm8974-ocmem
> +
> + reg:
> +items:
> + - description: Control registers
> + - description: OCMEM address range
> +
> + reg-names:
> +items:
> + - const: ocmem_ctrl_physical
> + - const: ocmem_physical
Drop the "_physical" part, it's given by this being "reg".
Regards,
Bjorn
> +
> + clocks:
> +items:
> + - description: Core clock
> + - description: Interface clock
> +
> + clock-names:
> +items:
> + - const: core
> + - const: iface
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - clocks
> + - clock-names
> +
> +examples:
> + - |
> + #include
> + #include
> +
> + ocmem: ocmem@fdd0 {
> +compatible = "qcom,ocmem-msm8974";
> +
> +reg = <0xfdd0 0x2000>,
> + <0xfec0 0x18>;
> +reg-names = "ocmem_ctrl_physical",
> +"ocmem_physical";
> +
> +clocks = < RPM_SMD_OCMEMGX_CLK>,
> + < OCMEMCX_OCMEMNOC_CLK>;
> +clock-names = "core",
> + "iface";
> + };
> --
> 2.20.1
>
[PATCH 1/6] dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings
Add device tree bindings for the On Chip Memory (OCMEM) that is present
on some Qualcomm Snapdragon SoCs.
Signed-off-by: Brian Masney
---
.../bindings/soc/qcom/qcom,ocmem.yaml | 66 +++
1 file changed, 66 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
b/Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
new file mode 100644
index ..5e3ae6311a16
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,ocmem.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/qcom/qcom,ocmem.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: On Chip Memory (OCMEM) that is present on some Qualcomm Snapdragon SoCs.
+
+maintainers:
+ - Brian Masney
+
+description: |
+ The On Chip Memory (OCMEM) allocator allows various clients to allocate
memory
+ from OCMEM based on performance, latency and power requirements. This is
+ typically used by the GPU, camera/video, and audio components on some
+ Snapdragon SoCs.
+
+properties:
+ compatible:
+const: qcom,ocmem-msm8974
+
+ reg:
+items:
+ - description: Control registers
+ - description: OCMEM address range
+
+ reg-names:
+items:
+ - const: ocmem_ctrl_physical
+ - const: ocmem_physical
+
+ clocks:
+items:
+ - description: Core clock
+ - description: Interface clock
+
+ clock-names:
+items:
+ - const: core
+ - const: iface
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+ - clock-names
+
+examples:
+ - |
+ #include
+ #include
+
+ ocmem: ocmem@fdd0 {
+compatible = "qcom,ocmem-msm8974";
+
+reg = <0xfdd0 0x2000>,
+ <0xfec0 0x18>;
+reg-names = "ocmem_ctrl_physical",
+"ocmem_physical";
+
+clocks = < RPM_SMD_OCMEMGX_CLK>,
+ < OCMEMCX_OCMEMNOC_CLK>;
+clock-names = "core",
+ "iface";
+ };
--
2.20.1
