Re: [PATCH 10/11] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support
Hi Laurent, On Sun, Apr 10, 2022 at 11:42 PM Laurent Pinchart wrote: > > Hi Jagan, > > Thank you for the patch. > > On Fri, Apr 08, 2022 at 09:51:07PM +0530, Jagan Teki wrote: > > Samsung MIPI DSIM bridge can also be found in i.MX8MM/i.MX8MN SoC. > > > > Add dt-bingings for it. > > > > v1: > > * new patch > > > > Signed-off-by: Jagan Teki > > --- > > Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > > b/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > > index be377786e8cd..5133d4d39190 100644 > > --- a/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > > +++ b/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > > @@ -7,6 +7,7 @@ Required properties: > > May I try and ask you to convert the DT bindings to YAML as part of this > series ? :-) I thought the same and I did it for RFC https://patchwork.kernel.org/project/dri-devel/patch/20210704090230.26489-9-ja...@amarulasolutions.com/ But, I'm thinking of sending a separate patch series for updating yaml as the existing binding is old that it has some properties need to fix. Let me know if you are okay or not for it? > > > "samsung,exynos5410-mipi-dsi" /* for Exynos5410/5420/5440 > > SoCs */ > > "samsung,exynos5422-mipi-dsi" /* for Exynos5422/5800 SoCs */ > > "samsung,exynos5433-mipi-dsi" /* for Exynos5433 SoCs */ > > + "fsl,imx8mm-mipi-dsim" /* for i.MX8M Mini/Nano SoCs */ > > Should we have two different compatible strings for i.MX8MM and i.MX8MN > ? Yes, MN is fallback to MM. I will update in next series or add it as part of yaml conversion series. Thanks, Jagan.
Re: [PATCH 10/11] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support
Hi Jagan, Thank you for the patch. On Fri, Apr 08, 2022 at 09:51:07PM +0530, Jagan Teki wrote: > Samsung MIPI DSIM bridge can also be found in i.MX8MM/i.MX8MN SoC. > > Add dt-bingings for it. > > v1: > * new patch > > Signed-off-by: Jagan Teki > --- > Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > b/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > index be377786e8cd..5133d4d39190 100644 > --- a/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > +++ b/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > @@ -7,6 +7,7 @@ Required properties: May I try and ask you to convert the DT bindings to YAML as part of this series ? :-) > "samsung,exynos5410-mipi-dsi" /* for Exynos5410/5420/5440 SoCs > */ > "samsung,exynos5422-mipi-dsi" /* for Exynos5422/5800 SoCs */ > "samsung,exynos5433-mipi-dsi" /* for Exynos5433 SoCs */ > + "fsl,imx8mm-mipi-dsim" /* for i.MX8M Mini/Nano SoCs */ Should we have two different compatible strings for i.MX8MM and i.MX8MN ? >- reg: physical base address and length of the registers set for the device >- interrupts: should contain DSI interrupt >- clocks: list of clock specifiers, must contain an entry for each required -- Regards, Laurent Pinchart
[PATCH 10/11] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support
Samsung MIPI DSIM bridge can also be found in i.MX8MM/i.MX8MN SoC. Add dt-bingings for it. v1: * new patch Signed-off-by: Jagan Teki --- Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt b/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt index be377786e8cd..5133d4d39190 100644 --- a/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt +++ b/Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt @@ -7,6 +7,7 @@ Required properties: "samsung,exynos5410-mipi-dsi" /* for Exynos5410/5420/5440 SoCs */ "samsung,exynos5422-mipi-dsi" /* for Exynos5422/5800 SoCs */ "samsung,exynos5433-mipi-dsi" /* for Exynos5433 SoCs */ + "fsl,imx8mm-mipi-dsim" /* for i.MX8M Mini/Nano SoCs */ - reg: physical base address and length of the registers set for the device - interrupts: should contain DSI interrupt - clocks: list of clock specifiers, must contain an entry for each required -- 2.25.1
