Re: [PATCH 14/17] ARM: omap1: remove dead code

2022-10-24 Thread Kevin Hilman
Arnd Bergmann  writes:

> From: Arnd Bergmann 
>
> After the removal of the unused board files, I went through the
> omap1 code to look for code that no longer has any callers
> and remove that.
>
> In particular, support for the omap7xx/omap8xx family is now
> completely unused, so I'm only leaving omap15xx/omap16xx/omap59xx.

Acked-by: Kevin Hilman 

with a few tears shed since omap7xx/omap8xx was the first family I
contributed to upstream. :(

Kevin


Re: [PATCH 14/17] ARM: omap1: remove dead code

2022-10-23 Thread Tony Lindgren
* Arnd Bergmann  [221019 15:10]:
> From: Arnd Bergmann 
> 
> After the removal of the unused board files, I went through the
> omap1 code to look for code that no longer has any callers
> and remove that.
> 
> In particular, support for the omap7xx/omap8xx family is now
> completely unused, so I'm only leaving omap15xx/omap16xx/omap59xx.

Acked-by: Tony Lindgren 


Re: [PATCH 14/17] ARM: omap1: remove dead code

2022-10-22 Thread Greg Kroah-Hartman
On Wed, Oct 19, 2022 at 05:03:36PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann 
> 
> After the removal of the unused board files, I went through the
> omap1 code to look for code that no longer has any callers
> and remove that.
> 
> In particular, support for the omap7xx/omap8xx family is now
> completely unused, so I'm only leaving omap15xx/omap16xx/omap59xx.
> 
> Cc: Aaro Koskinen 
> Cc: Janusz Krzysztofik 
> Cc: Tony Lindgren 
> Cc: linux-o...@vger.kernel.org
> Signed-off-by: Arnd Bergmann 


Reviewed-by: Greg Kroah-Hartman 


Re: [PATCH 14/17] ARM: omap1: remove dead code

2022-10-21 Thread Arnd Bergmann
On Wed, Oct 19, 2022, at 19:34, Aaro Koskinen wrote:
> Hi,
>
> On Wed, Oct 19, 2022 at 05:03:36PM +0200, Arnd Bergmann wrote:
>>  drivers/usb/phy/phy-isp1301-omap.c | 91 +-
>
> This driver and config option ISP1301_OMAP can be deleted altogether as
> there are no users after H2/H3 boards are gone.

Good catch! I'll split the driver removal out as a separate patch
then and remove this bit here.

 Arnd


Re: [PATCH 14/17] ARM: omap1: remove dead code

2022-10-19 Thread Aaro Koskinen
Hi,

On Wed, Oct 19, 2022 at 05:03:36PM +0200, Arnd Bergmann wrote:
>  drivers/usb/phy/phy-isp1301-omap.c | 91 +-

This driver and config option ISP1301_OMAP can be deleted altogether as
there are no users after H2/H3 boards are gone.

A.


[PATCH 14/17] ARM: omap1: remove dead code

2022-10-19 Thread Arnd Bergmann
From: Arnd Bergmann 

After the removal of the unused board files, I went through the
omap1 code to look for code that no longer has any callers
and remove that.

In particular, support for the omap7xx/omap8xx family is now
completely unused, so I'm only leaving omap15xx/omap16xx/omap59xx.

Cc: Aaro Koskinen 
Cc: Janusz Krzysztofik 
Cc: Tony Lindgren 
Cc: linux-o...@vger.kernel.org
Signed-off-by: Arnd Bergmann 
---
 arch/arm/mach-omap1/clock_data.c   | 17 +-
 arch/arm/mach-omap1/common.h   |  8 ---
 arch/arm/mach-omap1/devices.c  | 58 ++-
 arch/arm/mach-omap1/dma.c  | 25 +---
 arch/arm/mach-omap1/i2c.c  | 14 +
 arch/arm/mach-omap1/io.c   | 24 
 arch/arm/mach-omap1/irq.c  | 20 +--
 arch/arm/mach-omap1/irqs.h |  9 ---
 arch/arm/mach-omap1/mcbsp.c| 83 ---
 arch/arm/mach-omap1/mtd-xip.h  |  4 --
 arch/arm/mach-omap1/mux.c  | 52 -
 arch/arm/mach-omap1/pm.c   | 76 -
 arch/arm/mach-omap1/pm.h   | 39 +
 arch/arm/mach-omap1/serial.c   | 15 -
 arch/arm/mach-omap1/sleep.S| 80 --
 arch/arm/mach-omap1/sram-init.c|  7 +--
 arch/arm/mach-omap1/usb.c  | 34 +++
 drivers/spi/spi-omap-uwire.c   | 16 +-
 drivers/usb/gadget/udc/omap_udc.c  | 24 +---
 drivers/usb/host/ohci-omap.c   |  6 +-
 drivers/usb/musb/musb_dma.h| 11 +---
 drivers/usb/phy/phy-isp1301-omap.c | 91 +-
 drivers/video/fbdev/omap/lcdc.c|  2 -
 include/linux/soc/ti/omap1-soc.h   | 35 
 24 files changed, 39 insertions(+), 711 deletions(-)

diff --git a/arch/arm/mach-omap1/clock_data.c b/arch/arm/mach-omap1/clock_data.c
index 96d846c37c43..c58d200e4816 100644
--- a/arch/arm/mach-omap1/clock_data.c
+++ b/arch/arm/mach-omap1/clock_data.c
@@ -720,8 +720,6 @@ int __init omap1_clk_init(void)
cpu_mask |= CK_16XX;
if (cpu_is_omap1510())
cpu_mask |= CK_1510;
-   if (cpu_is_omap7xx())
-   cpu_mask |= CK_7XX;
if (cpu_is_omap310())
cpu_mask |= CK_310;
 
@@ -730,9 +728,6 @@ int __init omap1_clk_init(void)
ck_dpll1_p = _dpll1;
ck_ref_p = _ref;
 
-   if (cpu_is_omap7xx())
-   ck_ref.rate = 1300;
-
pr_info("Clocks: ARM_SYSST: 0x%04x DPLL_CTL: 0x%04x ARM_CKCTL: 
0x%04x\n",
omap_readw(ARM_SYSST), omap_readw(DPLL_CTL),
omap_readw(ARM_CKCTL));
@@ -771,12 +766,6 @@ int __init omap1_clk_init(void)
}
}
 
-   if (machine_is_omap_perseus2() || machine_is_omap_fsample()) {
-   /* Select slicer output as OMAP input clock */
-   omap_writew(omap_readw(OMAP7XX_PCC_UPLD_CTRL) & ~0x1,
-   OMAP7XX_PCC_UPLD_CTRL);
-   }
-
/* Amstrad Delta wants BCLK high when inactive */
if (machine_is_ams_delta())
omap_writel(omap_readl(ULPD_CLOCK_CTRL) |
@@ -784,11 +773,7 @@ int __init omap1_clk_init(void)
ULPD_CLOCK_CTRL);
 
/* Turn off DSP and ARM_TIMXO. Make sure ARM_INTHCK is not divided */
-   /* (on 730, bit 13 must not be cleared) */
-   if (cpu_is_omap7xx())
-   omap_writew(omap_readw(ARM_CKCTL) & 0x2fff, ARM_CKCTL);
-   else
-   omap_writew(omap_readw(ARM_CKCTL) & 0x0fff, ARM_CKCTL);
+   omap_writew(omap_readw(ARM_CKCTL) & 0x0fff, ARM_CKCTL);
 
/* Put DSP/MPUI into reset until needed */
omap_writew(0, ARM_RSTCT1);
diff --git a/arch/arm/mach-omap1/common.h b/arch/arm/mach-omap1/common.h
index 5ceff05e15c0..3fd9ed9efb12 100644
--- a/arch/arm/mach-omap1/common.h
+++ b/arch/arm/mach-omap1/common.h
@@ -35,14 +35,6 @@
 #include "soc.h"
 #include "i2c.h"
 
-#if defined(CONFIG_ARCH_OMAP730) || defined(CONFIG_ARCH_OMAP850)
-void omap7xx_map_io(void);
-#else
-static inline void omap7xx_map_io(void)
-{
-}
-#endif
-
 #ifdef CONFIG_ARCH_OMAP15XX
 void omap1510_fpga_init_irq(void);
 void omap15xx_map_io(void);
diff --git a/arch/arm/mach-omap1/devices.c b/arch/arm/mach-omap1/devices.c
index 80e94770582a..42d1631cecc0 100644
--- a/arch/arm/mach-omap1/devices.c
+++ b/arch/arm/mach-omap1/devices.c
@@ -63,8 +63,6 @@ static void omap_init_rtc(void)
 static inline void omap_init_rtc(void) {}
 #endif
 
-static inline void omap_init_mbox(void) { }
-
 /*-*/
 
 #if IS_ENABLED(CONFIG_MMC_OMAP)
@@ -73,22 +71,16 @@ static inline void omap1_mmc_mux(struct 
omap_mmc_platform_data *mmc_controller,
int controller_nr)
 {
if (controller_nr == 0) {
-   if (cpu_is_omap7xx()) {
-   omap_cfg_reg(MMC_7XX_CMD);
-   omap_cfg_reg(MMC_7XX_CLK);
-   omap_cfg_reg(MMC_7XX_DAT0);
-