[PATCH 2/2] drm/exynos: cleanup exynos_drm_plane

[Gustavo Padovan]

Hi Tobias,

2015-04-24 Joonyoung Shim :

> Hi Tobias,
> 
> On 04/23/2015 09:12 PM, Tobias Jakobi wrote:
> > Remove the unused fields of struct exynos_drm_plane.
> > 
> > Signed-off-by: Tobias Jakobi 
> > ---
> >  drivers/gpu/drm/exynos/exynos_drm_drv.h | 10 --
> >  1 file changed, 10 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h 
> > b/drivers/gpu/drm/exynos/exynos_drm_drv.h
> > index e12ecb5..c80331b 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
> > @@ -73,11 +73,6 @@ enum exynos_drm_output_type {
> >   * @zpos: order of overlay layer(z position).
> >   * @index_color: if using color key feature then this value would be used
> >   * as index color.
> > - * @default_win: a window to be enabled.
> > - * @color_key: color key on or off.
> > - * @local_path: in case of lcd type, local path mode on or off.
> > - * @transparency: transparency on or off.
> > - * @activated: activated or not.
> >   * @enabled: enabled or not.
> >   * @resume: to resume or not.
> >   *
> > @@ -110,11 +105,6 @@ struct exynos_drm_plane {
> > unsigned int zpos;
> > unsigned int index_color;
> 
> How about remove also index_color?

That one can go too.

> 
> >  
> > -   bool default_win:1;
> > -   bool color_key:1;
> > -   bool local_path:1;
> > -   bool transparency:1;
> > -   bool activated:1;
> > bool enabled:1;
> > bool resume:1;
> >  };
> > 
> 
> Acked-by: Joonyoung Shim 

Reviewed-by: Gustavo Padovan 

Gustavo

[PATCH 2/2] drm/exynos: cleanup exynos_drm_plane

[Joonyoung Shim]

Hi Tobias,

On 04/23/2015 09:12 PM, Tobias Jakobi wrote:
> Remove the unused fields of struct exynos_drm_plane.
> 
> Signed-off-by: Tobias Jakobi 
> ---
>  drivers/gpu/drm/exynos/exynos_drm_drv.h | 10 --
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h 
> b/drivers/gpu/drm/exynos/exynos_drm_drv.h
> index e12ecb5..c80331b 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
> @@ -73,11 +73,6 @@ enum exynos_drm_output_type {
>   * @zpos: order of overlay layer(z position).
>   * @index_color: if using color key feature then this value would be used
>   *   as index color.
> - * @default_win: a window to be enabled.
> - * @color_key: color key on or off.
> - * @local_path: in case of lcd type, local path mode on or off.
> - * @transparency: transparency on or off.
> - * @activated: activated or not.
>   * @enabled: enabled or not.
>   * @resume: to resume or not.
>   *
> @@ -110,11 +105,6 @@ struct exynos_drm_plane {
>   unsigned int zpos;
>   unsigned int index_color;

How about remove also index_color?

>  
> - bool default_win:1;
> - bool color_key:1;
> - bool local_path:1;
> - bool transparency:1;
> - bool activated:1;
>   bool enabled:1;
>   bool resume:1;
>  };
> 

Acked-by: Joonyoung Shim 

Thanks.

[PATCH 2/2] drm/exynos: cleanup exynos_drm_plane

[Tobias Jakobi]

Remove the unused fields of struct exynos_drm_plane.

Signed-off-by: Tobias Jakobi 
---
 drivers/gpu/drm/exynos/exynos_drm_drv.h | 10 --
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h 
b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index e12ecb5..c80331b 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
@@ -73,11 +73,6 @@ enum exynos_drm_output_type {
  * @zpos: order of overlay layer(z position).
  * @index_color: if using color key feature then this value would be used
  * as index color.
- * @default_win: a window to be enabled.
- * @color_key: color key on or off.
- * @local_path: in case of lcd type, local path mode on or off.
- * @transparency: transparency on or off.
- * @activated: activated or not.
  * @enabled: enabled or not.
  * @resume: to resume or not.
  *
@@ -110,11 +105,6 @@ struct exynos_drm_plane {
unsigned int zpos;
unsigned int index_color;

-   bool default_win:1;
-   bool color_key:1;
-   bool local_path:1;
-   bool transparency:1;
-   bool activated:1;
bool enabled:1;
bool resume:1;
 };
-- 
2.0.5