Re: [PATCH 2/2] drm/panel: simple: Add Startek KD070WVFPA043-C069A panel support

2022-04-22 Thread Sam Ravnborg
On Tue, Apr 19, 2022 at 09:56:25PM -0300, Fabio Estevam wrote:
> From: Heiko Schocher 
> 
> Add Startek KD070WVFPA043-C069A 7" TFT LCD panel support.
> 
> Signed-off-by: Heiko Schocher 
> Signed-off-by: Fabio Estevam 

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 33 
>  1 file changed, 33 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c 
> b/drivers/gpu/drm/panel/panel-simple.c
> index a34f4198a534..ca8cd017821d 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3311,6 +3311,36 @@ static const struct panel_desc tsd_tst043015cmhx = {
>   .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
>  };
>  
> +static const struct display_timing startek_kd070wvfpa_mode = {
> + .pixelclock = { 2520, 2720, 3050 },
> + .hactive = { 800, 800, 800 },
> + .hfront_porch = { 19, 44, 115 },
> + .hback_porch = { 5, 16, 101 },
> + .hsync_len = { 1, 2, 100 },
> + .vactive = { 480, 480, 480 },
> + .vfront_porch = { 5, 43, 67 },
> + .vback_porch = { 5, 5, 67 },
> + .vsync_len = { 1, 2, 66 },
> +};
> +
> +static const struct panel_desc startek_kd070wvfpa = {
> + .timings = _kd070wvfpa_mode,
> + .num_timings = 1,
> + .bpc = 8,
> + .size = {
> + .width = 152,
> + .height = 91,
> + },
> + .delay = {
> + .prepare = 20,
> + .enable = 200,
> + .disable = 200,
> + },
> + .bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .connector_type = DRM_MODE_CONNECTOR_DPI,
> +};

Please fix so order of startek_kd070wvfpa is the same order in
platform_of_match.

startek_kd070wvfpa is after tsd_tst043015cmhx above, but before
tsd_tst043015cmhx below.

Sam

> +
>  static const struct drm_display_mode tfc_s9700rtwv43tr_01b_mode = {
>   .clock = 3,
>   .hdisplay = 800,
> @@ -3990,6 +4020,9 @@ static const struct of_device_id platform_of_match[] = {
>   }, {
>   .compatible = "starry,kr070pe2t",
>   .data = _kr070pe2t,
> + }, {
> + .compatible = "startek,kd070wvfpa",
> + .data = _kd070wvfpa,
>   }, {
>   .compatible = "team-source-display,tst043015cmhx",
>   .data = _tst043015cmhx,
> -- 
> 2.25.1


[PATCH 2/2] drm/panel: simple: Add Startek KD070WVFPA043-C069A panel support

2022-04-19 Thread Fabio Estevam
From: Heiko Schocher 

Add Startek KD070WVFPA043-C069A 7" TFT LCD panel support.

Signed-off-by: Heiko Schocher 
Signed-off-by: Fabio Estevam 
---
 drivers/gpu/drm/panel/panel-simple.c | 33 
 1 file changed, 33 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index a34f4198a534..ca8cd017821d 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -3311,6 +3311,36 @@ static const struct panel_desc tsd_tst043015cmhx = {
.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
 };
 
+static const struct display_timing startek_kd070wvfpa_mode = {
+   .pixelclock = { 2520, 2720, 3050 },
+   .hactive = { 800, 800, 800 },
+   .hfront_porch = { 19, 44, 115 },
+   .hback_porch = { 5, 16, 101 },
+   .hsync_len = { 1, 2, 100 },
+   .vactive = { 480, 480, 480 },
+   .vfront_porch = { 5, 43, 67 },
+   .vback_porch = { 5, 5, 67 },
+   .vsync_len = { 1, 2, 66 },
+};
+
+static const struct panel_desc startek_kd070wvfpa = {
+   .timings = _kd070wvfpa_mode,
+   .num_timings = 1,
+   .bpc = 8,
+   .size = {
+   .width = 152,
+   .height = 91,
+   },
+   .delay = {
+   .prepare = 20,
+   .enable = 200,
+   .disable = 200,
+   },
+   .bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
+   .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+   .connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
 static const struct drm_display_mode tfc_s9700rtwv43tr_01b_mode = {
.clock = 3,
.hdisplay = 800,
@@ -3990,6 +4020,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "starry,kr070pe2t",
.data = _kr070pe2t,
+   }, {
+   .compatible = "startek,kd070wvfpa",
+   .data = _kd070wvfpa,
}, {
.compatible = "team-source-display,tst043015cmhx",
.data = _tst043015cmhx,
-- 
2.25.1