Re: [PATCH 2/2] drm/panel: simple: add support for NLT NL192108AC18-02D

[Lucas Stach]

Hi Rob,

Am Mittwoch, den 19.04.2017, 16:15 -0500 schrieb Rob Herring:
> On Wed, Apr 12, 2017 at 07:15:26PM +0200, Lucas Stach wrote:
> > This adds support for the NLT Technologies NL192108AC18-02D
> > 15.6" LVDS FullHD TFT LCD panel, which can be supported
> > by the simple panel driver.
> > 
> > Timings are taken from the preliminary datasheet, as a final
> > one is not yet available.
> > 
> > Signed-off-by: Lucas Stach 
> > ---
> >  .../display/panel/nlt,nl192108ac18-02d.txt |  7 ++
> >  drivers/gpu/drm/panel/panel-simple.c   | 29 
> > ++
> >  2 files changed, 36 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt
> > 
> > diff --git 
> > a/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt 
> > b/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt
> > new file mode 100644
> > index ..edc34fbd2131
> > --- /dev/null
> > +++ 
> > b/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt
> > @@ -0,0 +1,7 @@
> > +NLT Technologies, Ltd. 15.6" FHD (1920x1080) LVDS TFT LCD panel
> > +
> > +Required properties:
> > +- compatible: should be "nlt,nl192108ac18-02d"
> 
> Please define the power supply. Is power-supply used or are there 
> multiple supplies?

How would you like to have that done? I thought that the sentence below
is clear enough that this panel uses the simple panel binding where the
power-supply property is non-optional. To me it feels a bit redundant to
say in this binding document that, yes this panel is compatible to the
binding it claims to be compatible with.

And yes, this panel has a single supply for the digital logic.

> > +
> > +This binding is compatible with the simple-panel binding, which is 
> > specified
> > +in simple-panel.txt in this directory.

Regards,
Lucas

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] drm/panel: simple: add support for NLT NL192108AC18-02D

[Rob Herring]

On Wed, Apr 12, 2017 at 07:15:26PM +0200, Lucas Stach wrote:
> This adds support for the NLT Technologies NL192108AC18-02D
> 15.6" LVDS FullHD TFT LCD panel, which can be supported
> by the simple panel driver.
> 
> Timings are taken from the preliminary datasheet, as a final
> one is not yet available.
> 
> Signed-off-by: Lucas Stach 
> ---
>  .../display/panel/nlt,nl192108ac18-02d.txt |  7 ++
>  drivers/gpu/drm/panel/panel-simple.c   | 29 
> ++
>  2 files changed, 36 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt 
> b/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt
> new file mode 100644
> index ..edc34fbd2131
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt
> @@ -0,0 +1,7 @@
> +NLT Technologies, Ltd. 15.6" FHD (1920x1080) LVDS TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "nlt,nl192108ac18-02d"

Please define the power supply. Is power-supply used or are there 
multiple supplies?

> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel