Re: [PATCH 2/2] drm/rockchip: dsi: Fix unbalanced clock on probe error

2021-09-27 Thread Chen-Yu Tsai
On Sat, Sep 25, 2021 at 7:24 AM Brian Norris  wrote:
>
> Our probe() function never enabled this clock, so we shouldn't disable
> it if we fail to probe the bridge.
>
> Noted by inspection.
>
> Fixes: 2d4f7bdafd70 ("drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge 
> driver")
> Signed-off-by: Brian Norris 

Reviewed-by: Chen-Yu Tsai 


[PATCH 2/2] drm/rockchip: dsi: Fix unbalanced clock on probe error

2021-09-24 Thread Brian Norris
Our probe() function never enabled this clock, so we shouldn't disable
it if we fail to probe the bridge.

Noted by inspection.

Fixes: 2d4f7bdafd70 ("drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge 
driver")
Signed-off-by: Brian Norris 
---

 drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c 
b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
index 4340a99edb97..0886a5dee58c 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
@@ -1391,14 +1391,10 @@ static int dw_mipi_dsi_rockchip_probe(struct 
platform_device *pdev)
if (ret != -EPROBE_DEFER)
DRM_DEV_ERROR(dev,
  "Failed to probe dw_mipi_dsi: %d\n", ret);
-   goto err_clkdisable;
+   return ret;
}
 
return 0;
-
-err_clkdisable:
-   clk_disable_unprepare(dsi->pllref_clk);
-   return ret;
 }
 
 static int dw_mipi_dsi_rockchip_remove(struct platform_device *pdev)
-- 
2.33.0.685.g46640cef36-goog