Re: [PATCH 2/2] drm/stm: ltdc: return appropriate error code during probe

[Benjamin Gaignard]

Le ven. 26 avr. 2019 à 14:30, Philippe CORNU  a écrit :
>
> Hi Fabien,
> and thank you for your patch,
>
> Acked-by: Philippe Cornu 
>
> Philippe :-)
>
> On 4/24/19 4:03 PM, Fabien Dessenne wrote:
> > During probe, return the "clk_get" error value instead of -ENODEV.
> >
> > Signed-off-by: Fabien Dessenne 

Applied on drm-misc-next.
Thanks,
Benjamin

> > ---
> >   drivers/gpu/drm/stm/ltdc.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index 521ba83..97912e2 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -1145,8 +1145,9 @@ int ltdc_load(struct drm_device *ddev)
> >
> >   ldev->pixel_clk = devm_clk_get(dev, "lcd");
> >   if (IS_ERR(ldev->pixel_clk)) {
> > - DRM_ERROR("Unable to get lcd clock\n");
> > - return -ENODEV;
> > + if (PTR_ERR(ldev->pixel_clk) != -EPROBE_DEFER)
> > + DRM_ERROR("Unable to get lcd clock\n");
> > + return PTR_ERR(ldev->pixel_clk);
> >   }
> >
> >   if (clk_prepare_enable(ldev->pixel_clk)) {
> >
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] drm/stm: ltdc: return appropriate error code during probe

[Philippe CORNU]

Hi Fabien,
and thank you for your patch,

Acked-by: Philippe Cornu 

Philippe :-)

On 4/24/19 4:03 PM, Fabien Dessenne wrote:
> During probe, return the "clk_get" error value instead of -ENODEV.
> 
> Signed-off-by: Fabien Dessenne 
> ---
>   drivers/gpu/drm/stm/ltdc.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 521ba83..97912e2 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1145,8 +1145,9 @@ int ltdc_load(struct drm_device *ddev)
>   
>   ldev->pixel_clk = devm_clk_get(dev, "lcd");
>   if (IS_ERR(ldev->pixel_clk)) {
> - DRM_ERROR("Unable to get lcd clock\n");
> - return -ENODEV;
> + if (PTR_ERR(ldev->pixel_clk) != -EPROBE_DEFER)
> + DRM_ERROR("Unable to get lcd clock\n");
> + return PTR_ERR(ldev->pixel_clk);
>   }
>   
>   if (clk_prepare_enable(ldev->pixel_clk)) {
> 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/2] drm/stm: ltdc: return appropriate error code during probe

[Fabien Dessenne]

During probe, return the "clk_get" error value instead of -ENODEV.

Signed-off-by: Fabien Dessenne 
---
 drivers/gpu/drm/stm/ltdc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 521ba83..97912e2 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -1145,8 +1145,9 @@ int ltdc_load(struct drm_device *ddev)
 
ldev->pixel_clk = devm_clk_get(dev, "lcd");
if (IS_ERR(ldev->pixel_clk)) {
-   DRM_ERROR("Unable to get lcd clock\n");
-   return -ENODEV;
+   if (PTR_ERR(ldev->pixel_clk) != -EPROBE_DEFER)
+   DRM_ERROR("Unable to get lcd clock\n");
+   return PTR_ERR(ldev->pixel_clk);
}
 
if (clk_prepare_enable(ldev->pixel_clk)) {
-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel