On 06/02/18 23:24, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 6 Feb 2018 22:10:11 +0100
>
> Add a jump target so that a bit of exception handling can be better reused
> at the end of this function.
>
> Signed-off-by: Markus Elfring
Well, it is couple of lines less. If I would just have couple weeks time
to implement proper drm panel support for tilcdc and get rid of this
driver all together...
Picked for the next tilcdc pullrequest.
Thanks,
Jyri
> ---
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 12 +---
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 0b6aa95aec89..cf9ca16fee81 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -289,10 +289,8 @@ static struct tilcdc_panel_info
> *of_get_panel_info(struct device_node *np)
> }
>
> info = kzalloc(sizeof(*info), GFP_KERNEL);
> - if (!info) {
> - of_node_put(info_np);
> - return NULL;
> - }
> + if (!info)
> + goto put_node;
>
> ret |= of_property_read_u32(info_np, "ac-bias", &info->ac_bias);
> ret |= of_property_read_u32(info_np, "ac-bias-intrpt",
> &info->ac_bias_intrpt);
> @@ -311,11 +309,11 @@ static struct tilcdc_panel_info
> *of_get_panel_info(struct device_node *np)
> if (ret) {
> pr_err("%s: error reading panel-info properties\n", __func__);
> kfree(info);
> - of_node_put(info_np);
> - return NULL;
> + info = NULL;
> }
> - of_node_put(info_np);
>
> +put_node:
> + of_node_put(info_np);
> return info;
> }
>
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
