Re: [PATCH 2/2] i2c: algos: bit: mention our experience about initial states
On Sat, Jun 16, 2018 at 10:37:57PM +0900, Wolfram Sang wrote: > So, if somebody wants to re-implement this in the future, we pinpoint to > a problem case. > > Signed-off-by: Wolfram Sang Applied to for-current, thanks! ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 2/2] i2c: algos: bit: mention our experience about initial states
On Sat, Jun 16, 2018 at 9:37 AM, Wolfram Sang wrote: > So, if somebody wants to re-implement this in the future, we pinpoint to > a problem case. > > Signed-off-by: Wolfram Sang Series is: Acked-by: Alex Deucher > --- > drivers/i2c/algos/i2c-algo-bit.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/i2c/algos/i2c-algo-bit.c > b/drivers/i2c/algos/i2c-algo-bit.c > index 0c0eb16d710f..6ec65adaba49 100644 > --- a/drivers/i2c/algos/i2c-algo-bit.c > +++ b/drivers/i2c/algos/i2c-algo-bit.c > @@ -647,6 +647,11 @@ static int __i2c_bit_add_bus(struct i2c_adapter *adap, > if (bit_adap->getscl == NULL) > adap->quirks = _bit_quirk_no_clk_stretch; > > + /* > +* We tried forcing SCL/SDA to an initial state here. But that caused > a > +* regression, sadly. Check Bugzilla #200045 for details. > +*/ > + > ret = add_adapter(adap); > if (ret < 0) > return ret; > -- > 2.11.0 > > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 2/2] i2c: algos: bit: mention our experience about initial states
So, if somebody wants to re-implement this in the future, we pinpoint to a problem case. Signed-off-by: Wolfram Sang --- drivers/i2c/algos/i2c-algo-bit.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c index 0c0eb16d710f..6ec65adaba49 100644 --- a/drivers/i2c/algos/i2c-algo-bit.c +++ b/drivers/i2c/algos/i2c-algo-bit.c @@ -647,6 +647,11 @@ static int __i2c_bit_add_bus(struct i2c_adapter *adap, if (bit_adap->getscl == NULL) adap->quirks = _bit_quirk_no_clk_stretch; + /* +* We tried forcing SCL/SDA to an initial state here. But that caused a +* regression, sadly. Check Bugzilla #200045 for details. +*/ + ret = add_adapter(adap); if (ret < 0) return ret; -- 2.11.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
