Re: [PATCH 2/3] PCI: introduce can_remove()

2024-02-02 Thread Greg Kroah-Hartman
On Fri, Feb 02, 2024 at 05:25:55PM -0500, Hamza Mahfooz wrote:
> Wire up the can_remove() callback, such that pci drivers can implement
> their own version of it.
> 
> Cc: sta...@vger.kernel.org
> Signed-off-by: Hamza Mahfooz 
> ---

Again, sorry, nope, not allowed.


[PATCH 2/3] PCI: introduce can_remove()

2024-02-02 Thread Hamza Mahfooz
Wire up the can_remove() callback, such that pci drivers can implement
their own version of it.

Cc: sta...@vger.kernel.org
Signed-off-by: Hamza Mahfooz 
---
 drivers/pci/pci-driver.c | 12 
 include/linux/pci.h  |  5 +
 2 files changed, 17 insertions(+)

diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 51ec9e7e784f..8aae484c5494 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -466,6 +466,17 @@ static int pci_device_probe(struct device *dev)
return error;
 }
 
+static bool pci_device_can_remove(struct device *dev)
+{
+   struct pci_dev *pci_dev = to_pci_dev(dev);
+   struct pci_driver *drv = pci_dev->driver;
+
+   if (drv->can_remove)
+   return drv->can_remove(pci_dev);
+
+   return true;
+}
+
 static void pci_device_remove(struct device *dev)
 {
struct pci_dev *pci_dev = to_pci_dev(dev);
@@ -1680,6 +1691,7 @@ struct bus_type pci_bus_type = {
.match  = pci_bus_match,
.uevent = pci_uevent,
.probe  = pci_device_probe,
+   .can_remove = pci_device_can_remove,
.remove = pci_device_remove,
.shutdown   = pci_device_shutdown,
.dev_groups = pci_dev_groups,
diff --git a/include/linux/pci.h b/include/linux/pci.h
index add9368e6314..95276f44b23b 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -902,6 +902,10 @@ struct module;
  * (negative number) otherwise.
  * The probe function always gets called from process
  * context, so it can sleep.
+ * @can_remove:The can_remove() function gets called during driver
+ * deregistration to determine if remove() can be called.
+ * The probe function always gets called from process
+ * context, so it can sleep.
  * @remove:The remove() function gets called whenever a device
  * being handled by this driver is removed (either during
  * deregistration of the driver or when it's manually
@@ -943,6 +947,7 @@ struct pci_driver {
const char  *name;
const struct pci_device_id *id_table;   /* Must be non-NULL for probe 
to be called */
int  (*probe)(struct pci_dev *dev, const struct pci_device_id *id); 
/* New device inserted */
+   bool (*can_remove)(struct pci_dev *dev);
void (*remove)(struct pci_dev *dev);/* Device removed (NULL if not 
a hot-plug capable driver) */
int  (*suspend)(struct pci_dev *dev, pm_message_t state);   /* 
Device suspended */
int  (*resume)(struct pci_dev *dev);/* Device woken up */
-- 
2.43.0