Re: [PATCH 2/3] video: au1100fb: Improve a size determination in au1100fb_drv_probe()

[Bartlomiej Zolnierkiewicz]

On Monday, November 27, 2017 06:59:57 PM SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Mon, 27 Nov 2017 18:18:34 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 

Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/3] video: au1100fb: Improve a size determination in au1100fb_drv_probe()

[SF Markus Elfring]

From: Markus Elfring 
Date: Mon, 27 Nov 2017 18:18:34 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 drivers/video/fbdev/au1100fb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
index cae17d02d804..1e5b872f0da6 100644
--- a/drivers/video/fbdev/au1100fb.c
+++ b/drivers/video/fbdev/au1100fb.c
@@ -416,8 +416,7 @@ static int au1100fb_drv_probe(struct platform_device *dev)
struct clk *c;
 
/* Allocate new device private */
-   fbdev = devm_kzalloc(>dev, sizeof(struct au1100fb_device),
-GFP_KERNEL);
+   fbdev = devm_kzalloc(>dev, sizeof(*fbdev), GFP_KERNEL);
if (!fbdev)
return -ENOMEM;
 
-- 
2.15.0

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel