Re: [PATCH 2/4] dt-bindings: sram: qcom: Clean-up 'ranges' and child node names

2020-03-26 Thread Brian Masney
On Wed, Mar 25, 2020 at 04:05:39PM -0600, Rob Herring wrote:
> The regex for child nodes doesn't match the example. This wasn't flagged
> with 'additionalProperties: false' missing. The child node schema was also
> incorrect with 'ranges' property as it applies to child nodes and should
> be moved up to the parent node.
> 
> Fixes: 957fd69d396b ("dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) 
> bindings")
> Cc: Brian Masney 
> Cc: Bjorn Andersson 
> Cc: linux-arm-...@vger.kernel.org
> Signed-off-by: Rob Herring 

Reviewed-by: Brian Masney 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH 2/4] dt-bindings: sram: qcom: Clean-up 'ranges' and child node names

2020-03-25 Thread Rob Herring
The regex for child nodes doesn't match the example. This wasn't flagged
with 'additionalProperties: false' missing. The child node schema was also
incorrect with 'ranges' property as it applies to child nodes and should
be moved up to the parent node.

Fixes: 957fd69d396b ("dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) 
bindings")
Cc: Brian Masney 
Cc: Bjorn Andersson 
Cc: linux-arm-...@vger.kernel.org
Signed-off-by: Rob Herring 
---
 .../devicetree/bindings/sram/qcom,ocmem.yaml | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml 
b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
index 222990f9923c..469cec133647 100644
--- a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
+++ b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
@@ -43,6 +43,9 @@ properties:
   '#size-cells':
 const: 1
 
+  ranges:
+maxItems: 1
+
 required:
   - compatible
   - reg
@@ -51,9 +54,10 @@ required:
   - clock-names
   - '#address-cells'
   - '#size-cells'
+  - ranges
 
 patternProperties:
-  "^.+-sram$":
+  "-sram@[0-9a-f]+$":
 type: object
 description: A region of reserved memory.
 
@@ -61,12 +65,8 @@ patternProperties:
   reg:
 maxItems: 1
 
-  ranges:
-maxItems: 1
-
 required:
   - reg
-  - ranges
 
 examples:
   - |
@@ -88,9 +88,9 @@ examples:
 
 #address-cells = <1>;
 #size-cells = <1>;
+ranges = <0 0xfec0 0x10>;
 
 gmu-sram@0 {
 reg = <0x0 0x10>;
-ranges = <0 0 0xfec0 0x10>;
 };
   };
-- 
2.20.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel