Re: [PATCH 2/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp

2020-05-14 Thread Matthias Kaehlcke
On Thu, May 14, 2020 at 04:24:15PM +0530, Sharat Masetty wrote:

> Subject: arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp

nit: s/opp/OPPs/

>
> Add opp-peak-kBps bindings to the GPU opp table, listing the peak
> GPU -> DDR bandwidth requirement for each opp level. This will be
> used to scale the DDR bandwidth along with the GPU frequency dynamically.
> 
> Signed-off-by: Sharat Masetty 
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi 
> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 0ce9921..89f7767 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1392,36 +1392,43 @@
>   opp-8 {
>   opp-hz = /bits/ 64 <8>;
>   opp-level = 
> ;
> + opp-peak-kBps = <8532000>;
>   };
> 
>   opp-65000 {
>   opp-hz = /bits/ 64 <65000>;
>   opp-level = 
> ;
> + opp-peak-kBps = <7216000>;
>   };
> 
>   opp-56500 {
>   opp-hz = /bits/ 64 <56500>;
>   opp-level = ;
> + opp-peak-kBps = <5412000>;
>   };
> 
>   opp-43000 {
>   opp-hz = /bits/ 64 <43000>;
>   opp-level = 
> ;
> + opp-peak-kBps = <5412000>;

I suppose it's intentional that the bandwidth is the same as for opp-56500,
just want to mention it for if it's a C error.


>   };
> 
>   opp-35500 {
>   opp-hz = /bits/ 64 <35500>;
>   opp-level = ;
> + opp-peak-kBps = <3072000>;
>   };
> 
>   opp-26700 {
>   opp-hz = /bits/ 64 <26700>;
>   opp-level = 
> ;
> + opp-peak-kBps = <3072000>;
>   };

ditto

>   opp-18000 {
>   opp-hz = /bits/ 64 <18000>;
>   opp-level = 
> ;
> + opp-peak-kBps = <1804000>;
>   };
>   };
>   };

assuming the repeated bandwidths are indeed intentional:

Reviewed-by: Matthias Kaehlcke 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH 2/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp

2020-05-14 Thread Sharat Masetty
Add opp-peak-kBps bindings to the GPU opp table, listing the peak
GPU -> DDR bandwidth requirement for each opp level. This will be
used to scale the DDR bandwidth along with the GPU frequency dynamically.

Signed-off-by: Sharat Masetty 
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi 
b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 0ce9921..89f7767 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1392,36 +1392,43 @@
opp-8 {
opp-hz = /bits/ 64 <8>;
opp-level = 
;
+   opp-peak-kBps = <8532000>;
};

opp-65000 {
opp-hz = /bits/ 64 <65000>;
opp-level = 
;
+   opp-peak-kBps = <7216000>;
};

opp-56500 {
opp-hz = /bits/ 64 <56500>;
opp-level = ;
+   opp-peak-kBps = <5412000>;
};

opp-43000 {
opp-hz = /bits/ 64 <43000>;
opp-level = 
;
+   opp-peak-kBps = <5412000>;
};

opp-35500 {
opp-hz = /bits/ 64 <35500>;
opp-level = ;
+   opp-peak-kBps = <3072000>;
};

opp-26700 {
opp-hz = /bits/ 64 <26700>;
opp-level = 
;
+   opp-peak-kBps = <3072000>;
};

opp-18000 {
opp-hz = /bits/ 64 <18000>;
opp-level = 
;
+   opp-peak-kBps = <1804000>;
};
};
};
--
2.7.4
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel