Re: [PATCH 20/21] drm/vboxvideo: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes


Den 26.03.2019 14.20, skrev Daniel Vetter:
> This should not result in any changes.
> 
> v2: Rebase over vbox changes - vbox gained it's own line to fill
> fix.id.
> 
> v3: Rebase
> 
> Reviewed-by: Greg Kroah-Hartman  (v2)
> Signed-off-by: Daniel Vetter 
> Cc: Greg Kroah-Hartman 
> Cc: Hans de Goede 
> Cc: Daniel Vetter 
> Cc: Alexander Kapshuk 
> Cc: Bartlomiej Zolnierkiewicz 
> ---

Reviewed-by: Noralf Trønnes 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 20/21] drm/vboxvideo: Use drm_fb_helper_fill_info

2019-03-26 Thread Daniel Vetter
This should not result in any changes.

v2: Rebase over vbox changes - vbox gained it's own line to fill
fix.id.

v3: Rebase

Reviewed-by: Greg Kroah-Hartman  (v2)
Signed-off-by: Daniel Vetter 
Cc: Greg Kroah-Hartman 
Cc: Hans de Goede 
Cc: Daniel Vetter 
Cc: Alexander Kapshuk 
Cc: Bartlomiej Zolnierkiewicz 
---
 drivers/gpu/drm/vboxvideo/vbox_fb.c | 8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/vboxvideo/vbox_fb.c 
b/drivers/gpu/drm/vboxvideo/vbox_fb.c
index 83a04afd1766..b724fe7c0c30 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_fb.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_fb.c
@@ -90,13 +90,9 @@ int vboxfb_create(struct drm_fb_helper *helper,
if (IS_ERR(info->screen_base))
return PTR_ERR(info->screen_base);
 
-   info->par = helper;
-
fb = >afb.base;
helper->fb = fb;
 
-   strcpy(info->fix.id, "vboxdrmfb");
-
info->fbops = _ops;
 
/*
@@ -106,9 +102,7 @@ int vboxfb_create(struct drm_fb_helper *helper,
info->apertures->ranges[0].base = pci_resource_start(pdev, 0);
info->apertures->ranges[0].size = pci_resource_len(pdev, 0);
 
-   drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth);
-   drm_fb_helper_fill_var(info, helper, sizes->fb_width,
-  sizes->fb_height);
+   drm_fb_helper_fill_info(info, helper, sizes);
 
gpu_addr = vbox_bo_gpu_offset(bo);
info->fix.smem_start = info->apertures->ranges[0].base + gpu_addr;
-- 
2.20.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel