Re: [PATCH 22/30] drm/exynos: mic: Use drm_bridge_init()

2019-12-02 Thread Inki Dae

19. 11. 26. 오후 10:16에 Mihail Atanassov 이(가) 쓴 글:
> No functional change: no logic depends on driver_private being NULL, so
> it's safe to set it earlier in exynos_mic_probe.
Acked-by: Inki Dae 

And tested this patch on TM2 and TM2E boards.
Tested-by: Inki Dae 

Thanks,
Inki Dae

> 
> Signed-off-by: Mihail Atanassov 
> ---
>  drivers/gpu/drm/exynos/exynos_drm_mic.c | 8 +---
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c 
> b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index f41d75923557..caad348a5646 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -309,10 +309,6 @@ static const struct drm_bridge_funcs mic_bridge_funcs = {
>  static int exynos_mic_bind(struct device *dev, struct device *master,
>  void *data)
>  {
> - struct exynos_mic *mic = dev_get_drvdata(dev);
> -
> - mic->bridge.driver_private = mic;
> -
>   return 0;
>  }
>  
> @@ -422,9 +418,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>  
>   platform_set_drvdata(pdev, mic);
>  
> - mic->bridge.funcs = _bridge_funcs;
> - mic->bridge.of_node = dev->of_node;
> -
> + drm_bridge_init(>bridge, dev, _bridge_funcs, NULL, mic);
>   drm_bridge_add(>bridge);
>  
>   pm_runtime_enable(dev);
> 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 22/30] drm/exynos: mic: Use drm_bridge_init()

2019-11-26 Thread Mihail Atanassov
No functional change: no logic depends on driver_private being NULL, so
it's safe to set it earlier in exynos_mic_probe.

Signed-off-by: Mihail Atanassov 
---
 drivers/gpu/drm/exynos/exynos_drm_mic.c | 8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c 
b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index f41d75923557..caad348a5646 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -309,10 +309,6 @@ static const struct drm_bridge_funcs mic_bridge_funcs = {
 static int exynos_mic_bind(struct device *dev, struct device *master,
   void *data)
 {
-   struct exynos_mic *mic = dev_get_drvdata(dev);
-
-   mic->bridge.driver_private = mic;
-
return 0;
 }
 
@@ -422,9 +418,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
 
platform_set_drvdata(pdev, mic);
 
-   mic->bridge.funcs = _bridge_funcs;
-   mic->bridge.of_node = dev->of_node;
-
+   drm_bridge_init(>bridge, dev, _bridge_funcs, NULL, mic);
drm_bridge_add(>bridge);
 
pm_runtime_enable(dev);
-- 
2.23.0

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel