Re: [PATCH 22/43] drm/arm/komeda: Use fbdev-dma

2024-03-13 Thread Liviu Dudau
On Tue, Mar 12, 2024 at 04:45:17PM +0100, Thomas Zimmermann wrote:
> Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports
> damage handling, which is required by komeda. Avoids the overhead of
> fbdev-generic's additional shadow buffering. No functional changes.
> 
> Signed-off-by: Thomas Zimmermann 
> Cc: Liviu Dudau 

Acked-by: Liviu Dudau 

Best regards,
Liviu


> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c 
> b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> index cc57ea4e13ae6..ffdeec3b3f2ea 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> @@ -9,7 +9,7 @@
>  #include 
>  #include 
>  #include 
> -#include 
> +#include 
>  #include 
>  #include 
>  #include "komeda_dev.h"
> @@ -80,7 +80,7 @@ static int komeda_platform_probe(struct platform_device 
> *pdev)
>   }
>  
>   dev_set_drvdata(dev, mdrv);
> - drm_fbdev_generic_setup(&mdrv->kms->base, 32);
> + drm_fbdev_dma_setup(&mdrv->kms->base, 32);
>  
>   return 0;
>  
> -- 
> 2.44.0
> 

-- 

| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---
¯\_(ツ)_/¯


[PATCH 22/43] drm/arm/komeda: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports
damage handling, which is required by komeda. Avoids the overhead of
fbdev-generic's additional shadow buffering. No functional changes.

Signed-off-by: Thomas Zimmermann 
Cc: Liviu Dudau 
---
 drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c 
b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
index cc57ea4e13ae6..ffdeec3b3f2ea 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
@@ -9,7 +9,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include "komeda_dev.h"
@@ -80,7 +80,7 @@ static int komeda_platform_probe(struct platform_device *pdev)
}
 
dev_set_drvdata(dev, mdrv);
-   drm_fbdev_generic_setup(&mdrv->kms->base, 32);
+   drm_fbdev_dma_setup(&mdrv->kms->base, 32);
 
return 0;
 
-- 
2.44.0