[PATCH 3/3] drm/mm: WARN for unclean mm takedown

[Daniel Vetter]

The usual drm driver has tons of different drm_mm memory managers so the drm
error message in dmesg is pretty useless. WARN instead so that we have the full
backtrace.

Signed-off-by: Daniel Vetter 
---
 drivers/gpu/drm/drm_mm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index f9d4873..d303e31 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -699,8 +699,8 @@ void drm_mm_takedown(struct drm_mm * mm)
 {
struct drm_mm_node *entry, *next;

-   if (!list_empty(>head_node.node_list)) {
-   DRM_ERROR("Memory manager not clean. Delaying takedown\n");
+   if (WARN(!list_empty(>head_node.node_list),
+"Memory manager not clean. Delaying takedown\n")) {
return;
}

-- 
1.8.3.1

[Intel-gfx] [PATCH 3/3] drm/mm: WARN for unclean mm takedown

[Ben Widawsky]

On Mon,  1 Jul 2013 22:01:04 +0200
Daniel Vetter  wrote:

> The usual drm driver has tons of different drm_mm memory managers so
> the drm error message in dmesg is pretty useless. WARN instead so
> that we have the full backtrace.
> 
> Signed-off-by: Daniel Vetter 

I've written this patch myself a number of times.
Reviewed-by: Ben Widawsky 

> ---
>  drivers/gpu/drm/drm_mm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
> index f9d4873..d303e31 100644
> --- a/drivers/gpu/drm/drm_mm.c
> +++ b/drivers/gpu/drm/drm_mm.c
> @@ -699,8 +699,8 @@ void drm_mm_takedown(struct drm_mm * mm)
>  {
>   struct drm_mm_node *entry, *next;
>  
> - if (!list_empty(>head_node.node_list)) {
> - DRM_ERROR("Memory manager not clean. Delaying
> takedown\n");
> + if (WARN(!list_empty(>head_node.node_list),
> +  "Memory manager not clean. Delaying takedown\n")) {
>   return;
>   }
>  

[PATCH 3/3] drm/mm: WARN for unclean mm takedown

[Daniel Vetter]

The usual drm driver has tons of different drm_mm memory managers so the drm
error message in dmesg is pretty useless. WARN instead so that we have the full
backtrace.

Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
 drivers/gpu/drm/drm_mm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index f9d4873..d303e31 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -699,8 +699,8 @@ void drm_mm_takedown(struct drm_mm * mm)
 {
struct drm_mm_node *entry, *next;
 
-   if (!list_empty(mm-head_node.node_list)) {
-   DRM_ERROR(Memory manager not clean. Delaying takedown\n);
+   if (WARN(!list_empty(mm-head_node.node_list),
+Memory manager not clean. Delaying takedown\n)) {
return;
}
 
-- 
1.8.3.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH 3/3] drm/mm: WARN for unclean mm takedown

[Ben Widawsky]

On Mon,  1 Jul 2013 22:01:04 +0200
Daniel Vetter daniel.vet...@ffwll.ch wrote:

 The usual drm driver has tons of different drm_mm memory managers so
 the drm error message in dmesg is pretty useless. WARN instead so
 that we have the full backtrace.
 
 Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch

I've written this patch myself a number of times.
Reviewed-by: Ben Widawsky b...@bwidawsk.net

 ---
  drivers/gpu/drm/drm_mm.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
 index f9d4873..d303e31 100644
 --- a/drivers/gpu/drm/drm_mm.c
 +++ b/drivers/gpu/drm/drm_mm.c
 @@ -699,8 +699,8 @@ void drm_mm_takedown(struct drm_mm * mm)
  {
   struct drm_mm_node *entry, *next;
  
 - if (!list_empty(mm-head_node.node_list)) {
 - DRM_ERROR(Memory manager not clean. Delaying
 takedown\n);
 + if (WARN(!list_empty(mm-head_node.node_list),
 +  Memory manager not clean. Delaying takedown\n)) {
   return;
   }
  

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel