Re: [PATCH 3/3] drm/qxl: Remove qxl_debugfs_remove_files()

[Daniel Vetter]

On Wed, Mar 08, 2017 at 12:33:01PM +0100, Gerd Hoffmann wrote:
> On Mi, 2017-03-08 at 10:52 +0100, Daniel Vetter wrote:
> > On Wed, Mar 08, 2017 at 08:45:13AM +0100, Gerd Hoffmann wrote:
> > > On Di, 2017-03-07 at 21:49 +0100, Noralf Trønnes wrote:
> > > > drm_debugfs_cleanup() now removes all minor->debugfs_list entries
> > > > automatically, so it's not necessary to call
> > > > drm_debugfs_remove_files().
> > > > 
> > > > Cc: airl...@linux.ie
> > > > Cc: kra...@redhat.com
> > > > Signed-off-by: Noralf Trønnes 
> > > 
> > > Reviewed-by: Gerd Hoffmann 
> > 
> > I assume you'll push to drm-misc yourself since its qxl?
> 
> Can surely do that.
> 
> Question though:  This seems to be a cross-driver cleanup series.  At
> least only 3/3 landed in my inbox, did't look @ dri-devel for the other
> patches.  What is the usual policy on those?
> 
> From the past I had the impression that in such a case the whole series
> gets applied by one of the drm-misc maintainers instead of each
> individual driver maintainer cherry-picking the patches from the
> series ...

Well mostly because many driver maintainers aren't dutiful with picking up
patches, or lose them again, or just take forever. But for this series
here there's no such excuse, and there's also no technical reason to order
patches a certain way (at least your qxl one is free standing and depends
upon nothing else and blocks nothing else).

One of my goals with drm-misc is that I can reduce my efforts spending on
catchging other maintainer's fallout, so I'd very much encourage everyone
to just push stuff. Especially if you're the maintainer, and you slap an
r-b onto a patch with no indication whether you merge it yourself or
except someone else to merge it it's confusing and just improves the odds
of the patch hitting one of our holes ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] drm/qxl: Remove qxl_debugfs_remove_files()

[Gerd Hoffmann]

On Mi, 2017-03-08 at 10:52 +0100, Daniel Vetter wrote:
> On Wed, Mar 08, 2017 at 08:45:13AM +0100, Gerd Hoffmann wrote:
> > On Di, 2017-03-07 at 21:49 +0100, Noralf Trønnes wrote:
> > > drm_debugfs_cleanup() now removes all minor->debugfs_list entries
> > > automatically, so it's not necessary to call
> > > drm_debugfs_remove_files().
> > > 
> > > Cc: airl...@linux.ie
> > > Cc: kra...@redhat.com
> > > Signed-off-by: Noralf Trønnes 
> > 
> > Reviewed-by: Gerd Hoffmann 
> 
> I assume you'll push to drm-misc yourself since its qxl?

Can surely do that.

Question though:  This seems to be a cross-driver cleanup series.  At
least only 3/3 landed in my inbox, did't look @ dri-devel for the other
patches.  What is the usual policy on those?

From the past I had the impression that in such a case the whole series
gets applied by one of the drm-misc maintainers instead of each
individual driver maintainer cherry-picking the patches from the
series ...

cheers,
  Gerd

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] drm/qxl: Remove qxl_debugfs_remove_files()

[Daniel Vetter]

On Wed, Mar 08, 2017 at 08:45:13AM +0100, Gerd Hoffmann wrote:
> On Di, 2017-03-07 at 21:49 +0100, Noralf Trønnes wrote:
> > drm_debugfs_cleanup() now removes all minor->debugfs_list entries
> > automatically, so it's not necessary to call
> > drm_debugfs_remove_files().
> > 
> > Cc: airl...@linux.ie
> > Cc: kra...@redhat.com
> > Signed-off-by: Noralf Trønnes 
> 
> Reviewed-by: Gerd Hoffmann 

I assume you'll push to drm-misc yourself since its qxl?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] drm/qxl: Remove qxl_debugfs_remove_files()

[Gerd Hoffmann]

On Di, 2017-03-07 at 21:49 +0100, Noralf Trønnes wrote:
> drm_debugfs_cleanup() now removes all minor->debugfs_list entries
> automatically, so it's not necessary to call
> drm_debugfs_remove_files().
> 
> Cc: airl...@linux.ie
> Cc: kra...@redhat.com
> Signed-off-by: Noralf Trønnes 

Reviewed-by: Gerd Hoffmann 

cheers,
  Gerd
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 3/3] drm/qxl: Remove qxl_debugfs_remove_files()

[Noralf Trønnes]

drm_debugfs_cleanup() now removes all minor->debugfs_list entries
automatically, so it's not necessary to call drm_debugfs_remove_files().

Cc: airl...@linux.ie
Cc: kra...@redhat.com
Signed-off-by: Noralf Trønnes 
---
 drivers/gpu/drm/qxl/qxl_debugfs.c | 13 -
 drivers/gpu/drm/qxl/qxl_drv.h |  1 -
 drivers/gpu/drm/qxl/qxl_kms.c |  1 -
 3 files changed, 15 deletions(-)

diff --git a/drivers/gpu/drm/qxl/qxl_debugfs.c 
b/drivers/gpu/drm/qxl/qxl_debugfs.c
index 8e6c780..ffe821b 100644
--- a/drivers/gpu/drm/qxl/qxl_debugfs.c
+++ b/drivers/gpu/drm/qxl/qxl_debugfs.c
@@ -129,16 +129,3 @@ int qxl_debugfs_add_files(struct qxl_device *qdev,
 #endif
return 0;
 }
-
-void qxl_debugfs_remove_files(struct qxl_device *qdev)
-{
-#if defined(CONFIG_DEBUG_FS)
-   unsigned i;
-
-   for (i = 0; i < qdev->debugfs_count; i++) {
-   drm_debugfs_remove_files(qdev->debugfs[i].files,
-qdev->debugfs[i].num_files,
-qdev->ddev.primary);
-   }
-#endif
-}
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index c048170..ed50a5b 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.h
+++ b/drivers/gpu/drm/qxl/qxl_drv.h
@@ -232,7 +232,6 @@ int qxl_debugfs_add_files(struct qxl_device *rdev,
 struct drm_info_list *files,
 unsigned nfiles);
 int qxl_debugfs_fence_init(struct qxl_device *rdev);
-void qxl_debugfs_remove_files(struct qxl_device *qdev);
 
 struct qxl_device;
 
diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c
index 2b1e1f3..1c46532 100644
--- a/drivers/gpu/drm/qxl/qxl_kms.c
+++ b/drivers/gpu/drm/qxl/qxl_kms.c
@@ -284,5 +284,4 @@ void qxl_device_fini(struct qxl_device *qdev)
qdev->rom = NULL;
qdev->mode_info.modes = NULL;
qdev->mode_info.num_modes = 0;
-   qxl_debugfs_remove_files(qdev);
 }
-- 
2.10.2

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel