Re: [PATCH 3/3] drm/vc4: vec: Add the margin properties to the connector

[Maxime Ripard]

On Fri, 16 Feb 2024 18:48:57 +, Dave Stevenson wrote:
> All the handling for the properties was present, but they
> were never attached to the connector to allow userspace
> to change them.
> 
> Add them to the connector.
> 
> [ ... ]

Reviewed-by: Maxime Ripard 

Thanks!
Maxime

[PATCH 3/3] drm/vc4: vec: Add the margin properties to the connector

[Dave Stevenson]

All the handling for the properties was present, but they
were never attached to the connector to allow userspace
to change them.

Add them to the connector.

Signed-off-by: Dave Stevenson 
---
 drivers/gpu/drm/vc4/vc4_vec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c
index f9e134dd1e3b..0aed18920d18 100644
--- a/drivers/gpu/drm/vc4/vc4_vec.c
+++ b/drivers/gpu/drm/vc4/vc4_vec.c
@@ -528,6 +528,8 @@ static int vc4_vec_connector_init(struct drm_device *dev, 
struct vc4_vec *vec)
 
drm_object_attach_property(&connector->base, prop, 
VC4_VEC_TV_MODE_NTSC);
 
+   drm_connector_attach_tv_margin_properties(connector);
+
drm_connector_attach_encoder(connector, &vec->encoder.base);
 
return 0;
-- 
2.25.1