[PATCH 4/4] reservation: revert "wait only with non-zero timeout specified (v3)" v2

[Gustavo Padovan]

2016-11-07 Alex Deucher :

> From: Christian König 
> 
> This reverts commit fb8b7d2b9d80e1e71f379e57355936bd2b024be9.
> 
> Otherwise signaling might never be activated on the fences. This can
> result in infinite waiting with hardware which has unreliable interrupts.
> 
> v2: still return one when the timeout is zero and we don't have any fences.
> 
> Reviewed-by: Alex Deucher 
> Signed-off-by: Christian König 
> Reviewed-by: Chunming Zhou  (v1)
> Signed-off-by: Alex Deucher 
> ---
>  drivers/dma-buf/reservation.c | 5 +
>  1 file changed, 1 insertion(+), 4 deletions(-)

You left all my r-b out. For the whole series:

Reviewed-by: Gustavo Padovan  

Gustavo

[PATCH 4/4] reservation: revert "wait only with non-zero timeout specified (v3)" v2

[Alex Deucher]

From: Christian König 

This reverts commit fb8b7d2b9d80e1e71f379e57355936bd2b024be9.

Otherwise signaling might never be activated on the fences. This can
result in infinite waiting with hardware which has unreliable interrupts.

v2: still return one when the timeout is zero and we don't have any fences.

Reviewed-by: Alex Deucher 
Signed-off-by: Christian König 
Reviewed-by: Chunming Zhou  (v1)
Signed-off-by: Alex Deucher 
---
 drivers/dma-buf/reservation.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c
index 7ed56f3..393817e 100644
--- a/drivers/dma-buf/reservation.c
+++ b/drivers/dma-buf/reservation.c
@@ -370,10 +370,7 @@ long reservation_object_wait_timeout_rcu(struct 
reservation_object *obj,
 {
struct dma_fence *fence;
unsigned seq, shared_count, i = 0;
-   long ret = timeout;
-
-   if (!timeout)
-   return reservation_object_test_signaled_rcu(obj, wait_all);
+   long ret = timeout ? timeout : 1;

 retry:
fence = NULL;
-- 
2.5.5

[PATCH 4/4] reservation: revert "wait only with non-zero timeout specified (v3)" v2

[Christian König]

From: Christian König 

This reverts commit fb8b7d2b9d80e1e71f379e57355936bd2b024be9.

Otherwise signaling might never be activated on the fences. This can
result in infinite waiting with hardware which has unreliable interrupts.

v2: still return one when the timeout is zero and we don't have any fences.

Signed-off-by: Christian König 
Reviewed-by: Chunming Zhou  (v1)
Reviewed-by: Alex Deucher 
---
 drivers/dma-buf/reservation.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c
index 9566a62..debb91d 100644
--- a/drivers/dma-buf/reservation.c
+++ b/drivers/dma-buf/reservation.c
@@ -379,10 +379,7 @@ long reservation_object_wait_timeout_rcu(struct 
reservation_object *obj,
 {
struct fence *fence;
unsigned seq, shared_count, i = 0;
-   long ret = timeout;
-
-   if (!timeout)
-   return reservation_object_test_signaled_rcu(obj, wait_all);
+   long ret = timeout ? timeout : 1;

 retry:
fence = NULL;
-- 
2.5.0