Re: [PATCH 5/5 v4] accel/qaic: Fix a leak in map_user_pages()

[Jeffrey Hugo]

On 7/14/2023 5:47 AM, Pranjal Ramajor Asha Kanojiya wrote:



On 7/11/2023 1:51 PM, Dan Carpenter wrote:

If get_user_pages_fast() allocates some pages but not as many as we
wanted, then the current code leaks those pages.  Call put_page() on
the pages before returning.

Fixes: 129776ac2e38 ("accel/qaic: Add control path")
Signed-off-by: Dan Carpenter 


Reviewed-by: Pranjal Ramajor Asha Kanojiya 


Pushed to drm-misc-fixes

-Jeff

Re: [PATCH 5/5 v4] accel/qaic: Fix a leak in map_user_pages()

[Pranjal Ramajor Asha Kanojiya]

On 7/11/2023 1:51 PM, Dan Carpenter wrote:

If get_user_pages_fast() allocates some pages but not as many as we
wanted, then the current code leaks those pages.  Call put_page() on
the pages before returning.

Fixes: 129776ac2e38 ("accel/qaic: Add control path")
Signed-off-by: Dan Carpenter 


Reviewed-by: Pranjal Ramajor Asha Kanojiya 

[PATCH 5/5 v4] accel/qaic: Fix a leak in map_user_pages()

[Dan Carpenter]

If get_user_pages_fast() allocates some pages but not as many as we
wanted, then the current code leaks those pages.  Call put_page() on
the pages before returning.

Fixes: 129776ac2e38 ("accel/qaic: Add control path")
Signed-off-by: Dan Carpenter 
---
no change

 drivers/accel/qaic/qaic_control.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/accel/qaic/qaic_control.c 
b/drivers/accel/qaic/qaic_control.c
index d5ce36cb351f..9a6f80f31c65 100644
--- a/drivers/accel/qaic/qaic_control.c
+++ b/drivers/accel/qaic/qaic_control.c
@@ -425,9 +425,12 @@ static int find_and_map_user_pages(struct qaic_device 
*qdev,
}
 
ret = get_user_pages_fast(xfer_start_addr, nr_pages, 0, page_list);
-   if (ret < 0 || ret != nr_pages) {
-   ret = -EFAULT;
+   if (ret < 0)
goto free_page_list;
+   if (ret != nr_pages) {
+   nr_pages = ret;
+   ret = -EFAULT;
+   goto put_pages;
}
 
sgt = kmalloc(sizeof(*sgt), GFP_KERNEL);
-- 
2.39.2