[Intel-gfx] [PATCH 5/7] drm/i915: Use container_of() in the fbdev code

[Daniel Vetter]

On Mon, Jun 03, 2013 at 11:08:30AM +0100, Chris Wilson wrote:
> On Fri, May 31, 2013 at 08:07:05PM +0300, ville.syrjala at linux.intel.com 
> wrote:
> > From: Ville Syrj?l? 
> > 
> > Use container_of() instead of a cast to get struct intel_fbdev
> > from struct drm_fb_helper.
> > 
> > Also populate the fb_info->par correctly with the drm_fb_helper pointer
> > instead of the intel_fbdev pointer.
> > 
> > There's no actual functional change since the drm_fb_helper happens to
> > be the first member inside intel_fbdev.
> Reviewed-by: Chris Wilson 
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

[PATCH 5/7] drm/i915: Use container_of() in the fbdev code

[Chris Wilson]

On Fri, May 31, 2013 at 08:07:05PM +0300, ville.syrjala at linux.intel.com 
wrote:
> From: Ville Syrj?l? 
> 
> Use container_of() instead of a cast to get struct intel_fbdev
> from struct drm_fb_helper.
> 
> Also populate the fb_info->par correctly with the drm_fb_helper pointer
> instead of the intel_fbdev pointer.
> 
> There's no actual functional change since the drm_fb_helper happens to
> be the first member inside intel_fbdev.
Reviewed-by: Chris Wilson 
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH 5/7] drm/i915: Use container_of() in the fbdev code

[Chris Wilson]

On Fri, May 31, 2013 at 08:07:05PM +0300, ville.syrj...@linux.intel.com wrote:
 From: Ville Syrjälä ville.syrj...@linux.intel.com
 
 Use container_of() instead of a cast to get struct intel_fbdev
 from struct drm_fb_helper.
 
 Also populate the fb_info-par correctly with the drm_fb_helper pointer
 instead of the intel_fbdev pointer.
 
 There's no actual functional change since the drm_fb_helper happens to
 be the first member inside intel_fbdev.
Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Use container_of() in the fbdev code

[Daniel Vetter]

On Mon, Jun 03, 2013 at 11:08:30AM +0100, Chris Wilson wrote:
 On Fri, May 31, 2013 at 08:07:05PM +0300, ville.syrj...@linux.intel.com wrote:
  From: Ville Syrjälä ville.syrj...@linux.intel.com
  
  Use container_of() instead of a cast to get struct intel_fbdev
  from struct drm_fb_helper.
  
  Also populate the fb_info-par correctly with the drm_fb_helper pointer
  instead of the intel_fbdev pointer.
  
  There's no actual functional change since the drm_fb_helper happens to
  be the first member inside intel_fbdev.
 Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 5/7] drm/i915: Use container_of() in the fbdev code

[ville.syrj...@linux.intel.com]

From: Ville Syrj?l? 

Use container_of() instead of a cast to get struct intel_fbdev
from struct drm_fb_helper.

Also populate the fb_info->par correctly with the drm_fb_helper pointer
instead of the intel_fbdev pointer.

There's no actual functional change since the drm_fb_helper happens to
be the first member inside intel_fbdev.

Signed-off-by: Ville Syrj?l? 
---
 drivers/gpu/drm/i915/intel_fb.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c
index e8389df..60d0cf6 100644
--- a/drivers/gpu/drm/i915/intel_fb.c
+++ b/drivers/gpu/drm/i915/intel_fb.c
@@ -60,8 +60,9 @@ static struct fb_ops intelfb_ops = {
 static int intelfb_create(struct drm_fb_helper *helper,
  struct drm_fb_helper_surface_size *sizes)
 {
-   struct intel_fbdev *ifbdev = (struct intel_fbdev *)helper;
-   struct drm_device *dev = ifbdev->helper.dev;
+   struct intel_fbdev *ifbdev =
+   container_of(helper, struct intel_fbdev, helper);
+   struct drm_device *dev = helper->dev;
struct drm_i915_private *dev_priv = dev->dev_private;
struct fb_info *info;
struct drm_framebuffer *fb;
@@ -108,7 +109,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
goto out_unpin;
}

-   info->par = ifbdev;
+   info->par = helper;

ret = intel_framebuffer_init(dev, >ifb, _cmd, obj);
if (ret)
-- 
1.8.1.5

[PATCH 5/7] drm/i915: Use container_of() in the fbdev code

[ville . syrjala]

From: Ville Syrjälä ville.syrj...@linux.intel.com

Use container_of() instead of a cast to get struct intel_fbdev
from struct drm_fb_helper.

Also populate the fb_info-par correctly with the drm_fb_helper pointer
instead of the intel_fbdev pointer.

There's no actual functional change since the drm_fb_helper happens to
be the first member inside intel_fbdev.

Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
 drivers/gpu/drm/i915/intel_fb.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c
index e8389df..60d0cf6 100644
--- a/drivers/gpu/drm/i915/intel_fb.c
+++ b/drivers/gpu/drm/i915/intel_fb.c
@@ -60,8 +60,9 @@ static struct fb_ops intelfb_ops = {
 static int intelfb_create(struct drm_fb_helper *helper,
  struct drm_fb_helper_surface_size *sizes)
 {
-   struct intel_fbdev *ifbdev = (struct intel_fbdev *)helper;
-   struct drm_device *dev = ifbdev-helper.dev;
+   struct intel_fbdev *ifbdev =
+   container_of(helper, struct intel_fbdev, helper);
+   struct drm_device *dev = helper-dev;
struct drm_i915_private *dev_priv = dev-dev_private;
struct fb_info *info;
struct drm_framebuffer *fb;
@@ -108,7 +109,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
goto out_unpin;
}
 
-   info-par = ifbdev;
+   info-par = helper;
 
ret = intel_framebuffer_init(dev, ifbdev-ifb, mode_cmd, obj);
if (ret)
-- 
1.8.1.5

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 5/7] drm/i915: Use container_of() in the fbdev code

[ville.syrj...@linux.intel.com]

From: Ville Syrj?l? 

Use container_of() instead of a cast to get struct intel_fbdev
from struct drm_fb_helper.

Also populate the fb_info->par correctly with the drm_fb_helper pointer
instead of the intel_fbdev pointer.

There's no actual functional change since the drm_fb_helper happens to
be the first member inside intel_fbdev.

Signed-off-by: Ville Syrj?l? 
---
 drivers/gpu/drm/i915/intel_fb.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c
index a9e9fc0..1728cd9 100644
--- a/drivers/gpu/drm/i915/intel_fb.c
+++ b/drivers/gpu/drm/i915/intel_fb.c
@@ -60,8 +60,9 @@ static struct fb_ops intelfb_ops = {
 static int intelfb_create(struct drm_fb_helper *helper,
  struct drm_fb_helper_surface_size *sizes)
 {
-   struct intel_fbdev *ifbdev = (struct intel_fbdev *)helper;
-   struct drm_device *dev = ifbdev->helper.dev;
+   struct intel_fbdev *ifbdev =
+   container_of(helper, struct intel_fbdev, helper);
+   struct drm_device *dev = helper->dev;
struct drm_i915_private *dev_priv = dev->dev_private;
struct fb_info *info;
struct drm_framebuffer *fb;
@@ -108,7 +109,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
goto out_unpin;
}

-   info->par = ifbdev;
+   info->par = helper;

ret = intel_framebuffer_init(dev, >ifb, _cmd, obj);
if (ret)
-- 
1.8.1.5

[PATCH 5/7] drm/i915: Use container_of() in the fbdev code

[ville . syrjala]

From: Ville Syrjälä ville.syrj...@linux.intel.com

Use container_of() instead of a cast to get struct intel_fbdev
from struct drm_fb_helper.

Also populate the fb_info-par correctly with the drm_fb_helper pointer
instead of the intel_fbdev pointer.

There's no actual functional change since the drm_fb_helper happens to
be the first member inside intel_fbdev.

Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
 drivers/gpu/drm/i915/intel_fb.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c
index a9e9fc0..1728cd9 100644
--- a/drivers/gpu/drm/i915/intel_fb.c
+++ b/drivers/gpu/drm/i915/intel_fb.c
@@ -60,8 +60,9 @@ static struct fb_ops intelfb_ops = {
 static int intelfb_create(struct drm_fb_helper *helper,
  struct drm_fb_helper_surface_size *sizes)
 {
-   struct intel_fbdev *ifbdev = (struct intel_fbdev *)helper;
-   struct drm_device *dev = ifbdev-helper.dev;
+   struct intel_fbdev *ifbdev =
+   container_of(helper, struct intel_fbdev, helper);
+   struct drm_device *dev = helper-dev;
struct drm_i915_private *dev_priv = dev-dev_private;
struct fb_info *info;
struct drm_framebuffer *fb;
@@ -108,7 +109,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
goto out_unpin;
}
 
-   info-par = ifbdev;
+   info-par = helper;
 
ret = intel_framebuffer_init(dev, ifbdev-ifb, mode_cmd, obj);
if (ret)
-- 
1.8.1.5

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel