Re: [PATCH 5/9] drm/panel: simple: add support for EDT ET0350 3.5" QVGA panel

[Rob Herring]

On Wed, Oct 11, 2017 at 01:23:37PM +0200, Lothar Waßmann wrote:
> Signed-off-by: Lothar Waßmann 
> ---
>  .../bindings/display/panel/edt,et0350g0dh6.txt|  7 +++

Please split bindings to separate patch.

>  drivers/gpu/drm/panel/panel-simple.c  | 19 
> +++
>  2 files changed, 26 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt 
> b/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt
> new file mode 100644
> index 000..5546221
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt
> @@ -0,0 +1,7 @@
> +Emerging Display Technology Corp. 3.5" QVGA (320x240) TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "edt,et0350g0dh6"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.

No reset lines, power supplies, etc.? Yes, simple-panel.txt defines 
properties, but you still need to specify which ones you use. Otherwise, 
I don't know if this panel has a single supply or you just forgot to 
define the supplies.

Rob
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 5/9] drm/panel: simple: add support for EDT ET0350 3.5" QVGA panel

[Lothar Waßmann]

Signed-off-by: Lothar Waßmann 
---
 .../bindings/display/panel/edt,et0350g0dh6.txt|  7 +++
 drivers/gpu/drm/panel/panel-simple.c  | 19 +++
 2 files changed, 26 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt

diff --git 
a/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt 
b/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt
new file mode 100644
index 000..5546221
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt
@@ -0,0 +1,7 @@
+Emerging Display Technology Corp. 3.5" QVGA (320x240) TFT LCD panel
+
+Required properties:
+- compatible: should be "edt,et0350g0dh6"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index 7bbb752..f57b463 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -763,6 +763,22 @@ static const struct panel_desc chunghwa_claa101wb01 = {
},
 };
 
+static const struct drm_display_mode edt_et0350g0dh6_mode =
+   SP_DISPLAY_MODE(6500, 320, 20, 0, 68, 240, 4, 0, 18, 60,
+   DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC);
+
+static const struct panel_desc edt_et0350g0dh6 = {
+   .modes = _et0350g0dh6_mode,
+   .num_modes = 1,
+   .bpc = 6,
+   .size = {
+   .width = 70,
+   .height = 53,
+   },
+   .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+   .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
+};
+
 static const struct drm_display_mode edt_et057090dhu_mode =
SP_DISPLAY_MODE(25175, 640, 16, 30, 114, 480, 10, 3, 32, 60,
DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC);
@@ -1591,6 +1607,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "chunghwa,claa101wb01",
.data = _claa101wb01
}, {
+   .compatible = "edt,et0350g0dh6",
+   .data = _et0350g0dh6,
+   }, {
.compatible = "edt,et057090dhu",
.data = _et057090dhu,
}, {
-- 
2.1.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel