Re: [PATCH 6/7] drm/solomon: Set preferred color depth and bpp to the correct values

[Javier Martinez Canillas]

On 11/16/22 17:09, Thomas Zimmermann wrote:
> Set the preferred color depth to 24 bits and the fbdev bpp to 32
> bits. This will signal XRGB as default format to clients.
> 
> Signed-off-by: Thomas Zimmermann 
> ---
Reviewed-by: Javier Martinez Canillas 

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

[PATCH 6/7] drm/solomon: Set preferred color depth and bpp to the correct values

[Thomas Zimmermann]

Set the preferred color depth to 24 bits and the fbdev bpp to 32
bits. This will signal XRGB as default format to clients.

Signed-off-by: Thomas Zimmermann 
---
 drivers/gpu/drm/solomon/ssd130x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/solomon/ssd130x.c 
b/drivers/gpu/drm/solomon/ssd130x.c
index 53464afc2b9ac..c3bf3a18302ea 100644
--- a/drivers/gpu/drm/solomon/ssd130x.c
+++ b/drivers/gpu/drm/solomon/ssd130x.c
@@ -876,7 +876,7 @@ static int ssd130x_init_modeset(struct ssd130x_device 
*ssd130x)
drm->mode_config.max_width = max_width;
drm->mode_config.min_height = mode->vdisplay;
drm->mode_config.max_height = max_height;
-   drm->mode_config.preferred_depth = 32;
+   drm->mode_config.preferred_depth = 24;
drm->mode_config.funcs = _mode_config_funcs;
 
/* Primary plane */
@@ -1006,7 +1006,7 @@ struct ssd130x_device *ssd130x_probe(struct device *dev, 
struct regmap *regmap)
if (ret)
return ERR_PTR(dev_err_probe(dev, ret, "DRM device register 
failed\n"));
 
-   drm_fbdev_generic_setup(drm, 0);
+   drm_fbdev_generic_setup(drm, 32);
 
return ssd130x;
 }
-- 
2.38.1