Re: [PATCH 6/8] fbdev/efifb: Do not track parent device status

[Javier Martinez Canillas]

Thomas Zimmermann  writes:

> There will be no EFI framebuffer device for disabled parent devices
> and thus we never probe efifb in that case. Hence remove the tracking
> code from efifb.
>
> Signed-off-by: Thomas Zimmermann 
> ---

Nice cleanup.

Reviewed-by: Javier Martinez Canillas 

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

[PATCH 6/8] fbdev/efifb: Do not track parent device status

[Thomas Zimmermann]

There will be no EFI framebuffer device for disabled parent devices
and thus we never probe efifb in that case. Hence remove the tracking
code from efifb.

Signed-off-by: Thomas Zimmermann 
---
 drivers/video/fbdev/efifb.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index e66ef35fa6b6..f76b7ae00751 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -348,8 +348,6 @@ static struct attribute *efifb_attrs[] = {
 };
 ATTRIBUTE_GROUPS(efifb);
 
-static bool pci_dev_disabled;  /* FB base matches BAR of a disabled device */
-
 static struct resource *bar_resource;
 static u64 bar_offset;
 
@@ -377,7 +375,7 @@ static int efifb_probe(struct platform_device *dev)
if (!si)
return -ENOMEM;
 
-   if (si->orig_video_isVGA != VIDEO_TYPE_EFI || pci_dev_disabled)
+   if (si->orig_video_isVGA != VIDEO_TYPE_EFI)
return -ENODEV;
 
if (fb_get_options("efifb", ))
@@ -653,7 +651,6 @@ static void record_efifb_bar_resource(struct pci_dev *dev, 
int idx, u64 offset)
 
pci_read_config_word(dev, PCI_COMMAND, );
if (!(word & PCI_COMMAND_MEMORY)) {
-   pci_dev_disabled = true;
dev_err(>dev,
"BAR %d: assigned to efifb but device is disabled!\n",
idx);
-- 
2.43.0