Re: [PATCH 6/9] drm/msm: use drm_debug_enabled() to check for debug categories

[Rob Clark]

On Fri, Sep 13, 2019 at 4:52 AM Jani Nikula  wrote:
>
> Allow better abstraction of the drm_debug global variable in the
> future. No functional changes.
>
> Cc: Rob Clark 
> Cc: Sean Paul 
> Cc: linux-arm-...@vger.kernel.org
> Cc: freedr...@lists.freedesktop.org
> Signed-off-by: Jani Nikula 

Reviewed-by: Rob Clark 

I don't think this should conflict w/ anything, so land via drm-misc?

BR,
-R

> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h 
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
> index 9e40f559c51f..00e3353f9aad 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
> @@ -29,7 +29,7 @@
>   */
>  #define DPU_DEBUG(fmt, ...)\
> do {   \
> -   if (unlikely(drm_debug & DRM_UT_KMS))  \
> +   if (unlikely(drm_debug_enabled(DRM_UT_KMS)))   \
> DRM_DEBUG(fmt, ##__VA_ARGS__); \
> else   \
> pr_debug(fmt, ##__VA_ARGS__);  \
> @@ -41,7 +41,7 @@
>   */
>  #define DPU_DEBUG_DRIVER(fmt, ...) \
> do {   \
> -   if (unlikely(drm_debug & DRM_UT_DRIVER))   \
> +   if (unlikely(drm_debug_enabled(DRM_UT_DRIVER)))\
> DRM_ERROR(fmt, ##__VA_ARGS__); \
> else   \
> pr_debug(fmt, ##__VA_ARGS__);  \
> --
> 2.20.1
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 6/9] drm/msm: use drm_debug_enabled() to check for debug categories

[Jani Nikula]

Allow better abstraction of the drm_debug global variable in the
future. No functional changes.

Cc: Rob Clark 
Cc: Sean Paul 
Cc: linux-arm-...@vger.kernel.org
Cc: freedr...@lists.freedesktop.org
Signed-off-by: Jani Nikula 
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
index 9e40f559c51f..00e3353f9aad 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
@@ -29,7 +29,7 @@
  */
 #define DPU_DEBUG(fmt, ...)\
do {   \
-   if (unlikely(drm_debug & DRM_UT_KMS))  \
+   if (unlikely(drm_debug_enabled(DRM_UT_KMS)))   \
DRM_DEBUG(fmt, ##__VA_ARGS__); \
else   \
pr_debug(fmt, ##__VA_ARGS__);  \
@@ -41,7 +41,7 @@
  */
 #define DPU_DEBUG_DRIVER(fmt, ...) \
do {   \
-   if (unlikely(drm_debug & DRM_UT_DRIVER))   \
+   if (unlikely(drm_debug_enabled(DRM_UT_DRIVER)))\
DRM_ERROR(fmt, ##__VA_ARGS__); \
else   \
pr_debug(fmt, ##__VA_ARGS__);  \
-- 
2.20.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel