[PATCH RESEND] drm: include missing types header to drm_mode.h
On Fri, 2010-10-22 at 17:02 -0700, Randy Dunlap wrote:
> On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:
>
> > On Fri, 22 Oct 2010 10:13:19 -0300
> > Davidlohr Bueso wrote:
> >
> > > drm: include missing types header to drm_mode.h
> > >
> > > Signed-off-by: Davidlohr Bueso
> > > ---
> > > include/drm/drm_mode.h |2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
> > > index 0fc7397..eddd7f4 100644
> > > --- a/include/drm/drm_mode.h
> > > +++ b/include/drm/drm_mode.h
> > > @@ -24,6 +24,8 @@
> > > * IN THE SOFTWARE.
> > > */
> > >
> > > +#include
> > > +
> > > #ifndef _DRM_MODE_H
> > > #define _DRM_MODE_H
> > >
> >
> > Does this fix a build error? If so, please send along the compiler
> > error output.
>
>
> Every build that has CONFIG_HEADERS_CHECK=y reports the following:
>
> linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/linux/resource.h:49: found
> __[us]{8,16,32,64} type without #include
>
Yeah that's what made me send the patch.
Thanks,
Davidlohr
[PATCH RESEND] drm: include missing types header to drm_mode.h
On Sat, Oct 23, 2010 at 10:02 AM, Randy Dunlap wrote:
> On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:
>
>> On Fri, 22 Oct 2010 10:13:19 -0300
>> Davidlohr Bueso wrote:
>>
>> > drm: include missing types header to drm_mode.h
>> >
>> > Signed-off-by: Davidlohr Bueso
>> > ---
>> > ?include/drm/drm_mode.h | ? ?2 ++
>> > ?1 files changed, 2 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
>> > index 0fc7397..eddd7f4 100644
>> > --- a/include/drm/drm_mode.h
>> > +++ b/include/drm/drm_mode.h
>> > @@ -24,6 +24,8 @@
>> > ? * IN THE SOFTWARE.
>> > ? */
>> >
>> > +#include
>> > +
>> > ?#ifndef _DRM_MODE_H
>> > ?#define _DRM_MODE_H
>> >
>>
>> Does this fix a build error? ?If so, please send along the compiler
>> error output.
>
>
> Every build that has CONFIG_HEADERS_CHECK=y reports the following:
>
> linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found
> __[us]{8,16,32,64} type without #include
> linux-next-20101022/X64/usr/include/linux/resource.h:49: found
> __[us]{8,16,32,64} type without #include
>
>
Why doesn't the tool understand header recursion? drm_mode.h needs to
include drm.h but the rest already include drm.h.
Including drm.h includes linux/types.h if defined(__linux__)
So really I've said this a few times now, its the stupid tool that is
broken for most of these, fix the tool and I'll fix drm_mode.h
Dave.
[PATCH RESEND] drm: include missing types header to drm_mode.h
On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:
> On Fri, 22 Oct 2010 10:13:19 -0300
> Davidlohr Bueso wrote:
>
> > drm: include missing types header to drm_mode.h
> >
> > Signed-off-by: Davidlohr Bueso
> > ---
> > include/drm/drm_mode.h |2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
> > index 0fc7397..eddd7f4 100644
> > --- a/include/drm/drm_mode.h
> > +++ b/include/drm/drm_mode.h
> > @@ -24,6 +24,8 @@
> > * IN THE SOFTWARE.
> > */
> >
> > +#include
> > +
> > #ifndef _DRM_MODE_H
> > #define _DRM_MODE_H
> >
>
> Does this fix a build error? If so, please send along the compiler
> error output.
Every build that has CONFIG_HEADERS_CHECK=y reports the following:
linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64}
type without #include
linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found
__[us]{8,16,32,64} type without #include
linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64}
type without #include
linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found
__[us]{8,16,32,64} type without #include
linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64}
type without #include
linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found
__[us]{8,16,32,64} type without #include
linux-next-20101022/X64/usr/include/linux/resource.h:49: found
__[us]{8,16,32,64} type without #include
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
[PATCH RESEND] drm: include missing types header to drm_mode.h
On Fri, 22 Oct 2010 10:13:19 -0300 Davidlohr Bueso wrote: > drm: include missing types header to drm_mode.h > > Signed-off-by: Davidlohr Bueso > --- > include/drm/drm_mode.h |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h > index 0fc7397..eddd7f4 100644 > --- a/include/drm/drm_mode.h > +++ b/include/drm/drm_mode.h > @@ -24,6 +24,8 @@ > * IN THE SOFTWARE. > */ > > +#include > + > #ifndef _DRM_MODE_H > #define _DRM_MODE_H > Does this fix a build error? If so, please send along the compiler error output.
[PATCH RESEND] drm: include missing types header to drm_mode.h
drm: include missing types header to drm_mode.h Signed-off-by: Davidlohr Bueso --- include/drm/drm_mode.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..eddd7f4 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -24,6 +24,8 @@ * IN THE SOFTWARE. */ +#include + #ifndef _DRM_MODE_H #define _DRM_MODE_H -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH RESEND] drm: include missing types header to drm_mode.h
drm: include missing types header to drm_mode.h Signed-off-by: Davidlohr Bueso d...@gnu.org --- include/drm/drm_mode.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..eddd7f4 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -24,6 +24,8 @@ * IN THE SOFTWARE. */ +#include linux/types.h + #ifndef _DRM_MODE_H #define _DRM_MODE_H -- 1.7.0.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH RESEND] drm: include missing types header to drm_mode.h
On Fri, 22 Oct 2010 10:13:19 -0300 Davidlohr Bueso d...@gnu.org wrote: drm: include missing types header to drm_mode.h Signed-off-by: Davidlohr Bueso d...@gnu.org --- include/drm/drm_mode.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..eddd7f4 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -24,6 +24,8 @@ * IN THE SOFTWARE. */ +#include linux/types.h + #ifndef _DRM_MODE_H #define _DRM_MODE_H Does this fix a build error? If so, please send along the compiler error output. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH RESEND] drm: include missing types header to drm_mode.h
On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:
On Fri, 22 Oct 2010 10:13:19 -0300
Davidlohr Bueso d...@gnu.org wrote:
drm: include missing types header to drm_mode.h
Signed-off-by: Davidlohr Bueso d...@gnu.org
---
include/drm/drm_mode.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
index 0fc7397..eddd7f4 100644
--- a/include/drm/drm_mode.h
+++ b/include/drm/drm_mode.h
@@ -24,6 +24,8 @@
* IN THE SOFTWARE.
*/
+#include linux/types.h
+
#ifndef _DRM_MODE_H
#define _DRM_MODE_H
Does this fix a build error? If so, please send along the compiler
error output.
Every build that has CONFIG_HEADERS_CHECK=y reports the following:
linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64}
type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64}
type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64}
type without #include linux/types.h
linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/linux/resource.h:49: found
__[us]{8,16,32,64} type without #include linux/types.h
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH RESEND] drm: include missing types header to drm_mode.h
On Sat, Oct 23, 2010 at 10:02 AM, Randy Dunlap rdun...@xenotime.net wrote:
On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:
On Fri, 22 Oct 2010 10:13:19 -0300
Davidlohr Bueso d...@gnu.org wrote:
drm: include missing types header to drm_mode.h
Signed-off-by: Davidlohr Bueso d...@gnu.org
---
include/drm/drm_mode.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
index 0fc7397..eddd7f4 100644
--- a/include/drm/drm_mode.h
+++ b/include/drm/drm_mode.h
@@ -24,6 +24,8 @@
* IN THE SOFTWARE.
*/
+#include linux/types.h
+
#ifndef _DRM_MODE_H
#define _DRM_MODE_H
Does this fix a build error? If so, please send along the compiler
error output.
Every build that has CONFIG_HEADERS_CHECK=y reports the following:
linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found
__[us]{8,16,32,64} type without #include linux/types.h
linux-next-20101022/X64/usr/include/linux/resource.h:49: found
__[us]{8,16,32,64} type without #include linux/types.h
Why doesn't the tool understand header recursion? drm_mode.h needs to
include drm.h but the rest already include drm.h.
Including drm.h includes linux/types.h if defined(__linux__)
So really I've said this a few times now, its the stupid tool that is
broken for most of these, fix the tool and I'll fix drm_mode.h
Dave.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
