Re: [PATCH RFC v7 0/6] Add Unisoc's drm kms module

2020-10-16 Thread Sam Ravnborg
Hi Kevin,

> v7:
> 1. Fix DTC unit name warnings
> 2. Fix the problem of maintainers
> 3. Call drmm_mode_config_init to mode config init
> 4. Embed drm_device in sprd_drm and use devm_drm_dev_alloc
> 5. Replace DRM_XXX with drm_xxx on KMS module, but not suitable for other 
> subsystems
> 6. Remove plane_update stuff, dpu handles all the HW update in 
> crtc->atomic_flush
> 7. Dsi Code structure adjustment, all move to "sprd/"

I can see some of my feedback from last round of review is not
addressed. There were makefile fixes and then I asked for a high-level
intro.

Can you please revisit last round of review feedback to check what was
missed.

Sam


> 
> Kevin Tang (6):
>   dt-bindings: display: add Unisoc's drm master bindings
>   drm/sprd: add Unisoc's drm kms master
>   dt-bindings: display: add Unisoc's dpu bindings
>   drm/sprd: add Unisoc's drm display controller driver
>   dt-bindings: display: add Unisoc's mipi dsi bindings
>   drm/sprd: add Unisoc's drm mipi dsi driver
> 
>  .../display/sprd/sprd,display-subsystem.yaml   |   39 +
>  .../bindings/display/sprd/sprd,sharkl3-dpu.yaml|   83 ++
>  .../display/sprd/sprd,sharkl3-dsi-host.yaml|   98 ++
>  .../display/sprd/sprd,sharkl3-dsi-phy.yaml |   75 +
>  drivers/gpu/drm/Kconfig|2 +
>  drivers/gpu/drm/Makefile   |1 +
>  drivers/gpu/drm/sprd/Kconfig   |   13 +
>  drivers/gpu/drm/sprd/Makefile  |   12 +
>  drivers/gpu/drm/sprd/dpu_r2p0.c|  636 +
>  drivers/gpu/drm/sprd/dw_dsi_ctrl.c |  792 +++
>  drivers/gpu/drm/sprd/dw_dsi_ctrl.h | 1475 
> 
>  drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.c |  276 
>  drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.h |   34 +
>  drivers/gpu/drm/sprd/megacores_pll.c   |  315 +
>  drivers/gpu/drm/sprd/megacores_pll.h   |  146 ++
>  drivers/gpu/drm/sprd/sprd_dphy.c   |  335 +
>  drivers/gpu/drm/sprd/sprd_dphy.h   |   39 +
>  drivers/gpu/drm/sprd/sprd_dpu.c|  501 +++
>  drivers/gpu/drm/sprd/sprd_dpu.h|  217 +++
>  drivers/gpu/drm/sprd/sprd_drm.c|  263 
>  drivers/gpu/drm/sprd/sprd_drm.h|   20 +
>  drivers/gpu/drm/sprd/sprd_dsi.c| 1102 +++
>  drivers/gpu/drm/sprd/sprd_dsi.h|  105 ++
>  23 files changed, 6579 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml
>  create mode 100644 drivers/gpu/drm/sprd/Kconfig
>  create mode 100644 drivers/gpu/drm/sprd/Makefile
>  create mode 100644 drivers/gpu/drm/sprd/dpu_r2p0.c
>  create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl.c
>  create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl.h
>  create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.c
>  create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.h
>  create mode 100644 drivers/gpu/drm/sprd/megacores_pll.c
>  create mode 100644 drivers/gpu/drm/sprd/megacores_pll.h
>  create mode 100644 drivers/gpu/drm/sprd/sprd_dphy.c
>  create mode 100644 drivers/gpu/drm/sprd/sprd_dphy.h
>  create mode 100644 drivers/gpu/drm/sprd/sprd_dpu.c
>  create mode 100644 drivers/gpu/drm/sprd/sprd_dpu.h
>  create mode 100644 drivers/gpu/drm/sprd/sprd_drm.c
>  create mode 100644 drivers/gpu/drm/sprd/sprd_drm.h
>  create mode 100644 drivers/gpu/drm/sprd/sprd_dsi.c
>  create mode 100644 drivers/gpu/drm/sprd/sprd_dsi.h
> 
> -- 
> 2.7.4
> 
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH RFC v7 0/6] Add Unisoc's drm kms module

2020-09-28 Thread Kevin Tang
ChangeList:
v1:
1. only upstream modeset and atomic at first commit. 
2. remove some unused code;
3. use alpha and blend_mode properties;
3. add yaml support;
4. remove auto-adaptive panel driver;
5. bugfix

v2:
1. add sprd crtc and plane module for KMS, preparing for multi crtc
2. remove gem drivers, use generic CMA handlers
3. remove redundant "module_init", all the sub modules loading by KMS

v3:
1. multi crtc design have problem, so rollback to v1

v4:
1. update to gcc-linaro-7.5.0
2. update to Linux 5.6-rc3
3. remove pm_runtime support
4. add COMPILE_TEST, remove unused kconfig
5. "drm_dev_put" on drm_unbind
6. fix some naming convention issue
7. remove semaphore lock for crtc flip
8. remove static variables

v5:
1. optimize encoder and connector code implementation
2. use "platform_get_irq" and "platform_get_resource"
3. drop useless function return type, drop unless debug log
4. custom properties should be separate, so drop it
5. use DRM_XXX replase pr_xxx
6. drop dsi hal callback ops
7. drop unless callback ops checking
8. add comments for sprd dpu structure

v6:
1. Access registers via readl/writel
2. Checking for unsupported KMS properties (format, rotation, blend_mode, etc) 
on plane_check ops
3. Remove always true checks for dpu core ops

v7:
1. Fix DTC unit name warnings
2. Fix the problem of maintainers
3. Call drmm_mode_config_init to mode config init
4. Embed drm_device in sprd_drm and use devm_drm_dev_alloc
5. Replace DRM_XXX with drm_xxx on KMS module, but not suitable for other 
subsystems
6. Remove plane_update stuff, dpu handles all the HW update in 
crtc->atomic_flush
7. Dsi Code structure adjustment, all move to "sprd/"

Kevin Tang (6):
  dt-bindings: display: add Unisoc's drm master bindings
  drm/sprd: add Unisoc's drm kms master
  dt-bindings: display: add Unisoc's dpu bindings
  drm/sprd: add Unisoc's drm display controller driver
  dt-bindings: display: add Unisoc's mipi dsi bindings
  drm/sprd: add Unisoc's drm mipi dsi driver

 .../display/sprd/sprd,display-subsystem.yaml   |   39 +
 .../bindings/display/sprd/sprd,sharkl3-dpu.yaml|   83 ++
 .../display/sprd/sprd,sharkl3-dsi-host.yaml|   98 ++
 .../display/sprd/sprd,sharkl3-dsi-phy.yaml |   75 +
 drivers/gpu/drm/Kconfig|2 +
 drivers/gpu/drm/Makefile   |1 +
 drivers/gpu/drm/sprd/Kconfig   |   13 +
 drivers/gpu/drm/sprd/Makefile  |   12 +
 drivers/gpu/drm/sprd/dpu_r2p0.c|  636 +
 drivers/gpu/drm/sprd/dw_dsi_ctrl.c |  792 +++
 drivers/gpu/drm/sprd/dw_dsi_ctrl.h | 1475 
 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.c |  276 
 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.h |   34 +
 drivers/gpu/drm/sprd/megacores_pll.c   |  315 +
 drivers/gpu/drm/sprd/megacores_pll.h   |  146 ++
 drivers/gpu/drm/sprd/sprd_dphy.c   |  335 +
 drivers/gpu/drm/sprd/sprd_dphy.h   |   39 +
 drivers/gpu/drm/sprd/sprd_dpu.c|  501 +++
 drivers/gpu/drm/sprd/sprd_dpu.h|  217 +++
 drivers/gpu/drm/sprd/sprd_drm.c|  263 
 drivers/gpu/drm/sprd/sprd_drm.h|   20 +
 drivers/gpu/drm/sprd/sprd_dsi.c| 1102 +++
 drivers/gpu/drm/sprd/sprd_dsi.h|  105 ++
 23 files changed, 6579 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml
 create mode 100644 drivers/gpu/drm/sprd/Kconfig
 create mode 100644 drivers/gpu/drm/sprd/Makefile
 create mode 100644 drivers/gpu/drm/sprd/dpu_r2p0.c
 create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl.c
 create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl.h
 create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.c
 create mode 100644 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.h
 create mode 100644 drivers/gpu/drm/sprd/megacores_pll.c
 create mode 100644 drivers/gpu/drm/sprd/megacores_pll.h
 create mode 100644 drivers/gpu/drm/sprd/sprd_dphy.c
 create mode 100644 drivers/gpu/drm/sprd/sprd_dphy.h
 create mode 100644 drivers/gpu/drm/sprd/sprd_dpu.c
 create mode 100644 drivers/gpu/drm/sprd/sprd_dpu.h
 create mode 100644 drivers/gpu/drm/sprd/sprd_drm.c
 create mode 100644 drivers/gpu/drm/sprd/sprd_drm.h
 create mode 100644 drivers/gpu/drm/sprd/sprd_dsi.c
 create mode 100644 drivers/gpu/drm/sprd/sprd_dsi.h

-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel