[PATCH libdrm 1/2] Return an -ENODEV from drmGetDevice() when no device was found.

2016-10-21 Thread Emil Velikov 
On 21 October 2016 at 18:12, Eric Anholt  wrote:
> From: Rob Herring 
>
> Fixes crashes in Mesa on platform device, which expected *device to
> have a device when 0 was returned.
>
> (code from a paste by Rob, commit message by anholt)
>
> Signed-off-by: Eric Anholt 
Reviewed-by: Emil Velikov 

Thanks
Emil

[PATCH libdrm 1/2] Return an -ENODEV from drmGetDevice() when no device was found.

2016-10-21 Thread Alex Deucher 
On Fri, Oct 21, 2016 at 1:12 PM, Eric Anholt  wrote:
> From: Rob Herring 
>
> Fixes crashes in Mesa on platform device, which expected *device to
> have a device when 0 was returned.
>
> (code from a paste by Rob, commit message by anholt)
>
> Signed-off-by: Eric Anholt 

Reviewed-by: Alex Deucher 

> ---
>  xf86drm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/xf86drm.c b/xf86drm.c
> index 9cfca49ddfda..9b52889e4cef 100644
> --- a/xf86drm.c
> +++ b/xf86drm.c
> @@ -3181,6 +3181,8 @@ int drmGetDevice(int fd, drmDevicePtr *device)
>
>  closedir(sysdir);
>  free(local_devices);
> +if (*device == NULL)
> +   return -ENODEV;
>  return 0;
>
>  free_devices:
> --
> 2.9.3
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH libdrm 1/2] Return an -ENODEV from drmGetDevice() when no device was found.

2016-10-21 Thread Eric Anholt 
From: Rob Herring 

Fixes crashes in Mesa on platform device, which expected *device to
have a device when 0 was returned.

(code from a paste by Rob, commit message by anholt)

Signed-off-by: Eric Anholt 
---
 xf86drm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xf86drm.c b/xf86drm.c
index 9cfca49ddfda..9b52889e4cef 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -3181,6 +3181,8 @@ int drmGetDevice(int fd, drmDevicePtr *device)

 closedir(sysdir);
 free(local_devices);
+if (*device == NULL)
+   return -ENODEV;
 return 0;

 free_devices:
-- 
2.9.3