Re: [PATCH v1] arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node

2020-08-18 Thread Stephen Boyd 
Quoting Tanmay Shah (2020-08-17 15:45:27)
> This node defines alternate DP HPD functionality of GPIO.
> 
> Signed-off-by: Tanmay Shah 
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 14 ++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi 
> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index bf2f2bb1aa79..9f97cf5dd9ab 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1457,6 +1457,20 @@ pinconf-sd-cd {
> drive-strength = <2>;
> };
> };
> +
> +   dp_hot_plug_det: dp-hot-plug-det {
> +   pinmux {
> +   pins = "gpio117";
> +   function = "dp_hot";
> +   };
> +
> +   config {

The node name is usualy called pinconf. Please use that.

> +   pins = "gpio117";
> +   bias-disable;
> +   input-enable;
> +   drive-strength = <2>;

My understanding is that drive-strength doesn't do anything when the pin
is input. So this line should be removed.

> +   };
> +   };
> };
>  
> gpu: gpu@500 {
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v1] arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node

2020-08-17 Thread Tanmay Shah 
This node defines alternate DP HPD functionality of GPIO.

Signed-off-by: Tanmay Shah 
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi 
b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index bf2f2bb1aa79..9f97cf5dd9ab 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1457,6 +1457,20 @@ pinconf-sd-cd {
drive-strength = <2>;
};
};
+
+   dp_hot_plug_det: dp-hot-plug-det {
+   pinmux {
+   pins = "gpio117";
+   function = "dp_hot";
+   };
+
+   config {
+   pins = "gpio117";
+   bias-disable;
+   input-enable;
+   drive-strength = <2>;
+   };
+   };
};
 
gpu: gpu@500 {

base-commit: 62975d27d647a40c58d3b96c29b911fc4f33c310
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel