Re: [PATCH v1 0/9] drm/bridge: ps8640 and ti-sn65dsi86 updates
Hi Kieran, On Wed, Jun 22, 2022 at 11:07:26AM +0100, Kieran Bingham wrote: > Hi Sam, > > Quoting Sam Ravnborg (2022-02-06 19:09:11) > > > > > > The code builds - but needs testing. > > > > Hrmff, no it does not build. The fixes was by accident not included. > > Will wait a bit for feedback before posting a v2. > > > > Sam > > Do you have any plan to send a v2 on this series? > > I have built up a series to extend the ti-sn65dsi86 which is now based > on this. (which means I'll have an implied Tested-by: tag for these as > well). That is too good not to do something about it. I will give it a spin this weekend - I do not have time until then. Sam
Re: [PATCH v1 0/9] drm/bridge: ps8640 and ti-sn65dsi86 updates
Hi Sam, Quoting Sam Ravnborg (2022-02-06 19:09:11) > > > > The code builds - but needs testing. > > Hrmff, no it does not build. The fixes was by accident not included. > Will wait a bit for feedback before posting a v2. > > Sam Do you have any plan to send a v2 on this series? I have built up a series to extend the ti-sn65dsi86 which is now based on this. (which means I'll have an implied Tested-by: tag for these as well). -- Kieran
Re: [PATCH v1 0/9] drm/bridge: ps8640 and ti-sn65dsi86 updates
> > The code builds - but needs testing. Hrmff, no it does not build. The fixes was by accident not included. Will wait a bit for feedback before posting a v2. Sam
[PATCH v1 0/9] drm/bridge: ps8640 and ti-sn65dsi86 updates
Add a new macro DRM_BRIDGE_STATE_OPS that can be used to
assign atomic_reset and atomic_{duplicate,destroy}_state to
the default implementations. They will be valid in most cases.
Add a drm variant of media-bus-format.h to hold a single
function to get the bpc from the bus format.
Also add a small drm_atomic_helper_bridge_dsi_input_bus_fmt helper.
Update ti-sn65dsi86 to support atomic and NO_CONNECTOR.
The NO_CONNECTOR support was from Rob Clark - I just rebased it.
To support NO_CONNECTOR use the newly introduced function to
lokk up bpc from the bus format.
Update parade-ps8640 to support atomic. To do this just migrate
to the atomic variants of the operations and add the few mandatry
missing callbacks.
A few of the patches are migrated from a patchset I posted several
months ago and I decided to add them here for now, which explains
why there is a v4 of a patch in a v1 submission.
For the output bus fmt stuff I did what I think is correct - but
as I have paged out all my memory of this it may be all wrong.
The code builds - but needs testing.
I was temped to move bridge helpers to a new drm_bridge_helper.c
but that will wait until next time.
Sam
Rob Clark (1):
drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support
Sam Ravnborg (8):
drm/bridge: add DRM_BRIDGE_STATE_OPS macro
drm: add drm specific media-bus-format header file
drm: add drm_atomic_helper_bridge_dsi_input_bus_fmt
drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs
drm/bridge: ti-sn65dsi86: Fetch bpc via drm_bridge_state
drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs
drm/bridge: ps8640: plug atomic_get_input_bus_fmts
drm/bridge: Drop unused drm_bridge_chain functions
drivers/gpu/drm/bridge/parade-ps8640.c | 18 --
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 57 +
drivers/gpu/drm/drm_atomic_helper.c| 41
drivers/gpu/drm/drm_bridge.c | 110 -
include/drm/drm_atomic_helper.h| 7 +++
include/drm/drm_bridge.h | 40
include/drm/media-bus-format.h | 53
7 files changed, 157 insertions(+), 169 deletions(-)
