Re: [PATCH v1 1/3] drm/bridge: lt8912b: Add suspend/resume support

[Robert Foss]

On Wed, Nov 15, 2023 at 1:14 PM Francesco Dolcini  wrote:
>
> From: Stefan Eichenberger 
>
> Add support for suspend and resume. The lt8912b will power off when
> going into suspend and power on when resuming.
>
> Signed-off-by: Stefan Eichenberger 
> Signed-off-by: Francesco Dolcini 
> ---
>  drivers/gpu/drm/bridge/lontium-lt8912b.c | 28 
>  1 file changed, 28 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c 
> b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> index 03532efb893b..097ab04234b7 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> @@ -634,6 +634,33 @@ static const struct drm_bridge_funcs lt8912_bridge_funcs 
> = {
> .get_edid = lt8912_bridge_get_edid,
>  };
>
> +static int lt8912_bridge_resume(struct device *dev)
> +{
> +   struct lt8912 *lt = dev_get_drvdata(dev);
> +   int ret;
> +
> +   ret = lt8912_hard_power_on(lt);
> +   if (ret)
> +   return ret;
> +
> +   ret = lt8912_soft_power_on(lt);
> +   if (ret)
> +   return ret;
> +
> +   return lt8912_video_on(lt);
> +}
> +
> +static int lt8912_bridge_suspend(struct device *dev)
> +{
> +   struct lt8912 *lt = dev_get_drvdata(dev);
> +
> +   lt8912_hard_power_off(lt);
> +
> +   return 0;
> +}
> +
> +static DEFINE_SIMPLE_DEV_PM_OPS(lt8912_bridge_pm_ops, lt8912_bridge_suspend, 
> lt8912_bridge_resume);
> +
>  static int lt8912_parse_dt(struct lt8912 *lt)
>  {
> struct gpio_desc *gp_reset;
> @@ -770,6 +797,7 @@ static struct i2c_driver lt8912_i2c_driver = {
> .driver = {
> .name = "lt8912",
> .of_match_table = lt8912_dt_match,
> +   .pm = pm_sleep_ptr(<8912_bridge_pm_ops),
> },
> .probe = lt8912_probe,
> .remove = lt8912_remove,
> --
> 2.25.1
>

Reviewed-by: Robert Foss 

[PATCH v1 1/3] drm/bridge: lt8912b: Add suspend/resume support

[Francesco Dolcini]

From: Stefan Eichenberger 

Add support for suspend and resume. The lt8912b will power off when
going into suspend and power on when resuming.

Signed-off-by: Stefan Eichenberger 
Signed-off-by: Francesco Dolcini 
---
 drivers/gpu/drm/bridge/lontium-lt8912b.c | 28 
 1 file changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c 
b/drivers/gpu/drm/bridge/lontium-lt8912b.c
index 03532efb893b..097ab04234b7 100644
--- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
+++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
@@ -634,6 +634,33 @@ static const struct drm_bridge_funcs lt8912_bridge_funcs = 
{
.get_edid = lt8912_bridge_get_edid,
 };
 
+static int lt8912_bridge_resume(struct device *dev)
+{
+   struct lt8912 *lt = dev_get_drvdata(dev);
+   int ret;
+
+   ret = lt8912_hard_power_on(lt);
+   if (ret)
+   return ret;
+
+   ret = lt8912_soft_power_on(lt);
+   if (ret)
+   return ret;
+
+   return lt8912_video_on(lt);
+}
+
+static int lt8912_bridge_suspend(struct device *dev)
+{
+   struct lt8912 *lt = dev_get_drvdata(dev);
+
+   lt8912_hard_power_off(lt);
+
+   return 0;
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(lt8912_bridge_pm_ops, lt8912_bridge_suspend, 
lt8912_bridge_resume);
+
 static int lt8912_parse_dt(struct lt8912 *lt)
 {
struct gpio_desc *gp_reset;
@@ -770,6 +797,7 @@ static struct i2c_driver lt8912_i2c_driver = {
.driver = {
.name = "lt8912",
.of_match_table = lt8912_dt_match,
+   .pm = pm_sleep_ptr(<8912_bridge_pm_ops),
},
.probe = lt8912_probe,
.remove = lt8912_remove,
-- 
2.25.1