Re: [PATCH v1 4/4] fbtft: Replace 'depends on FB_TFT' by 'if FB_TFT ... endif'
On Wed, Jan 26, 2022 at 12:54:13AM -0800, Joe Perches wrote: > On Tue, 2022-01-25 at 22:21 +0200, Andy Shevchenko wrote: > > Replace 'depends on FB_TFT' by 'if FB_TFT ... endif' > > for the sake of deduplication. > [] > > diff --git a/drivers/video/fbtft/Kconfig b/drivers/video/fbtft/Kconfig > [] > > @@ -10,87 +10,75 @@ menuconfig FB_TFT > > select FB_DEFERRED_IO > > select FB_BACKLIGHT > > > > +if FB_TFT > > + > [] > > config FB_TFT_PCD8544 > > tristate "FB driver for the PCD8544 LCD Controller" > > - depends on FB_TFT > > help > > Generic Framebuffer support for PCD8544 > > > > @@ -108,62 +96,52 @@ config FB_TFT_S6D02A1 > > Looks like you missed a couple. Thanks! I'll incorporate it, if the series has a continuation. -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 4/4] fbtft: Replace 'depends on FB_TFT' by 'if FB_TFT ... endif'
On Tue, 2022-01-25 at 22:21 +0200, Andy Shevchenko wrote: > Replace 'depends on FB_TFT' by 'if FB_TFT ... endif' > for the sake of deduplication. [] > diff --git a/drivers/video/fbtft/Kconfig b/drivers/video/fbtft/Kconfig [] > @@ -10,87 +10,75 @@ menuconfig FB_TFT > select FB_DEFERRED_IO > select FB_BACKLIGHT > > +if FB_TFT > + [] > config FB_TFT_PCD8544 > tristate "FB driver for the PCD8544 LCD Controller" > - depends on FB_TFT > help > Generic Framebuffer support for PCD8544 > > @@ -108,62 +96,52 @@ config FB_TFT_S6D02A1 Looks like you missed a couple. --- drivers/video/fbtft/Kconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/fbtft/Kconfig b/drivers/video/fbtft/Kconfig index 14ea3c6a60da0..4a02871f2cc71 100644 --- a/drivers/video/fbtft/Kconfig +++ b/drivers/video/fbtft/Kconfig @@ -84,13 +84,11 @@ config FB_TFT_PCD8544 config FB_TFT_RA8875 tristate "FB driver for the RA8875 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for RA8875 config FB_TFT_S6D02A1 tristate "FB driver for the S6D02A1 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for S6D02A1
Re: [PATCH v1 4/4] fbtft: Replace 'depends on FB_TFT' by 'if FB_TFT ... endif'
On 1/25/22 12:21, Andy Shevchenko wrote: > Replace 'depends on FB_TFT' by 'if FB_TFT ... endif' > for the sake of deduplication. > > Signed-off-by: Andy Shevchenko > --- > drivers/video/fbtft/Kconfig | 33 - > 1 file changed, 4 insertions(+), 29 deletions(-) > > diff --git a/drivers/video/fbtft/Kconfig b/drivers/video/fbtft/Kconfig > index 4d29e8c1014e..14ea3c6a60da 100644 > --- a/drivers/video/fbtft/Kconfig > +++ b/drivers/video/fbtft/Kconfig > @@ -10,87 +10,75 @@ menuconfig FB_TFT Reviewed-by: Randy Dunlap thanks. -- ~Randy
[PATCH v1 4/4] fbtft: Replace 'depends on FB_TFT' by 'if FB_TFT ... endif'
Replace 'depends on FB_TFT' by 'if FB_TFT ... endif' for the sake of deduplication. Signed-off-by: Andy Shevchenko --- drivers/video/fbtft/Kconfig | 33 - 1 file changed, 4 insertions(+), 29 deletions(-) diff --git a/drivers/video/fbtft/Kconfig b/drivers/video/fbtft/Kconfig index 4d29e8c1014e..14ea3c6a60da 100644 --- a/drivers/video/fbtft/Kconfig +++ b/drivers/video/fbtft/Kconfig @@ -10,87 +10,75 @@ menuconfig FB_TFT select FB_DEFERRED_IO select FB_BACKLIGHT +if FB_TFT + config FB_TFT_AGM1264K_FL tristate "FB driver for the AGM1264K-FL LCD display" - depends on FB_TFT help Framebuffer support for the AGM1264K-FL LCD display (two Samsung KS0108 compatible chips) config FB_TFT_BD663474 tristate "FB driver for the BD663474 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for BD663474 config FB_TFT_HX8340BN tristate "FB driver for the HX8340BN LCD Controller" - depends on FB_TFT help Generic Framebuffer support for HX8340BN config FB_TFT_HX8347D tristate "FB driver for the HX8347D LCD Controller" - depends on FB_TFT help Generic Framebuffer support for HX8347D config FB_TFT_HX8353D tristate "FB driver for the HX8353D LCD Controller" - depends on FB_TFT help Generic Framebuffer support for HX8353D config FB_TFT_HX8357D tristate "FB driver for the HX8357D LCD Controller" - depends on FB_TFT help Generic Framebuffer support for HX8357D config FB_TFT_ILI9163 tristate "FB driver for the ILI9163 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for ILI9163 config FB_TFT_ILI9320 tristate "FB driver for the ILI9320 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for ILI9320 config FB_TFT_ILI9325 tristate "FB driver for the ILI9325 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for ILI9325 config FB_TFT_ILI9340 tristate "FB driver for the ILI9340 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for ILI9340 config FB_TFT_ILI9341 tristate "FB driver for the ILI9341 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for ILI9341 config FB_TFT_ILI9481 tristate "FB driver for the ILI9481 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for ILI9481 config FB_TFT_ILI9486 tristate "FB driver for the ILI9486 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for ILI9486 config FB_TFT_PCD8544 tristate "FB driver for the PCD8544 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for PCD8544 @@ -108,62 +96,52 @@ config FB_TFT_S6D02A1 config FB_TFT_S6D1121 tristate "FB driver for the S6D1211 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for S6D1121 config FB_TFT_SEPS525 tristate "FB driver for the SEPS525 LCD Controller" - depends on FB_TFT help Generic Framebuffer support for SEPS525 Say Y if you have such a display that utilizes this controller. config FB_TFT_SH1106 tristate "FB driver for the SH1106 OLED Controller" - depends on FB_TFT help Framebuffer support for SH1106 config FB_TFT_SSD1289 tristate "FB driver for the SSD1289 LCD Controller" - depends on FB_TFT help Framebuffer support for SSD1289 config FB_TFT_SSD1305 tristate "FB driver for the SSD1305 OLED Controller" - depends on FB_TFT help Framebuffer support for SSD1305 config FB_TFT_SSD1306 tristate "FB driver for the SSD1306 OLED Controller" - depends on FB_TFT help Framebuffer support for SSD1306 config FB_TFT_SSD1331 tristate "FB driver for the SSD1331 LCD Controller" - depends on FB_TFT help Framebuffer support for SSD1331 config FB_TFT_SSD1351 tristate "FB driver for the SSD1351 LCD Controller" - depends on FB_TFT help Framebuffer support for SSD1351 config FB_TFT_ST7735R tristate "FB driver for the ST7735R LCD Controller" - depends on FB_TFT help Generic Framebuffer support for ST7735R config FB_TFT_ST7789V tristate "FB driver for the ST7789V LCD Controller" - depends on FB_TFT help This enables generic framebuffer support for the Sitronix ST7789V display controller. The controller is intended for small color @@ -173,30 +151,27 @@ config FB_TFT_ST7789V config FB_TFT_TI
