Re: [PATCH v1 5/8] arm64: dts: renesas: white-hawk-cpu: Add DP output support

[Laurent Pinchart]

Hi Tomi,

Thank you for the patch.

On Thu, Nov 17, 2022 at 02:25:44PM +0200, Tomi Valkeinen wrote:
> From: Tomi Valkeinen 
> 
> Add DT nodes needed for the mini DP connector. The DP is driven by
> sn65dsi86, which in turn gets the pixel data from the SoC via DSI.
> 
> Signed-off-by: Tomi Valkeinen 

Reviewed-by: Laurent Pinchart 

> ---
>  .../dts/renesas/r8a779g0-white-hawk-cpu.dtsi  | 94 +++
>  1 file changed, 94 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> index c10740aee9f6..8aab859aac7a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> @@ -97,6 +97,15 @@ memory@6 {
>   reg = <0x6 0x 0x1 0x>;
>   };
>  
> + reg_1p2v: regulator-1p2v {
> + compatible = "regulator-fixed";
> + regulator-name = "fixed-1.2V";
> + regulator-min-microvolt = <120>;
> + regulator-max-microvolt = <120>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
>   reg_1p8v: regulator-1p8v {
>   compatible = "regulator-fixed";
>   regulator-name = "fixed-1.8V";
> @@ -114,6 +123,24 @@ reg_3p3v: regulator-3p3v {
>   regulator-boot-on;
>   regulator-always-on;
>   };
> +
> + mini-dp-con {
> + compatible = "dp-connector";
> + label = "CN5";
> + type = "mini";
> +
> + port {
> + mini_dp_con_in: endpoint {
> + remote-endpoint = <_out>;
> + };
> + };
> + };
> +
> + sn65dsi86_refclk: clk-x6 {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <3840>;
> + };
>  };
>  
>   {
> @@ -134,6 +161,23 @@ phy0: ethernet-phy@0 {
>   };
>  };
>  
> + {
> + status = "okay";
> +
> + ports {
> + port@1 {
> + dsi0_out: endpoint {
> + remote-endpoint = <_in>;
> + data-lanes = <1 2 3 4>;
> + };
> + };
> + };
> +};
> +
> + {
> + status = "okay";
> +};
> +
>  _clk {
>   clock-frequency = <1666>;
>  };
> @@ -172,6 +216,51 @@ eeprom@50 {
>   };
>  };
>  
> + {
> + pinctrl-0 = <_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> + clock-frequency = <40>;
> +
> + bridge@2c {
> + compatible = "ti,sn65dsi86";
> + reg = <0x2c>;
> +
> + clocks = <_refclk>;
> + clock-names = "refclk";
> +
> + interrupt-parent = <_ex>;
> + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> +
> + enable-gpios = < 26 GPIO_ACTIVE_HIGH>;
> +
> + vccio-supply = <_1p8v>;
> + vpll-supply = <_1p8v>;
> + vcca-supply = <_1p2v>;
> + vcc-supply = <_1p2v>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + sn65dsi86_in: endpoint {
> + remote-endpoint = <_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + sn65dsi86_out: endpoint {
> + remote-endpoint = <_dp_con_in>;
> + };
> + };
> + };
> + };
> +};
> +
>   {
>   pinctrl-0 = <_pins>;
>   pinctrl-1 = <_pins>;
> @@ -221,6 +310,11 @@ i2c0_pins: i2c0 {
>   function = "i2c0";
>   };
>  
> + i2c1_pins: i2c1 {
> + groups = "i2c1";
> + function = "i2c1";
> + };
> +
>   keys_pins: keys {
>   pins = "GP_5_0", "GP_5_1", "GP_5_2";
>   bias-pull-up;

-- 
Regards,

Laurent Pinchart

Re: [PATCH v1 5/8] arm64: dts: renesas: white-hawk-cpu: Add DP output support

[Kieran Bingham]

Quoting Tomi Valkeinen (2022-11-17 12:25:44)
> From: Tomi Valkeinen 
> 
> Add DT nodes needed for the mini DP connector. The DP is driven by
> sn65dsi86, which in turn gets the pixel data from the SoC via DSI.
> 
> Signed-off-by: Tomi Valkeinen 

Reviewed-by: Kieran Bingham 


> ---
>  .../dts/renesas/r8a779g0-white-hawk-cpu.dtsi  | 94 +++
>  1 file changed, 94 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> index c10740aee9f6..8aab859aac7a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> @@ -97,6 +97,15 @@ memory@6 {
> reg = <0x6 0x 0x1 0x>;
> };
>  
> +   reg_1p2v: regulator-1p2v {
> +   compatible = "regulator-fixed";
> +   regulator-name = "fixed-1.2V";
> +   regulator-min-microvolt = <120>;
> +   regulator-max-microvolt = <120>;
> +   regulator-boot-on;
> +   regulator-always-on;
> +   };
> +
> reg_1p8v: regulator-1p8v {
> compatible = "regulator-fixed";
> regulator-name = "fixed-1.8V";
> @@ -114,6 +123,24 @@ reg_3p3v: regulator-3p3v {
> regulator-boot-on;
> regulator-always-on;
> };
> +
> +   mini-dp-con {
> +   compatible = "dp-connector";
> +   label = "CN5";
> +   type = "mini";
> +
> +   port {
> +   mini_dp_con_in: endpoint {
> +   remote-endpoint = <_out>;
> +   };
> +   };
> +   };
> +
> +   sn65dsi86_refclk: clk-x6 {
> +   compatible = "fixed-clock";
> +   #clock-cells = <0>;
> +   clock-frequency = <3840>;
> +   };
>  };
>  
>   {
> @@ -134,6 +161,23 @@ phy0: ethernet-phy@0 {
> };
>  };
>  
> + {
> +   status = "okay";
> +
> +   ports {
> +   port@1 {
> +   dsi0_out: endpoint {
> +   remote-endpoint = <_in>;
> +   data-lanes = <1 2 3 4>;
> +   };
> +   };
> +   };
> +};
> +
> + {
> +   status = "okay";
> +};
> +
>  _clk {
> clock-frequency = <1666>;
>  };
> @@ -172,6 +216,51 @@ eeprom@50 {
> };
>  };
>  
> + {
> +   pinctrl-0 = <_pins>;
> +   pinctrl-names = "default";
> +
> +   status = "okay";
> +   clock-frequency = <40>;
> +
> +   bridge@2c {
> +   compatible = "ti,sn65dsi86";
> +   reg = <0x2c>;
> +
> +   clocks = <_refclk>;
> +   clock-names = "refclk";
> +
> +   interrupt-parent = <_ex>;
> +   interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> +
> +   enable-gpios = < 26 GPIO_ACTIVE_HIGH>;
> +
> +   vccio-supply = <_1p8v>;
> +   vpll-supply = <_1p8v>;
> +   vcca-supply = <_1p2v>;
> +   vcc-supply = <_1p2v>;
> +
> +   ports {
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> +
> +   port@0 {
> +   reg = <0>;
> +   sn65dsi86_in: endpoint {
> +   remote-endpoint = <_out>;
> +   };
> +   };
> +
> +   port@1 {
> +   reg = <1>;
> +   sn65dsi86_out: endpoint {
> +   remote-endpoint = <_dp_con_in>;
> +   };
> +   };
> +   };
> +   };
> +};
> +
>   {
> pinctrl-0 = <_pins>;
> pinctrl-1 = <_pins>;
> @@ -221,6 +310,11 @@ i2c0_pins: i2c0 {
> function = "i2c0";
> };
>  
> +   i2c1_pins: i2c1 {
> +   groups = "i2c1";
> +   function = "i2c1";
> +   };
> +
> keys_pins: keys {
> pins = "GP_5_0", "GP_5_1", "GP_5_2";
> bias-pull-up;
> -- 
> 2.34.1
>

[PATCH v1 5/8] arm64: dts: renesas: white-hawk-cpu: Add DP output support

[Tomi Valkeinen]

From: Tomi Valkeinen 

Add DT nodes needed for the mini DP connector. The DP is driven by
sn65dsi86, which in turn gets the pixel data from the SoC via DSI.

Signed-off-by: Tomi Valkeinen 
---
 .../dts/renesas/r8a779g0-white-hawk-cpu.dtsi  | 94 +++
 1 file changed, 94 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi 
b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
index c10740aee9f6..8aab859aac7a 100644
--- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
@@ -97,6 +97,15 @@ memory@6 {
reg = <0x6 0x 0x1 0x>;
};
 
+   reg_1p2v: regulator-1p2v {
+   compatible = "regulator-fixed";
+   regulator-name = "fixed-1.2V";
+   regulator-min-microvolt = <120>;
+   regulator-max-microvolt = <120>;
+   regulator-boot-on;
+   regulator-always-on;
+   };
+
reg_1p8v: regulator-1p8v {
compatible = "regulator-fixed";
regulator-name = "fixed-1.8V";
@@ -114,6 +123,24 @@ reg_3p3v: regulator-3p3v {
regulator-boot-on;
regulator-always-on;
};
+
+   mini-dp-con {
+   compatible = "dp-connector";
+   label = "CN5";
+   type = "mini";
+
+   port {
+   mini_dp_con_in: endpoint {
+   remote-endpoint = <_out>;
+   };
+   };
+   };
+
+   sn65dsi86_refclk: clk-x6 {
+   compatible = "fixed-clock";
+   #clock-cells = <0>;
+   clock-frequency = <3840>;
+   };
 };
 
  {
@@ -134,6 +161,23 @@ phy0: ethernet-phy@0 {
};
 };
 
+ {
+   status = "okay";
+
+   ports {
+   port@1 {
+   dsi0_out: endpoint {
+   remote-endpoint = <_in>;
+   data-lanes = <1 2 3 4>;
+   };
+   };
+   };
+};
+
+ {
+   status = "okay";
+};
+
 _clk {
clock-frequency = <1666>;
 };
@@ -172,6 +216,51 @@ eeprom@50 {
};
 };
 
+ {
+   pinctrl-0 = <_pins>;
+   pinctrl-names = "default";
+
+   status = "okay";
+   clock-frequency = <40>;
+
+   bridge@2c {
+   compatible = "ti,sn65dsi86";
+   reg = <0x2c>;
+
+   clocks = <_refclk>;
+   clock-names = "refclk";
+
+   interrupt-parent = <_ex>;
+   interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
+
+   enable-gpios = < 26 GPIO_ACTIVE_HIGH>;
+
+   vccio-supply = <_1p8v>;
+   vpll-supply = <_1p8v>;
+   vcca-supply = <_1p2v>;
+   vcc-supply = <_1p2v>;
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   sn65dsi86_in: endpoint {
+   remote-endpoint = <_out>;
+   };
+   };
+
+   port@1 {
+   reg = <1>;
+   sn65dsi86_out: endpoint {
+   remote-endpoint = <_dp_con_in>;
+   };
+   };
+   };
+   };
+};
+
  {
pinctrl-0 = <_pins>;
pinctrl-1 = <_pins>;
@@ -221,6 +310,11 @@ i2c0_pins: i2c0 {
function = "i2c0";
};
 
+   i2c1_pins: i2c1 {
+   groups = "i2c1";
+   function = "i2c1";
+   };
+
keys_pins: keys {
pins = "GP_5_0", "GP_5_1", "GP_5_2";
bias-pull-up;
-- 
2.34.1